Add EVP flagevaluation system tests#7146
Merged
leoromanovsky merged 12 commits intoJun 17, 2026
Merged
Conversation
Contributor
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 39ce169 | Docs | Datadog PR Page | Give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29743d2271
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sameerank
approved these changes
Jun 17, 2026
This was referenced Jun 17, 2026
This reverts commit e082ba4.
nccatoni
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Server-side FFE EVP flagevaluation needs system-test coverage for the worker-visible event contract and SDK-side aggregation behavior before language-by-language rollout.
Changes
tests/ffe/test_flag_eval_evp.pyfor basic EVP emission, repeated-count aggregation, bounded context, runtime default, load aggregation, bounded burst aggregation, high-cardinality aggregation, and production-cap degradation./fferequest support to weblog fixtures so degradation is exercised with 10,050 evaluations without making the test an HTTP throughput benchmark.feature_flags_evp_flagevaluationas a distinct feature marker from dynamic evaluation, exposures, and OTel evaluation metrics.missing_feature (FFL-2446); non-applicable proxy/lambda/OTel manifests are markedirrelevant.Decisions
/api/v2/flagevaluationswithout vendoring dd-source schemas.reasonis neither accepted in payloads nor used as an aggregation dimension.targeting_ruleis expected only when real targeting-rule metadata exists; current no-rule fixtures assert it is omitted.Evidence
Base PR checks on current head
2e7ad616bc525ee76698f34a686da549701b1914:Result:
1 passed in 0.74s.Current manifest state:
golang,nodejs,python,ruby,java,.NET,php:tests/ffe/test_flag_eval_evp.py: missing_feature (FFL-2446).irrelevantwhere the server-side EVP weblog scenario does not apply.Validated sibling evidence includes PHP #7160:
./run.sh FEATURE_FLAGGING_AND_EXPERIMENTATION --library php --weblog apache-mod-8.2 -k "test_flag_eval_evp"- PASS, 8 passed, 2577 deselected in 63.53s. Degradation payload from that run:events=10001,total=10050,full_total=10000,degraded_count=1,degraded_total=50.