Open
Conversation
- Strip PHP startup warnings (e.g. missing .so files) from version string before parsing in component_version.py - Only pass --enable-profiling to datadog-setup.php when the bundle actually contains profiling extensions (local builds may omit them) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
|
bm1549
added a commit
that referenced
this pull request
Mar 16, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: d7b4071 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Switch the PHP parametric Dockerfile from buster to bookworm-6 to match the glibc version produced by build-debug-artifact. This also eliminates the PHP startup warnings that buster emitted, so the component_version.py warning-stripping workaround is no longer needed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bm1549
added a commit
that referenced
this pull request
Mar 17, 2026
The install_ddtrace.sh profiling fix and parametric Dockerfile bookworm change are handled by #6512. This PR now only contains the prepare-local-build.sh script. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
bwoebi
approved these changes
Mar 17, 2026
Contributor
bwoebi
left a comment
bwoebi
left a comment
There was a problem hiding this comment.
Good idea, avoids the requirement for a simple build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Running parametric tests with a locally built PHP tracer on ARM Mac fails because:
datadog-setup.phpis called with--enable-profilingeven when the local bundle doesn't include profiling extensions, causing a hard error.build-debug-artifactcompiles against bookworm (glibc 2.31+), causingGLIBC_2.29' not founderrors at runtime.Changes
PHP conditional profiling (
install_ddtrace.sh): Check whether the bundle tar.gz actually containsdatadog-profilingbefore passing--enable-profilingtodatadog-setup.php. Local builds may not include profiling support, and the flag causes a hard error when the extension is missing.PHP parametric Dockerfile: Switch from
php-8.2_bustertophp-8.2_bookworm-6to match the glibc version produced bybuild-debug-artifact. This also eliminates PHP startup warnings that buster emitted for missing extensions.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present🤖 Generated with Claude Code