Skip to content

Update to.NET Runtime Metrics Default to true#6508

Merged
link04 merged 7 commits intomainfrom
maximo/runtime-metrics-defaults-true
Mar 17, 2026
Merged

Update to.NET Runtime Metrics Default to true#6508
link04 merged 7 commits intomainfrom
maximo/runtime-metrics-defaults-true

Conversation

@link04
Copy link
Contributor

@link04 link04 commented Mar 16, 2026

Motivation

For .NET we are changing the default of DD_RUNTIME_METRICS_ENABLED to true starting .NET 6+.

Changes

Updated SDK_DEFAULT_STABLE_CONFIG to add true for .NET.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@datadog-prod-us1-3
Copy link

datadog-prod-us1-3 bot commented Mar 16, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: aa6902c | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
tests/parametric/test_config_consistency.py                             @DataDog/apm-sdk-capabilities

@link04 link04 marked this pull request as ready for review March 16, 2026 19:13
@link04 link04 requested review from a team as code owners March 16, 2026 19:13
@link04 link04 requested review from genesor and removed request for a team March 16, 2026 19:13
Copy link
Member

@genesor genesor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for the future: When testing default value we should have one test checking default: true and default: false

Having values changing depending on the library in the test code is not ideal for a test in charge of "consistency"

@link04 link04 merged commit 74bb8b1 into main Mar 17, 2026
444 checks passed
@link04 link04 deleted the maximo/runtime-metrics-defaults-true branch March 17, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants