Skip to content

Test PHP helper-rust#6507

Merged
cataphract merged 2 commits intomainfrom
glopes/helper-rust
Mar 17, 2026
Merged

Test PHP helper-rust#6507
cataphract merged 2 commits intomainfrom
glopes/helper-rust

Conversation

@cataphract
Copy link
Contributor

Motivation

Dev versions of dd-trace-php include a Rust implementation of the helper. Test it a new job, alongside PHP 8.5 in fpm.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@cataphract cataphract requested review from a team as code owners March 16, 2026 14:22
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

utils/build/docker/php/php-fpm-8.5.Dockerfile                           @DataDog/apm-php @DataDog/system-tests-core
manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
tests/appsec/rasp/utils.py                                              @DataDog/asm-libraries @DataDog/system-tests-core
utils/build/docker/php/common/install_ddtrace.sh                        @DataDog/apm-php @DataDog/system-tests-core
utils/scripts/ci_orchestrators/time-stats.json                          @DataDog/system-tests-core
utils/scripts/load-binary.sh                                            @DataDog/system-tests-core

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c0e67c01b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cataphract cataphract merged commit 0917146 into main Mar 17, 2026
2057 of 2063 checks passed
@cataphract cataphract deleted the glopes/helper-rust branch March 17, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants