Skip to content

Enable service override test for go#6488

Draft
amarziali wants to merge 1 commit intomainfrom
andrea.marziali/enable-so-go
Draft

Enable service override test for go#6488
amarziali wants to merge 1 commit intomainfrom
andrea.marziali/enable-so-go

Conversation

@amarziali
Copy link
Contributor

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

manifests/golang.yml                                                    @DataDog/dd-trace-go-guild

@datadog-prod-us1-4
Copy link

datadog-prod-us1-4 bot commented Mar 13, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1 Test failed

tests.parametric.test_tracer.Test_TracerServiceNameSource.test_tracer_manual_service_name_sets_srv_src[parametric-golang] from system_tests_suite (Datadog) (Fix with Cursor)
KeyError: '_dd.svc_src'

self = <tests.parametric.test_tracer.Test_TracerServiceNameSource object at 0x7f8ac67b2a50>
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7f8a9162be60>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7f8ac313bc20>

    def test_tracer_manual_service_name_sets_srv_src(self, test_agent: TestAgentAPI, test_library: APMLibrary) -> None:
        """When a span is created with a manually set service name
        The span should have meta._dd.srv.src set to "m" (manual)
        """
...

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 83287f3 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant