enable test for process tags in profiles in dotnet and go#5953
Merged
Conversation
Contributor
|
|
nccatoni
requested changes
Jan 13, 2026
| @features.process_tags | ||
| @missing_feature( | ||
| condition=context.library.name not in ("java", "python"), | ||
| condition=context.library.name not in ("java", "python", "dotnet", "golang"), |
Collaborator
There was a problem hiding this comment.
Please consider moving those decorators to the manifest files
Contributor
Author
There was a problem hiding this comment.
done, not sure about the cpp and rust manifest files, they are pretty empty for now
Collaborator
There was a problem hiding this comment.
Thank you, rust and cpp are only using parametric tests that's why their manifests are shorter. It means that you probably don't need to add an entry
Contributor
Author
There was a problem hiding this comment.
ah ok, yeah makes sense, I'll undo the change for those
Contributor
Author
There was a problem hiding this comment.
php and ruby already excluded the whole file.
Contributor
Author
There was a problem hiding this comment.
the cpp tests are failing :o I've been lied to
nccatoni
approved these changes
Jan 20, 2026
This reverts commit cd35277.
cbeauchesne
previously requested changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
test DataDog/dd-trace-dotnet#7715 (need to wait for release before this can be merged)
plus go implem that was done a while ago
Changes
Also added a check that we received some data because the test was passing if profiler didn't run at all
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present