Skip to content

chore(deps): bump libdatadog to 0a70516#126

Merged
duncanista merged 1 commit intomainfrom
jordan.gonzalez/dependencies/libdatadog-32.0.0
May 4, 2026
Merged

chore(deps): bump libdatadog to 0a70516#126
duncanista merged 1 commit intomainfrom
jordan.gonzalez/dependencies/libdatadog-32.0.0

Conversation

@duncanista
Copy link
Copy Markdown
Contributor

@duncanista duncanista commented May 4, 2026

Summary

Bumps the libdd-* git revs in this workspace from d7eef803 to 0a70516d66314efdd7115644b0da4b3b3e0958e0 (current tip of libdatadog main).

No code changes are required. The previous pin d7eef803... is itself the libdatadog commit feat: add Hash trait to TracerMetadata (#1931), so the workspace was already past the v32.0.0 breaking changes (capability-traits HTTP architecture from #1555 and the TracerMetadata derive removal that #1922/#1931 reversed). The HTTP-trait migration was absorbed in an earlier libdatadog bump — see crates/datadog-trace-agent/src/trace_flusher.rs, where ProxyHttpClient already implements HttpClientTrait and coalesced_traces.send(&http_client) is called against it.

What changed and why

Updated libdd-* revs to 0a70516 in:

  • crates/datadog-serverless-compat/Cargo.toml
  • crates/datadog-metrics-collector/Cargo.toml
  • crates/datadog-trace-agent/Cargo.toml
  • crates/datadog-agent-config/Cargo.toml
  • Cargo.lock (regenerated via cargo update --workspace)

Range covered by this bump

d7eef803..0a70516 is ~10 libdatadog commits — none of them break this workspace's public surface. Notable items:

  • 53c8c16 feat(http-client): add knob to disable connection pooling (#1933)libdd-common gains an opt-in setting; this workspace doesn't need it (existing pool behavior is unchanged).
  • 27aa92c feat(libdd-trace-utils): check for empty value in header datadog-client-computed-stats — defensive parsing change; transparent to callers.
  • b1b58fc feat(telemetry): add session id support to trace export — additive on the telemetry surface; no impact here.
  • 5db2a80 feat(ffe)!: remove extra_logging — feature-flag-engine breaking change; this workspace doesn't depend on libdd-ffe.
  • Several sidecar / tracer-flare / FFI commits that don't touch the crates this workspace pulls in.

Companion PR

DataDog/datadog-lambda-extension#1218 bumps bottlecap to the same SHA. Bottlecap did require code changes — it had not yet adopted the v32 HttpClientTrait architecture and was on a much older libdatadog SHA (c8121f42), so the bump there spans the v32.0.0 breaking changes that this workspace already absorbed.

Test plan

  • cargo check --workspace --all-targets
  • cargo clippy --workspace --all-targets
  • cargo test -p datadog-trace-agent stats_concentrator — both existing tests pass
  • cargo fmt --all -- --check

@duncanista duncanista requested a review from a team as a code owner May 4, 2026 18:49
Copilot AI review requested due to automatic review settings May 4, 2026 18:49
@duncanista duncanista requested a review from a team as a code owner May 4, 2026 18:49
@duncanista duncanista requested review from duncanpharvey and jchrostek-dd and removed request for a team May 4, 2026 18:49
Copy link
Copy Markdown
Collaborator

@duncanpharvey duncanpharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this workspace to libdatadog v32.0.0 (new libdd-* git rev) and adapts datadog-trace-agent stats concentrator storage to account for TracerMetadata no longer implementing Eq/Hash.

Changes:

  • Bump libdd-* git dependencies across crates to 989e11a2bfe68ae669493d726262c424e2cc04a9 and refresh Cargo.lock.
  • Replace HashMap<Arc<TracerMetadata>, SpanConcentrator> with a hashable projected key (ConcentratorKey) and store the original Arc<TracerMetadata> alongside the concentrator for payload construction.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
crates/datadog-trace-agent/src/stats_concentrator_service.rs Introduces ConcentratorKey and updates concentrator map/value layout to work without Hash/Eq on TracerMetadata.
crates/datadog-trace-agent/Cargo.toml Bumps libdd-* git revs for trace-agent dependencies and dev-dependencies.
crates/datadog-serverless-compat/Cargo.toml Bumps libdd-trace-utils git rev.
crates/datadog-metrics-collector/Cargo.toml Bumps libdd-common git rev.
crates/datadog-agent-config/Cargo.toml Bumps libdd-trace-obfuscation / libdd-trace-utils git revs.
Cargo.lock Updates resolved libdd-* package sources/versions to match the new git rev.

Comment thread crates/datadog-trace-agent/src/stats_concentrator_service.rs
Comment thread crates/datadog-trace-agent/src/stats_concentrator_service.rs Outdated
@duncanista duncanista force-pushed the jordan.gonzalez/dependencies/libdatadog-32.0.0 branch from 258ee35 to cc33be1 Compare May 4, 2026 19:00
@duncanista duncanista changed the title fix(trace-agent): bump libdatadog to v32.0.0 chore(deps): bump libdatadog to 0a70516 May 4, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.

@duncanista duncanista merged commit 8817486 into main May 4, 2026
31 checks passed
@duncanista duncanista deleted the jordan.gonzalez/dependencies/libdatadog-32.0.0 branch May 4, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants