chore(deps): bump libdatadog to 0a70516#126
Merged
duncanista merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
duncanpharvey
requested changes
May 4, 2026
Collaborator
There was a problem hiding this comment.
DataDog/libdatadog@d7eef80 -> DataDog/libdatadog@989e11a is a downgrade.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates this workspace to libdatadog v32.0.0 (new libdd-* git rev) and adapts datadog-trace-agent stats concentrator storage to account for TracerMetadata no longer implementing Eq/Hash.
Changes:
- Bump
libdd-*git dependencies across crates to989e11a2bfe68ae669493d726262c424e2cc04a9and refreshCargo.lock. - Replace
HashMap<Arc<TracerMetadata>, SpanConcentrator>with a hashable projected key (ConcentratorKey) and store the originalArc<TracerMetadata>alongside the concentrator for payload construction.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/datadog-trace-agent/src/stats_concentrator_service.rs | Introduces ConcentratorKey and updates concentrator map/value layout to work without Hash/Eq on TracerMetadata. |
| crates/datadog-trace-agent/Cargo.toml | Bumps libdd-* git revs for trace-agent dependencies and dev-dependencies. |
| crates/datadog-serverless-compat/Cargo.toml | Bumps libdd-trace-utils git rev. |
| crates/datadog-metrics-collector/Cargo.toml | Bumps libdd-common git rev. |
| crates/datadog-agent-config/Cargo.toml | Bumps libdd-trace-obfuscation / libdd-trace-utils git revs. |
| Cargo.lock | Updates resolved libdd-* package sources/versions to match the new git rev. |
258ee35 to
cc33be1
Compare
7 tasks
duncanpharvey
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
libdd-*git revs in this workspace fromd7eef803to0a70516d66314efdd7115644b0da4b3b3e0958e0(current tip of libdatadogmain).No code changes are required. The previous pin
d7eef803...is itself the libdatadog commitfeat: add Hash trait to TracerMetadata (#1931), so the workspace was already past the v32.0.0 breaking changes (capability-traits HTTP architecture from #1555 and theTracerMetadataderive removal that #1922/#1931 reversed). The HTTP-trait migration was absorbed in an earlier libdatadog bump — seecrates/datadog-trace-agent/src/trace_flusher.rs, whereProxyHttpClientalready implementsHttpClientTraitandcoalesced_traces.send(&http_client)is called against it.What changed and why
Updated
libdd-*revs to0a70516in:crates/datadog-serverless-compat/Cargo.tomlcrates/datadog-metrics-collector/Cargo.tomlcrates/datadog-trace-agent/Cargo.tomlcrates/datadog-agent-config/Cargo.tomlCargo.lock(regenerated viacargo update --workspace)Range covered by this bump
d7eef803..0a70516is ~10 libdatadog commits — none of them break this workspace's public surface. Notable items:53c8c16feat(http-client): add knob to disable connection pooling (#1933) —libdd-commongains an opt-in setting; this workspace doesn't need it (existing pool behavior is unchanged).27aa92cfeat(libdd-trace-utils): check for empty value in headerdatadog-client-computed-stats— defensive parsing change; transparent to callers.b1b58fcfeat(telemetry): add session id support to trace export — additive on the telemetry surface; no impact here.5db2a80feat(ffe)!: remove extra_logging — feature-flag-engine breaking change; this workspace doesn't depend onlibdd-ffe.Companion PR
DataDog/datadog-lambda-extension#1218 bumps bottlecap to the same SHA. Bottlecap did require code changes — it had not yet adopted the v32
HttpClientTraitarchitecture and was on a much older libdatadog SHA (c8121f42), so the bump there spans the v32.0.0 breaking changes that this workspace already absorbed.Test plan
cargo check --workspace --all-targetscargo clippy --workspace --all-targetscargo test -p datadog-trace-agent stats_concentrator— both existing tests passcargo fmt --all -- --check