feat: add fallback to DD_VERSION for trace stats computation#125
Open
duncanpharvey wants to merge 1 commit intomainfrom
Open
feat: add fallback to DD_VERSION for trace stats computation#125duncanpharvey wants to merge 1 commit intomainfrom
duncanpharvey wants to merge 1 commit intomainfrom
Conversation
duncanpharvey
force-pushed
the
duncan-harvey/trace-stats-version
branch
from
09c3b64 to
3ca99bc
Compare
duncanpharvey
force-pushed
the
duncan-harvey/trace-stats-version
branch
from
3ca99bc to
8431c35
Compare
duncanpharvey
requested review from
Copilot,
kathiehuang and
lucaspimentel
and removed request for
a team and
Copilot
Contributor
|
do you also test these things with sampling enabled? |
apiarian-datadog
approved these changes
May 4, 2026
Collaborator
Author
Now I have! |
kathiehuang
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a fallback in trace stats computation to use
DD_VERSIONif no version is available in the trace payload.Motivation
Some initial traces from the .NET tracer do not include the version in the trace payload.
https://datadoghq.atlassian.net/browse/SVLS-9006
Additional Notes
Describe how to test/QA your changes
Invoked .NET functions that undercounted some stats by version and validated that all trace stats submitted to intake have a version.
With 50% sampling enabled: