feat: add system service allowlist policy#552
Draft
matt-dz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read,reload, andrestartactions.interp.AllowedSystemServicesAPI and--allowed-servicesCLI flag.builtins.CallContext.RemediationOnlycentrally before builtin argument parsing.Motivation
Future
systemctlandjournalctlbuiltins need granular authorization so operators can restrict which services rshell may inspect or control. Command authorization alone is too broad because enabling either command could otherwise expose every system service.Behavior
Service grants use exact, case-sensitive matching:
mysqldoes not matchmysql.service.--allow-all-commandsdoes not bypass the service policy.Library configuration:
Future builtins can enforce the policy with:
This PR adds the authorization foundation only.
systemctlandjournalctlare not implemented yet.Remediation Enforcement
builtins.Command.RemediationOnlyis now enforced centrally by command registration before flags or help are parsed. Remediation mode is also propagated through nested builtin execution paths such asfind -execandxargs.Testing
make fmtgo test -p 1 ./...RSHELL_BASH_TEST=1 go test ./tests/ -run TestShellScenariosAgainstBash -timeout 120sgit diff --checkgofmt -l .