Skip to content

fix: drop no-op install script that triggers Yarn build warning#363

Draft
BridgeAR wants to merge 1 commit into
mainfrom
BridgeAR/2026-06-27-drop-install-build-script
Draft

fix: drop no-op install script that triggers Yarn build warning#363
BridgeAR wants to merge 1 commit into
mainfrom
BridgeAR/2026-06-27-drop-install-build-script

Conversation

@BridgeAR

Copy link
Copy Markdown
Member

Summary

Yarn Berry (Plug'n'Play) prints YN0007: @datadog/pprof must be built for any dependency that declares an install/preinstall/postinstall script, including the no-op "install": "exit 0". The package ships prebuilt binaries and excludes binding.gyp from the published tarball, so a consumer has nothing to build. The script only suppressed npm's implicit node-gyp rebuild in the dev tree; CI and the prepare script build explicitly.

Dropping it stops the spurious warning for downstream Yarn Berry users, e.g. dd-trace on Vercel/Next.js.

A regression test (ts/test/test-no-build-scripts.ts) asserts the manifest declares no build lifecycle scripts.

Note (out of scope)

package.json has a postinstall key at the top level (outside scripts; the nan/Node-24 sed fix). npm and Yarn ignore it there, so it does not trigger YN0007, but it also means that fix never runs. Left untouched here; worth a separate look.

Test plan

  • CI green (build, asan, valgrind, lint/gts)
  • yarn add @datadog/pprof under Yarn Berry no longer prints YN0007

Refs: DataDog/dd-trace-js#5432

Yarn Berry (Plug'n'Play) prints "YN0007: @datadog/pprof must be built" for
any dependency that declares an install/preinstall/postinstall script, even
the no-op "exit 0". The package ships prebuilt binaries and excludes
binding.gyp from the published tarball, so a consumer has nothing to build;
the script only suppressed npm's implicit node-gyp rebuild in the dev tree,
which CI and the prepare script do explicitly. Removing it stops the
spurious warning for Yarn Berry consumers.

Refs: DataDog/dd-trace-js#5432
@datadog-datadog-prod-us1

Copy link
Copy Markdown

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

Pull Request Labels | label   View in Datadog   GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: eed843b | Docs | Datadog PR Page | Give us feedback!

@github-actions

Copy link
Copy Markdown

Overall package size

Self size: 2.19 MB
Deduped: 2.89 MB
No deduping: 2.89 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | pprof-format | 2.2.2 | 500.53 kB | 500.53 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | node-gyp-build | 4.8.4 | 13.86 kB | 13.86 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant