feat: use ip quantization when aggregating peer tags for trace stats#1944
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits intomainfrom May 6, 2026
Conversation
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: f2c6d5d | Docs | Datadog PR Page | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1944 +/- ##
==========================================
- Coverage 71.99% 71.84% -0.15%
==========================================
Files 434 434
Lines 70450 70594 +144
==========================================
- Hits 50718 50717 -1
- Misses 19732 19877 +145
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
duncanpharvey
force-pushed
the
duncan-harvey/trace-stats-peer-tags-ip-quantization
branch
from
8692aa0 to
9fcf423
Compare
Contributor
Author
|
Being handled as part of #1819 |
Contributor
|
My initial plan was to merge this change with my css obfuscation change to put it behind a feature flag but in the end we decided the change is small enough to not break anything (the agent's re-obfuscating peer tags should not change them) |
Eldolfin
approved these changes
May 6, 2026
VianneyRuhlmann
approved these changes
May 6, 2026
Contributor
VianneyRuhlmann
left a comment
VianneyRuhlmann
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing it
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
duncan-harvey/trace-stats-peer-tags-ip-quantization
branch
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Quantize IP addresses for peer tags when aggregating trace stats.
Motivation
Needed for agent side stats computation in the Serverless Compatibility Layer (used as the agent in Azure Functions) in DataDog/serverless-components#124.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.