chore(ci): run thread count test as single threaded#1626
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom Feb 24, 2026
Merged
chore(ci): run thread count test as single threaded#1626gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
Conversation
gyuheon0h
changed the title
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1626 +/- ##
==========================================
+ Coverage 71.07% 71.09% +0.02%
==========================================
Files 423 423
Lines 62491 62491
==========================================
+ Hits 44413 44430 +17
+ Misses 18078 18061 -17
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-02-24 15:13:05 Comparing candidate commit 9ab133f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
gyuheon0h
force-pushed
the
gyuheon0h/flaky-thread-count
branch
from
f74f626 to
1feb236
Compare
ekump
reviewed
Feb 24, 2026
libdd-common/src/test_utils.rs
Outdated
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
| use rusty_fork::rusty_fork_test; |
Contributor
There was a problem hiding this comment.
If you just want to run tests single threaded you can isolate them in a module called single_threaded_tests (example) and nextest will not run them in parallel https://github.com/DataDog/libdatadog/blob/main/.config/nextest.toml#L25
Contributor
Author
There was a problem hiding this comment.
Great idea! Thanks for the tip
ekump
approved these changes
Feb 24, 2026
Contributor
ekump
left a comment
ekump
left a comment
There was a problem hiding this comment.
no objection to rusty-fork if it works, but made an alternate suggestion with no new dev deps.
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
The merge request has been interrupted because the build 98527062 took longer than expected. The current limit for the base branch 'main' is 120 minutes. |
gyuheon0h
changed the title
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
bot
added
mergequeue-status: waiting
and removed
mergequeue-status: rejected
labels
gh-worker-dd-mergequeue-cf854d
bot
deleted the
gyuheon0h/flaky-thread-count
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We had a test to test a util function that counts the number of threads running. It did this by counting the number of threads in the beginning, spawning N threads, then checking that there are (# at beginning + N threads) at the end. This test is flaky, because cargo tests are run in parallel, and threads from other tests running get counted in the beginning, but may finish and not be present when checked after N threads are spawned.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
cargo test --package libdd-common --lib -- test_utils::tests