Mark integration spec fields as fleet_configurable#24564
Conversation
Enable fleet management for fields that were present in RC schemas but incorrectly excluded by fleet_configurable: false in the source specs. Covers oracle (connection params), mongo (DBM sub-options), rabbitmq (prometheus plugin endpoints), snmp (oid_batch_size, global_metrics, ping.interval), postgres (query_metrics/samples sub-fields, autodiscovery.refresh), sqlserver (query_metrics/activity sub-fields).
init_config.oid_batch_size and instances[].ping.interval were not in the committed schema — only instances[].oid_batch_size and init_config.ping.interval are. Reverting those two lines to avoid adding fields that were never part of the schema.
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 6ad37e2 | Docs | Datadog PR Page | Give us feedback! |
Removing fleet_configurable: false is cleaner than explicitly setting true, since fields inherit the integration-level fleet_configurable: true by default.
…fields These were hand-authored into the schema intentionally (Re sync, Mar 16 2026) despite the spec flag. Removing the override keeps them fleet-manageable.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b33cdb07d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -815,7 +809,6 @@ files: | |||
| value: | |||
| type: integer | |||
| example: 20_000_000 | |||
There was a problem hiding this comment.
When this hidden query_metrics.batch_max_content_size option becomes Fleet-configurable, a remote config can override the instance value even though the runtime code says this knob is only for debugging and should normally match the Agent forwarder limit; in particular, setting it above the default limit can make DBM payloads rejected (postgres/datadog_checks/postgres/statements.py:164-171). Please keep this field excluded unless Fleet also constrains it to the safe Agent value.
Useful? React with 👍 / 👎.
san-jos
changed the title
Validation ReportAll 21 validations passed. Show details
|
2 participants
What does this PR do?
Enable fleet management for fields that were present in RC schemas but incorrectly excluded by fleet_configurable: false in the source specs.
Motivation
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged