Skip to content

Migrate account_config.json to oneof-discriminated schema#23861

Open
nmuesch wants to merge 1 commit into
masterfrom
nick/migrate-account-configs-to-protojson
Open

Migrate account_config.json to oneof-discriminated schema#23861
nmuesch wants to merge 1 commit into
masterfrom
nick/migrate-account-configs-to-protojson

Conversation

@nmuesch
Copy link
Copy Markdown
Contributor

@nmuesch nmuesch commented May 28, 2026

Summary

Migrate account_config.json for klaviyo and ringcentral to the new oneof-discriminated schema. Each entry's type / auth_method discriminator becomes the field name carrying the type-specific config; zero-valued placeholders are dropped.

Semantically equivalent — verified by round-tripping each file through the parsing + validation pipeline and asserting structural equality before and after.

Rewrites legacy flat-format account_config.json files to the
oneof-discriminated shape: the type discriminator becomes the field
name (e.g. "type": "text" -> "text": {...}), type-specific config nests
under it, and zero-valued placeholders like "pattern": null are
dropped.

Touches:
- klaviyo
- ringcentral
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 28, 2026

Validation Report

Validation Description Status
qa-label Validate the pull request declares whether it needs QA for the next Agent release

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (20)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@datadog-official
Copy link
Copy Markdown
Contributor

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

Validate repository | Run Validations / Validate   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Pull request #23861 is missing an Agent-release QA decision label. Must set either 'qa/required' or 'qa/skip-qa'.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3005d3e | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant