Migrate account_config.json to oneof-discriminated schema#23861
Open
nmuesch wants to merge 1 commit into
Open
Conversation
Rewrites legacy flat-format account_config.json files to the
oneof-discriminated shape: the type discriminator becomes the field
name (e.g. "type": "text" -> "text": {...}), type-specific config nests
under it, and zero-valued placeholders like "pattern": null are
dropped.
Touches:
- klaviyo
- ringcentral
Contributor
Validation Report
Run Passed validations (20)
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
account_config.jsonfor klaviyo and ringcentral to the new oneof-discriminated schema. Each entry'stype/auth_methoddiscriminator becomes the field name carrying the type-specific config; zero-valued placeholders are dropped.Semantically equivalent — verified by round-tripping each file through the parsing + validation pipeline and asserting structural equality before and after.