Add explicit fleet configurable false to specs#23843
Conversation
|
Validation ReportAll 21 validations passed. Show details
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19f5259a1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| value: | ||
| type: string | ||
| example: http://teamcity.<ACCOUNT_NAME>.com | ||
| fleet_configurable: false |
There was a problem hiding this comment.
Keep the REST API server Fleet-configurable
For the Fleet-enabled TeamCity spec, this marks the required rest_api.server endpoint as not configurable while the nested REST API options such as projects remain Fleet-configurable. In Fleet, users can enable/configure the REST API instance but cannot provide the required TeamCity server URL, so the generated instance is invalid unless the value is already hard-coded elsewhere; the analogous OpenMetrics server option above is still configurable.
Useful? React with 👍 / 👎.
|
Ran a script against the PR, checking if all spec fields have a boolean value for All of these are parent groups in their respective YAML files and their child fields have the |
What does this PR do?
Adds explicit
fleet_configurable: falsemarkers to concrete configuration spec option fields that do not already havefleet_configurable: true.This is part of a migration to make fleet_configurable true by default.
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged