Skip to content

Add explicit fleet configurable false to specs#23843

Open
nubtron wants to merge 1 commit into
masterfrom
nubtron/fleet-configurable-false
Open

Add explicit fleet configurable false to specs#23843
nubtron wants to merge 1 commit into
masterfrom
nubtron/fleet-configurable-false

Conversation

@nubtron
Copy link
Copy Markdown
Contributor

@nubtron nubtron commented May 27, 2026

What does this PR do?

Adds explicit fleet_configurable: false markers to concrete configuration spec option fields that do not already have fleet_configurable: true.

This is part of a migration to make fleet_configurable true by default.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@datadog-prod-us1-3
Copy link
Copy Markdown

datadog-prod-us1-3 Bot commented May 27, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

PR | test / upload-coverage   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. The action datadog/install-datadog-ci-github-action@v1 is not allowed in the repository due to restrictions on action origins.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 19f5259 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 28, 2026

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19f5259a1d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

value:
type: string
example: http://teamcity.<ACCOUNT_NAME>.com
fleet_configurable: false
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the REST API server Fleet-configurable

For the Fleet-enabled TeamCity spec, this marks the required rest_api.server endpoint as not configurable while the nested REST API options such as projects remain Fleet-configurable. In Fleet, users can enable/configure the REST API instance but cannot provide the required TeamCity server URL, so the generated instance is invalid unless the value is already hard-coded elsewhere; the analogous OpenMetrics server option above is still configurable.

Useful? React with 👍 / 👎.

@dkirov-dd
Copy link
Copy Markdown
Contributor

dkirov-dd commented May 28, 2026

Ran a script against the PR, checking if all spec fields have a boolean value for fleet_configurable, here is what I found:

Missing or invalid fleet_configurable settings:
  - mysql/assets/configuration/spec.yaml:109: field `database_identifier` at `database_identifier` has fleet_configurable=None; expected true or false
  - mysql/assets/configuration/spec.yaml:291: field `options` at `options` has fleet_configurable=None; expected true or false
  - mysql/assets/configuration/spec.yaml:439: field `collect_settings` at `collect_settings` has fleet_configurable=None; expected true or false
  - mysql/assets/configuration/spec.yaml:458: field `collect_schemas` at `collect_schemas` has fleet_configurable=None; expected true or false
  - mysql/assets/configuration/spec.yaml:486: field `schemas_collection` at `schemas_collection` has fleet_configurable=None; expected true or false
  - mysql/assets/configuration/spec.yaml:670: field `query_activity` at `query_activity` has fleet_configurable=None; expected true or false
  - mysql/assets/configuration/spec.yaml:697: field `index_metrics` at `index_metrics` has fleet_configurable=None; expected true or false
  - mysql/assets/configuration/spec.yaml:733: field `aws` at `aws` has fleet_configurable=None; expected true or false
  - mysql/assets/configuration/spec.yaml:791: field `gcp` at `gcp` has fleet_configurable=None; expected true or false
  - mysql/assets/configuration/spec.yaml:823: field `azure` at `azure` has fleet_configurable=None; expected true or false
  - mysql/assets/configuration/spec.yaml:859: field `obfuscator_options` at `obfuscator_options` has fleet_configurable=None; expected true or false
  - rabbitmq/assets/configuration/spec.yaml:265: field `prometheus_plugin` at `prometheus_plugin` has fleet_configurable=None; expected true or false
  - snmp/assets/configuration/spec.yaml:156: field `ping` at `ping` has fleet_configurable=None; expected true or false
  - torchserve/assets/configuration/spec.yaml:20: field `OpenMetrics` at `OpenMetrics` has fleet_configurable=None; expected true or false
  - torchserve/assets/configuration/spec.yaml:55: field `Inference API` at `Inference API` has fleet_configurable=None; expected true or false
  - torchserve/assets/configuration/spec.yaml:68: field `Management API` at `Management API` has fleet_configurable=None; expected true or false

All of these are parent groups in their respective YAML files and their child fields have the fleet_configurable boolean.
Let me know if that's expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation integration/aerospike integration/ambari integration/apache integration/argocd integration/btrfs integration/cacti integration/cassandra_nodetool integration/cilium integration/cisco_aci integration/clickhouse integration/cloudera integration/consul integration/control_m integration/coredns integration/couch integration/couchbase integration/directory integration/disk integration/do_query_actions integration/elastic integration/envoy integration/esxi integration/etcd integration/external_dns integration/gunicorn integration/haproxy integration/hazelcast integration/http_check integration/ibm_i integration/ibm_mq integration/ibm_was integration/infiniband integration/istio integration/kafka_actions integration/kafka_consumer integration/krakend integration/kube_apiserver_metrics integration/kube_controller_manager integration/kube_dns integration/kube_scheduler integration/kubelet integration/kubernetes_state integration/kyototycoon integration/lparstats integration/mapreduce integration/marathon integration/mcache integration/mongo integration/mysql integration/network integration/nginx integration/nifi integration/nutanix integration/octopus_deploy integration/openstack_controller integration/oracle integration/pgbouncer integration/postgres integration/prefect integration/process integration/prometheus integration/rabbitmq integration/redisdb integration/riak integration/riakcs integration/sap_hana integration/singlestore integration/slurm integration/snmp integration/sonarqube integration/spark integration/sqlserver integration/statsd integration/supabase integration/supervisord integration/teamcity integration/tekton integration/teradata integration/tibco_ems integration/tls integration/torchserve integration/vertica integration/voltdb integration/vsphere integration/wmi_check integration/yarn qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations team/container-integrations team/data-observability team/data-streams-monitoring team/database-monitoring-agent team/documentation team/ndm-integrations team/network-device-monitoring-core team/windows-products

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants