Skip to content

Remove dependency size artifact fetching#23831

Draft
lucia-sb wants to merge 2 commits into
masterfrom
lucia-sb/remove-size-artifact-fetching
Draft

Remove dependency size artifact fetching#23831
lucia-sb wants to merge 2 commits into
masterfrom
lucia-sb/remove-size-artifact-fetching

Conversation

@lucia-sb
Copy link
Copy Markdown
Contributor

What does this PR do?

Removes the --dependency-sizes option from ddev size status and removes the GitHub Actions artifact lookup path used to fetch dependency size data. The command now resolves dependency sizes from local lockfiles.

Motivation

Dependency sizes are represented by the local resolved lockfiles, so ddev size status no longer needs to shell out to gh or download GitHub Actions artifacts to calculate dependency sizes.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@dd-octo-sts dd-octo-sts Bot added the ddev label May 25, 2026
@datadog-prod-us1-5
Copy link
Copy Markdown

datadog-prod-us1-5 Bot commented May 25, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

PR All Windows | test / j31a95c8 (py3.13-windows-odbc-2025-single) / SQL Server on Windows-py3.13-windows-odbc-2025-single   View in Datadog   GitHub Actions

🔄 Retry job. This looks flaky and may succeed on retry. SQL connection failed: Unable to connect to SQL Server. TCP connection refused. Driver issue or database not found.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 87.56% (-0.39%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fa8fa87 | Docs | Datadog PR Page | Give us feedback!

@lucia-sb lucia-sb added the qa/skip-qa Automatically skip this PR for the next QA label May 25, 2026 — with ChatGPT Codex Connector
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Major version bump
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 25, 2026

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.97%. Comparing base (ae6846b) to head (fa8fa87).

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev qa/skip-qa Automatically skip this PR for the next QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant