Skip to content

Add Battery Check Integration Tile#22290

Merged
mrafi97 merged 13 commits intomasterfrom
mrafi/battery-check
Jan 22, 2026
Merged

Add Battery Check Integration Tile#22290
mrafi97 merged 13 commits intomasterfrom
mrafi/battery-check

Conversation

@mrafi97
Copy link
Copy Markdown
Contributor

@mrafi97 mrafi97 commented Jan 8, 2026

What does this PR do?

This PR adds the initial manifest and readme for the Battery check that was added in DataDog/datadog-agent#43789 and DataDog/datadog-agent#44371

Motivation

https://datadoghq.atlassian.net/browse/WINA-2204

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@mrafi97 mrafi97 added the qa/skip-qa Automatically skip this PR for the next QA label Jan 8, 2026
@mrafi97 mrafi97 mentioned this pull request Jan 12, 2026
Merged
3 tasks
@mrafi97 mrafi97 force-pushed the mrafi/battery-check branch from 6136249 to 1ec5a36 Compare January 12, 2026 20:45
@mrafi97 mrafi97 marked this pull request as ready for review January 12, 2026 22:16
@mrafi97 mrafi97 requested review from a team as code owners January 12, 2026 22:16
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jan 12, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56a401ba80

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread battery/assets/dashboards/battery_overview.json Outdated
@@ -0,0 +1 @@
Please build an out-of-the-box dashboard for your integration following our best practices here: https://datadoghq.dev/integrations-core/guidelines/dashboards/#best-practices No newline at end of file
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace dashboard placeholder with valid JSON

The dashboard file is plain text, not JSON. Any tooling that parses dashboards (for example, validation or dashboard import) expects valid JSON in assets/dashboards/*.json; with the current contents, those workflows will fail or skip this dashboard, so the integration ships without a usable dashboard. Replace the placeholder with a valid dashboard JSON (or remove the file if no dashboard is intended).

Useful? React with 👍 / 👎.

@buraizu
Copy link
Copy Markdown
Contributor

buraizu commented Jan 13, 2026

Hi @mrafi97, just confirming because display_on_public_website is currently false. Is this PR ready for documentation team review, or still waiting for additional updates?

@buraizu buraizu added the editorial review Waiting on a more in-depth review from a docs team editor label Jan 13, 2026
@buraizu
Copy link
Copy Markdown
Contributor

buraizu commented Jan 13, 2026

Created DOCS-13096 for documentation team review

@mrafi97
Copy link
Copy Markdown
Contributor Author

mrafi97 commented Jan 13, 2026

Hi @buraizu yeah should be fine to review. My plan is to merge this to master for now as is and then later on set display_on_public_website to true once the integration is GA. Let me know if that's fine.

evazorro
evazorro requested changes Jan 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@evazorro evazorro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple minor fixes and a couple questions!

Comment thread battery/README.md Outdated
Comment thread battery/assets/dashboards/battery_overview.json Outdated
@@ -0,0 +1 @@
Please build an out-of-the-box dashboard for your integration following our best practices here: https://datadoghq.dev/integrations-core/guidelines/dashboards/#best-practices No newline at end of file
Copy link
Copy Markdown
Contributor

@evazorro evazorro Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrafi97 are you planning to add dashboards in this PR? Or will that come when you're ready to GA?

Copy link
Copy Markdown
Contributor Author

@mrafi97 mrafi97 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not planning on adding a dashboard on this PR, it will be added in a different PR.

Comment thread battery/metadata.csv Outdated
Comment thread battery/README.md Outdated
Comment thread battery/README.md Outdated
Comment thread battery/README.md Outdated
Comment thread battery/README.md Outdated
Comment thread battery/README.md Outdated
Comment thread battery/README.md Outdated
@mrafi97 @evazorro
Apply suggestions from code review
170573d 
Co-authored-by: Eva Parish <eva.parish@datadoghq.com>
@mrafi97 mrafi97 requested a review from evazorro January 21, 2026 21:23
evazorro
evazorro previously approved these changes Jan 21, 2026
View reviewed changes
sarah-witt
sarah-witt reviewed Jan 21, 2026
View reviewed changes
Comment thread battery/manifest.json Outdated
@mrafi97 @sarah-witt
Apply suggestions from code review
013738e 
Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
@temporal-github-worker-1 temporal-github-worker-1 Bot dismissed evazorro’s stale review January 21, 2026 22:44

Review from evazorro is dismissed. Related teams and files:

  • documentation
    • battery/manifest.json
sarah-witt
sarah-witt reviewed Jan 21, 2026
View reviewed changes
Comment thread battery/manifest.json Outdated
@mrafi97 @sarah-witt
Update battery/manifest.json
a230faa 
Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
@mrafi97 mrafi97 added this pull request to the merge queue Jan 22, 2026
Merged via the queue into master with commit 770094e Jan 22, 2026
54 checks passed
@mrafi97 mrafi97 deleted the mrafi/battery-check branch January 22, 2026 15:12
github-actions Bot pushed a commit that referenced this pull request Jan 22, 2026
@github-merge-queue @evazorro
Add Battery Check Integration Tile (#22290)
52ef580 
* adding battery check tile

* updating information

* updating codeowners

* updating readme

* removing images folder

* adjusting metadata.csv

* fixing CI errors

* fixing ddev error

* updating readme

* Apply suggestions from code review

Co-authored-by: Eva Parish <eva.parish@datadoghq.com>

* Delete battery/assets/dashboards/battery_overview.json

* Apply suggestions from code review

Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>

* Update battery/manifest.json

Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>

---------

Co-authored-by: Eva Parish <eva.parish@datadoghq.com>
Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com> 770094e
lukepatrick pushed a commit to lukepatrick/integrations-core that referenced this pull request Mar 17, 2026
@mrafi97 @evazorro
@sarah-witt @lukepatrick
Add Battery Check Integration Tile (DataDog#22290)
9e68ec8 
* adding battery check tile

* updating information

* updating codeowners

* updating readme

* removing images folder

* adjusting metadata.csv

* fixing CI errors

* fixing ddev error

* updating readme

* Apply suggestions from code review

Co-authored-by: Eva Parish <eva.parish@datadoghq.com>

* Delete battery/assets/dashboards/battery_overview.json

* Apply suggestions from code review

Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>

* Update battery/manifest.json

Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>

---------

Co-authored-by: Eva Parish <eva.parish@datadoghq.com>
Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
Signed-off-by: lukepatrick <lukephilips@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@sarah-witt sarah-witt sarah-witt approved these changes

@jack0x2 jack0x2 jack0x2 approved these changes

@evazorro evazorro Awaiting requested review from evazorro

Assignees

No one assigned

Labels

agent/approved dev/testing dev/tooling docs/review-requested documentation ecosystems/review-requested editorial review Waiting on a more in-depth review from a docs team editor integration/battery product/review-requested qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations team/documentation team/saas-integrations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mrafi97 @buraizu @evazorro @sarah-witt @jack0x2