Skip to content

[AI-6402] DDS: Cisco Secure Client Integration v1.0.0#22260

Merged
steveny91 merged 14 commits intoDataDog:masterfrom
bhargavnariyanicrest:cisco-secure-client-v1.0.0
Feb 9, 2026
Merged

[AI-6402] DDS: Cisco Secure Client Integration v1.0.0#22260
steveny91 merged 14 commits intoDataDog:masterfrom
bhargavnariyanicrest:cisco-secure-client-v1.0.0

Conversation

@manan-crest
Copy link
Copy Markdown
Contributor

What does this PR do?

This is a initial release PR of Cisco Secure Client integration including all the required assets.

Integration Logo Sources: https://upload.wikimedia.org/wikipedia/commons/0/08/Cisco_logo_blue_2016.svg

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@manan-crest manan-crest changed the title DDS: Cisco ASA Integration v1.0.0 [AI-6402] DDS: Cisco ASA Integration v1.0.0 Jan 2, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

'%{regex("[^']*"):usr.name}' local ip %{ip:local_ip}
(connected|reconnected) from %{ip:network.client.ip}

parsing_session_connection %{parse_event_type_header}'%{parse_session_id_ip_and_user}:\s*%{regex("Session disconnected|Session connected"):action}. Session Type:\s*%{notSpace:session_type}(, Duration:\s*%{notSpace:duration}, Bytes xmt:\s*%{number:network.bytes_read}, Bytes rcv:\s*%{number:network.bytes_written}, Reason:\s*%{regex(".*(?= \\')"):reason})?\s*'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Capture bytes xmt/rcv into correct fields

The Meraki session parser maps Bytes xmt to network.bytes_read and Bytes rcv to network.bytes_written, which inverts transmitted vs. received counts. For AnyConnect session manager logs that include these fields, downstream dashboards and analytics will show read/write byte totals swapped (xmt is outbound, rcv is inbound). This affects any events type=anyconnect_vpn_session_manager messages with byte counters.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@manan-crest manan-crest changed the title [AI-6402] DDS: Cisco ASA Integration v1.0.0 [AI-6402] DDS: Cisco Secure Client Integration v1.0.0 Jan 2, 2026
@hestonhoffman hestonhoffman added the editorial review Waiting on a more in-depth review from a docs team editor label Jan 2, 2026
@manan-crest manan-crest force-pushed the cisco-secure-client-v1.0.0 branch from 7a55cb3 to 640871c Compare January 5, 2026 06:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 5, 2026

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent
cisco_secure_client/datadog_checks/cisco_secure_client/__about__.py
cisco_secure_client/datadog_checks/cisco_secure_client/__init__.py
cisco_secure_client/datadog_checks/cisco_secure_client/data/conf.yaml.example
cisco_secure_client/changelog.d/22260.added
cisco_secure_client/pyproject.toml

Comment thread cisco_secure_client/README.md
Copy link
Copy Markdown
Contributor

@evazorro evazorro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making those changes! One more small suggestion.

@manan-crest manan-crest requested a review from evazorro February 3, 2026 07:57
steveny91
steveny91 previously approved these changes Feb 3, 2026
evazorro
evazorro previously approved these changes Feb 3, 2026
@steveny91
Copy link
Copy Markdown
Contributor

@manan-crest Would you mind resolving the merge conflict? That is the only thing blocking this merge now. I can't seem to see what file is in conflict

@temporal-github-worker-1 temporal-github-worker-1 Bot dismissed steveny91’s stale review February 9, 2026 16:08

Review from steveny91 is dismissed. Related teams and files:

  • agent-integrations
    • .github/CODEOWNERS
    • .github/workflows/config/labeler.yml
@manan-crest manan-crest force-pushed the cisco-secure-client-v1.0.0 branch from 6ab2b29 to d398937 Compare February 9, 2026 16:52
@temporal-github-worker-1 temporal-github-worker-1 Bot dismissed evazorro’s stale review February 9, 2026 16:52

Review from evazorro is dismissed. Related teams and files:

  • documentation
    • cisco_secure_client/README.md
    • cisco_secure_client/assets/cisco-secure-client.svg
    • cisco_secure_client/assets/configuration/spec.yaml
    • cisco_secure_client/assets/dashboards/cisco_secure_client_overview.json
    • cisco_secure_client/assets/dashboards/cisco_secure_client_vpn_connection_insights.json
    • cisco_secure_client/assets/monitors/cisco_secure_client_maximum_client_connection_limit_reached.json
    • cisco_secure_client/datadog_checks/cisco_secure_client/data/conf.yaml.example
    • cisco_secure_client/manifest.json
@steveny91 steveny91 added this pull request to the merge queue Feb 9, 2026
Merged via the queue into DataDog:master with commit aa88427 Feb 9, 2026
69 of 83 checks passed
github-actions Bot pushed a commit that referenced this pull request Feb 9, 2026
* Add: Cisco Secure Client Integration

* Fix: CI check Failures

* Update: minor changes for CI

* Update: remap bytes standard attributes

* Update: change minimum agent version

* Update: CODEOWNERS

* Update: review comments

* Update: readme as per review comments

* Add: owner field in manifest.json

* Update: README.md note aa88427
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhargavnariyanicrest Can this dashboard image please be updated without the blank widgets?

lukepatrick pushed a commit to lukepatrick/integrations-core that referenced this pull request Mar 17, 2026
* Add: Cisco Secure Client Integration

* Fix: CI check Failures

* Update: minor changes for CI

* Update: remap bytes standard attributes

* Update: change minimum agent version

* Update: CODEOWNERS

* Update: review comments

* Update: readme as per review comments

* Add: owner field in manifest.json

* Update: README.md note

Signed-off-by: lukepatrick <lukephilips@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants