[DO NOT MERGE] Test fixture: editorial issues for dashboard review composer - #38672
[DO NOT MERGE] Test fixture: editorial issues for dashboard review composer#38672buraizu wants to merge 3 commits into
Conversation
Preview links (active after the
|
buraizu
left a comment
There was a problem hiding this comment.
- New section restates existing content and breaks the page's heading pattern
Every other heading on this page is phrased as a question, matching the page's FAQ format; this new heading is a title-case noun phrase, breaking both the question pattern and the sentence-case rule for headings. Its content — that custom-metric counts for percentile-enabled distributions are counted like other metric types — already appears earlier on the page in the "How does this new pipeline for Distributions affect me?" section, and the body is written entirely in passive voice.
Suggested fix: Remove this section since it doesn't add new information beyond what's already stated earlier on the page. If it's kept, rephrase the heading as a question in sentence case and rewrite the body in active voice.
- Bulk-configure bullet list is not parallel
The four list items mix grammatical forms (a declarative statement, an imperative instruction, another declarative statement, and a bare noun phrase), and are inconsistent in capitalization and end punctuation — only one item is capitalized and only one ends with a period.
Suggested fix: Confirm that your wildcard pattern matches only the intended metric names.
- test
[DO NOT MERGE] Test fixture for docs on-call dashboard
This PR exists only to exercise the docs team dashboard's PR review composer. It intentionally introduces editorial issues into a single FAQ page. Do not merge it. Close it once dashboard testing is finished.
What's here
Five deliberate edits to
content/en/metrics/faq/updating-to-distribution-metrics-faq.md, chosen to produce a specific mix of review findings:Three that should produce inline comments with direct replacement suggestions:
utilizeandin order to(word-list swaps).easilyandleverage. This one is indented two spaces on purpose, to verify suggestion blocks preserve leading indentation.Our,allows you to, and a passive trailing clause.Two that should produce general (review-body) comments:
## Percentile Configuration Best Practicessection — heading breaks the file's question pattern and uses title case instead of sentence case; body is passive throughout and restates content from an earlier section.No new technical claims are introduced; edits 4 and 5 restate behavior already documented on the page.
Ready for merge