Include instructions for setting up hierarchical team relationships f… - #38661
Include instructions for setting up hierarchical team relationships f…#38661jessiewu22 wants to merge 5 commits into
Conversation
…or new teams map feature
This comment has been minimized.
This comment has been minimized.
Preview links (active after the
|
OliviaShoup
left a comment
There was a problem hiding this comment.
Lookin good! Reviewing this alongside #38660, which affects the feedback
- Line 76 here is a near-verbatim duplicate of line 85 in #38660 ("...visit the [Teams Map] in the Datadog Internal Developer Portal (IDP)").
- The same broken Teams Map URL appears in both —
[40]here,[7]there. - #38660 removes the Teams API pointer from
manage.md, while this PR adds a Teams API link here, so that pointer effectively migrates pages.
Suggestion: move these four setup methods into #38660's ## Team hierarchies section, so what, why, and how live together in one place. This page would then just cross-link, wwhich matches how it already behaves, since line 62 defers SAML detail to another page and the page closes with "To customize your team, see [Team Management][3]." That collapses most of this PR into a single pointer line and removes the duplicated sentence and duplicated URL at the same time.
If you'd rather keep the split, that's workable too. In that case the duplicated sentence on line 76 should go and this page should link to #38660's section instead.
The blocking item is the Teams Map URL, which would ship a link pinning readers to a one-hour window in the past. The list structure is the other substantive item. Everything else is line-level.
I've written the inline suggestions to work whether or not the content moves, so none of them are wasted if you consolidate.
| 1. In the **Info** tab of the team page, click edit on the **Hierarchy** section | ||
| 1. Select the parent or child teams associated with the team and click save | ||
|
|
||
| As you set up hierarchies, to explore and verify the full map of all teams in your organization, visit the [Teams Map][40] in the Datadog Internal Developer Portal (IDP). |
There was a problem hiding this comment.
Three items here:
- This sentence is duplicated near-verbatim in Add product description for new teams map #38660 (line 85 of
manage.md). See the consolidation note in the review body. Most likely this whole section moves there and this line goes away. - 30 words with two stacked adverbial phrases up front ("As you set up hierarchies, to explore and verify..."). Also
(IDP)is expanded and never reused on the page, so the parenthetical can go.
| As you set up hierarchies, to explore and verify the full map of all teams in your organization, visit the [Teams Map][40] in the Datadog Internal Developer Portal (IDP). | |
| To explore and verify the full map of all teams in your organization, see the [Teams Map][40] in the Datadog Internal Developer Portal. |
|
|
||
| If you have teams with existing members, picking the SAML strict option overrides your settings and removes team members from those teams. Picking the All Sources option preserves existing memberships. To manage teams and team membership using SAML attributes, see [Map SAML attributes to Teams][4]. | ||
|
|
||
| ## Hierarchies for Teams Map |
There was a problem hiding this comment.
Vale flags this heading for sentence-style capitalization, but I'd settle the product name before changing anything. #38660 uses both forms in a single sentence — "Build a Teams map" (lowercase) and "[Teams Map]" (capitalized) — so the name is genuinely unsettled across these two PRs. Whichever you pick should be applied consistently in both.
Separately, worth considering a more action-oriented heading like Set up team hierarchies, which tells readers what they can do here rather than naming a concept.
Co-authored-by: Olivia Shoup <116908616+OliviaShoup@users.noreply.github.com>
Co-authored-by: Olivia Shoup <116908616+OliviaShoup@users.noreply.github.com>
Co-authored-by: Olivia Shoup <116908616+OliviaShoup@users.noreply.github.com>
Co-authored-by: Olivia Shoup <116908616+OliviaShoup@users.noreply.github.com>
…or new teams map feature
What does this PR do? What is the motivation?
Merge readiness
For Datadog employees:
<name>/<description>convention and include the forward slash (/). If you've already created your PR with an incorrect branch name, please rename your branch and open a fresh PR./reviewto run an automated check that catches common issues before a Documentation team member reviews your PR.AI assistance
Additional notes