Include regex syntax note in dogstatsd_mapper#35424
Closed
johannesschillinger-dm wants to merge 3 commits intoDataDog:masterfrom
Closed
Include regex syntax note in dogstatsd_mapper#35424johannesschillinger-dm wants to merge 3 commits intoDataDog:masterfrom
johannesschillinger-dm wants to merge 3 commits intoDataDog:masterfrom
Conversation
Clarify which regex dialect to use for metric name matching
Contributor
|
hey, thank you for the PR! this branch is a fork, which means our usual checks in this repo can't finish running. without the checks, merging is blocked. because this is your first PR with us and it's only 1 line, i took your change and put it on my own branch here. thanks again. we appreciate your contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify which regex dialect to use for metric name matching
What does this PR do? What is the motivation?
It was unclear, which regex dialect is supported by dogstatsd. This PR adds clarification
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
AI assistance
no AI interference
Additional notes