Conversation
|
Thank you for updating Change log entry section 👏 Visited at: 2026-01-15 13:54:00 UTC |
Typing analysisIgnored filesThis PR clears 2 ignored files. It increases the percentage of typed files from 39.22% to 39.44% (+0.22%). Ignored files (+0-2)✅ Cleared:Note: Ignored files are excluded from the next sections. Untyped methodsThis PR introduces 1 untyped method, and clears 1 untyped method. It increases the percentage of typed methods from 57.9% to 58.21% (+0.31%). Untyped methods (+1-1)❌ Introduced:If you believe a method or an attribute is rightfully untyped or partially typed, you can add |
BenchmarksBenchmark execution time: 2026-01-16 10:40:12 Comparing candidate commit 292314b in PR branch Found 1 performance improvements and 3 performance regressions! Performance is the same for 40 metrics, 2 unstable metrics. scenario:line instrumentation - targeted
scenario:line instrumentation - untargeted
scenario:method instrumentation
scenario:profiling - Allocations ()
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 292314b | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
200ebf9 to
10e1a50
Compare
|
@codex find critical bugs and corner cases in this PR's code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10e1a50b70
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d4ebd84 to
3a663fd
Compare
|
nice work! Thanks for fixing the url for excon instrumentation! |
* Add additional notes to clarify internals of the library used.
What does this PR do?
Add the first part of the API10 RFC. Where we supply more data to the WAF on downstream requests, more stats and metrics. Ideally we should process request/response body and track redirects.
Motivation:
I want to start with small adjustments for RASP methods and metrics and see where it will lead without doing a refactoring, we are missing some other metrics and telemetry and before changing it would be good to see the full picture.
Change log entry
Yes. AppSec: Add analysis of the downstream requests.
Additional Notes:
First of all this is not a perfect implementation, we already notice an accumulation of the look a like methods and modules. And that will be addresses in rework of the event engine we using.
Second, this PR fixes few overlooks and enable (partially) ignore typespecs. With typespecs I decide to go as low as I can to avoid PR bloating and prepare a ticket to clean the rest.
How to test the change?
CI + ST