build(deps): bump tests/FeatureFlags/ffe-system-test-data from 4446371 to 6c7f63b#4000
Conversation
Bumps [tests/FeatureFlags/ffe-system-test-data](https://github.com/DataDog/ffe-system-test-data) from `4446371` to `6c7f63b`. - [Commits](DataDog/ffe-system-test-data@4446371...6c7f63b) --- updated-dependencies: - dependency-name: tests/FeatureFlags/ffe-system-test-data dependency-version: 6c7f63b8f89b8d636d4686c7c2a3b9481c41e485 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c6fb6ace7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit 4446371bc1ca52bd526356927ef42d380145b118 | |||
| Subproject commit 6c7f63b8f89b8d636d4686c7c2a3b9481c41e485 | |||
There was a problem hiding this comment.
Validate the new fixture result metadata
This bump adds canonical cases where conformance depends on result.reason/result.errorCode (for example malformed or unknown-operator flags expect the caller default rather than a parse error), but the repo's only fixture sweep in tests/ext/ffe/system_test_data_evaluate.phpt::run_fixture_case still compares only result.value. With the current native mapping in components-rs/ffe.rs::result_from_assignment, those malformed per-flag configs can return the default value with PARSE_ERROR/ERROR, so the updated conformance data will still report failures=0 while PHP disagrees with the new fixture semantics; please extend the harness/API assertions or defer the fixture bump until the evaluator behavior is aligned.
Useful? React with 👍 / 👎.
|
Bumps tests/FeatureFlags/ffe-system-test-data from
4446371to6c7f63b.Commits
6c7f63bMerge pull request #16 from DataDog/leo.romanovsky/malformed-split-shards-fix...cf7d7d5Add missing split shards fixtured9d8020Merge pull request #15 from DataDog/leo.romanovsky/date-window-assignment-rea...e4803e3Fix temporal allocation reasons95ff628Fix date-window assignment reasons57e98f5Merge pull request #14 from DataDog/leo.romanovsky/add-regex-evaluation-cases6db17e8Add regex evaluation edge cases1db25ecMerge pull request #11 from DataDog/leo.romanovsky/ffe-malformed-config-cases5c5578dDocument FFE config tolerance fixtures106db8aAdd FFE config tolerance fixture casesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)