fix(ci): skip rc_process_tags.phpt before PHP 7.4 (skip-task sidecar leak)#3992
Open
Leiyks wants to merge 2 commits into
Open
fix(ci): skip rc_process_tags.phpt before PHP 7.4 (skip-task sidecar leak)#3992Leiyks wants to merge 2 commits into
Leiyks wants to merge 2 commits into
Conversation
|
…leak) On PHP < 7.4 the SKIPIF/skip-task causes the sidecar to fetch process tags already, leaking the .skip entrypoint name into the FILE-phase RC request (entrypoint.name:rc_process_tags.skip). This surfaced as the windows test_c [7.2]/[7.3] failure (and 1h hang). Match the existing request-replayer family guard (client_side_stats, dd_trace_agent_env, shm_data_internal_fns) which skips on all platforms for PHP < 7.4. [windows test_c]
Leiyks
force-pushed
the
leiyks/fix-ci-rc-process-tags-windows
branch
from
3e027ba to
94db34b
Compare
Leiyks
changed the title
bwoebi
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds the request-replayer family's standard SKIPIF guard to
tests/ext/remote_config/rc_process_tags.phpt:On PHP < 7.4 the SKIPIF/skip-task makes the sidecar fetch process tags during the skip phase, leaking the
.skipentrypoint into the FILE-phase RC request (entrypoint.name:rc_process_tags.skip). RC is polled by the sidecar (ext/sidecar.cdd_sidecar_post_connectpassesprocess_tags+ RC config to the session), so the leak is a sidecar-state leak. This matchesclient_side_stats*,dd_trace_agent_env,shm_data_internal_fns.Scope / honesty note
This fixes a real but non-fatal sub-failure:
rc_process_tags.phptwas reporting FAIL on Windows 7.2/7.3 (now correctly SKIP).It does NOT make the
windows test_c [7.2]/[7.3]jobs green. Those jobs fail via a 1-hour timeout / hang that is independent of this test: with this fix applied,rc_process_tagsis cleanly skipped but the job still hangs ~52 min aftertests/ext/sandbox/die_in_sandbox.phptand is killed at the 1h limit (identical hang point on master without this change). That hang is a separate issue (tracked separately) — likely a thread-mode sidecar shutdown deadlock on Windows.So: merge this as a legitimate test-correctness cleanup, but it should not be expected to turn
windows test_cgreen on its own.