Skip to content

Avoid empty headless test sessions - #12146

Open
daniel-mohedano wants to merge 1 commit into
masterfrom
daniel.mohedano/empty-sessions
Open

Avoid empty headless test sessions#12146
daniel-mohedano wants to merge 1 commit into
masterfrom
daniel.mohedano/empty-sessions

Conversation

@daniel-mohedano

Copy link
Copy Markdown
Contributor

What Does This Do

Creates test sessions and modules lazily in headless mode. If a test framework discovers no tests and emits no events, no empty session is reported.

Build-system child processes continue to initialize proxy sessions eagerly.

Motivation

When working under headless mode (such as when using sbt), a project might invoke test discovery for a testing framework that does not actually run any tests. Still, a test session and module would end up being created, and reported as empty with no tests run inside.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@daniel-mohedano daniel-mohedano added type: bug fix Bug fix comp: ci visibility Continuous Integration Visibility tag: ai generated Largely based on code generated by an AI or LLM labels Aug 5, 2026
@daniel-mohedano

Copy link
Copy Markdown
Contributor Author

@codex review

@daniel-mohedano

Copy link
Copy Markdown
Contributor Author

/datadog autotest review

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Test Environment - sbt-scalatest

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 54.86 55.43 $\color{green}{\blacktriangledown}$ -0.57 55.43 $\color{green}{\blacktriangledown}$ -0.57 62/264
agentEvpProxy 53.89 n/a n/a n/a n/a -

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Test Environment - netflix-zuul

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 88.00 87.80 $\color{red}{\blacktriangle}$ +0.20 87.80 $\color{red}{\blacktriangle}$ +0.20 55/162
agentless 81.00 81.05 $\color{green}{\blacktriangledown}$ -0.05 81.05 $\color{green}{\blacktriangledown}$ -0.05 32/135
agentlessCodeCoverage 96.06 95.12 $\color{red}{\blacktriangle}$ +0.94 97.04 $\color{green}{\blacktriangledown}$ -0.98 31/134
agentlessLineCoverage 111.54 111.62 $\color{green}{\blacktriangledown}$ -0.08 111.62 $\color{green}{\blacktriangledown}$ -0.08 31/134

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: ba6753d0d3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@datadog-datadog-prod-us1-2

This comment has been minimized.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Test Environment - nebula-release-plugin

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 36.67 37.15 $\color{green}{\blacktriangledown}$ -0.48 37.15 $\color{green}{\blacktriangledown}$ -0.48 48/148
agentless 35.19 36.42 $\color{green}{\blacktriangledown}$ -1.23 36.42 $\color{green}{\blacktriangledown}$ -1.23 28/128
agentlessCodeCoverage 44.06 44.48 $\color{green}{\blacktriangledown}$ -0.42 44.48 $\color{green}{\blacktriangledown}$ -0.42 28/128
agentlessLineCoverage 54.35 55.43 $\color{green}{\blacktriangledown}$ -1.08 71.89 $\color{green}{\blacktriangledown}$ -17.54 29/131

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Test Environment - reactive-streams-jvm

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 21.35 21.65 $\color{green}{\blacktriangledown}$ -0.30 21.65 $\color{green}{\blacktriangledown}$ -0.30 56/169
agentless 18.50 18.82 $\color{green}{\blacktriangledown}$ -0.32 18.82 $\color{green}{\blacktriangledown}$ -0.32 31/136
agentlessCodeCoverage 19.38 19.59 $\color{green}{\blacktriangledown}$ -0.21 19.99 $\color{green}{\blacktriangledown}$ -0.61 31/133
agentlessLineCoverage 26.52 26.45 $\color{red}{\blacktriangle}$ +0.07 28.65 $\color{green}{\blacktriangledown}$ -2.13 28/129

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Test Environment - pass4s

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 7.68 10.33 $\color{green}{\blacktriangledown}$ -2.65 9.73 $\color{green}{\blacktriangledown}$ -2.05 32/128
agentless 6.83 8.29 $\color{green}{\blacktriangledown}$ -1.46 9.16 $\color{green}{\blacktriangledown}$ -2.33 32/128
agentlessCodeCoverage 15.57 16.69 $\color{green}{\blacktriangledown}$ -1.12 16.36 $\color{green}{\blacktriangledown}$ -0.79 30/126

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Test Environment - heliboard

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 9.83 10.13 $\color{green}{\blacktriangledown}$ -0.30 9.73 $\color{red}{\blacktriangle}$ +0.10 30/129

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Test Environment - sonar-kotlin

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 14.02 12.87 $\color{red}{\blacktriangle}$ +1.15 12.87 $\color{red}{\blacktriangle}$ +1.15 56/151
agentless 11.32 11.88 $\color{green}{\blacktriangledown}$ -0.56 12.12 $\color{green}{\blacktriangledown}$ -0.80 32/123
agentlessCodeCoverage 14.54 15.11 $\color{green}{\blacktriangledown}$ -0.57 15.11 $\color{green}{\blacktriangledown}$ -0.57 32/124
agentlessLineCoverage 16.22 17.03 $\color{green}{\blacktriangledown}$ -0.81 17.73 $\color{green}{\blacktriangledown}$ -1.51 32/126

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Test Environment - jolokia

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 94.69 93.23 $\color{red}{\blacktriangle}$ +1.46 93.23 $\color{red}{\blacktriangle}$ +1.46 56/164
agentless 91.14 89.58 $\color{red}{\blacktriangle}$ +1.56 89.58 $\color{red}{\blacktriangle}$ +1.56 32/139
agentlessCodeCoverage 98.78 99.00 $\color{green}{\blacktriangledown}$ -0.22 99.00 $\color{green}{\blacktriangledown}$ -0.22 32/137
agentlessLineCoverage 100.23 99.00 $\color{red}{\blacktriangle}$ +1.23 99.00 $\color{red}{\blacktriangle}$ +1.23 30/133

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@dd-octo-sts

dd-octo-sts Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.00 s 13.94 s [-0.3%; +1.2%] (no difference)
startup:insecure-bank:tracing:Agent 12.96 s 12.97 s [-1.1%; +1.1%] (no difference)
startup:petclinic:appsec:Agent 16.96 s 16.75 s [+0.4%; +2.0%] (maybe worse)
startup:petclinic:iast:Agent 16.94 s 17.08 s [-1.6%; -0.1%] (maybe better)
startup:petclinic:profiling:Agent 16.85 s 17.01 s [-2.4%; +0.4%] (no difference)
startup:petclinic:sca:Agent 16.85 s 16.67 s [+0.2%; +2.0%] (maybe worse)
startup:petclinic:tracing:Agent 16.07 s 15.59 s [-1.3%; +7.4%] (no difference)

Commit: ba6753d0 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Test Environment - okhttp

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 19.31 19.59 $\color{green}{\blacktriangledown}$ -0.28 19.59 $\color{green}{\blacktriangledown}$ -0.28 59/160
agentless 18.25 19.20 $\color{green}{\blacktriangledown}$ -0.95 19.20 $\color{green}{\blacktriangledown}$ -0.95 33/132
agentlessCodeCoverage 21.30 22.54 $\color{green}{\blacktriangledown}$ -1.24 22.54 $\color{green}{\blacktriangledown}$ -1.24 35/133
agentlessLineCoverage 38.33 38.67 $\color{green}{\blacktriangledown}$ -0.34 41.06 $\color{green}{\blacktriangledown}$ -2.73 32/135

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The lazy headless lifecycle behaves correctly across empty discovery, policy lookup, skipped tests, and eager child-process initialization. Focused handler tests and the JUnit 5 instrumentation suite produced no duplicate sessions, unexpected spans, or lifecycle failures; production telemetry was unavailable in this public-repository review.

Was this helpful? React 👍 or 👎

📊 Validated against 5 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit ba6753d · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Test Environment - spring_boot

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 16.40 16.36 $\color{red}{\blacktriangle}$ +0.04 16.36 $\color{red}{\blacktriangle}$ +0.04 58/159
agentless 10.27 9.92 $\color{red}{\blacktriangle}$ +0.35 9.73 $\color{red}{\blacktriangle}$ +0.54 32/133
agentlessCodeCoverage 14.26 13.40 $\color{red}{\blacktriangle}$ +0.86 13.40 $\color{red}{\blacktriangle}$ +0.86 32/134
agentlessLineCoverage 22.73 22.09 $\color{red}{\blacktriangle}$ +0.64 23.45 $\color{green}{\blacktriangledown}$ -0.72 31/134

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Test Environment - sonar-java

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 13.61 2.04 $\color{red}{\blacktriangle}$ +11.57 11.19 $\color{red}{\blacktriangle}$ +2.42 57/156
agentless 4.68 11.65 $\color{green}{\blacktriangledown}$ -6.97 13.40 $\color{green}{\blacktriangledown}$ -8.72 31/130
agentlessCodeCoverage 121.93 62.50 $\color{red}{\blacktriangle}$ +59.43 82.69 $\color{red}{\blacktriangle}$ +39.24 31/130
agentlessLineCoverage 154.19 111.62 $\color{red}{\blacktriangle}$ +42.57 125.85 $\color{red}{\blacktriangle}$ +28.34 30/130

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@daniel-mohedano
daniel-mohedano marked this pull request as ready for review August 6, 2026 08:47
@daniel-mohedano
daniel-mohedano requested a review from a team as a code owner August 6, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: ci visibility Continuous Integration Visibility tag: ai generated Largely based on code generated by an AI or LLM type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant