Avoid empty headless test sessions - #12146
Conversation
|
@codex review |
|
/datadog autotest review |
Test Environment - sbt-scalatestJob Status: 🟢 success
Baseline: median of |
Test Environment - netflix-zuulJob Status: 🟢 success
Baseline: median of |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This comment has been minimized.
This comment has been minimized.
Test Environment - nebula-release-pluginJob Status: 🟢 success
Baseline: median of |
Test Environment - reactive-streams-jvmJob Status: 🟢 success
Baseline: median of |
Test Environment - pass4sJob Status: 🟢 success
Baseline: median of |
Test Environment - heliboardJob Status: 🟢 success
Baseline: median of |
Test Environment - sonar-kotlinJob Status: 🟢 success
Baseline: median of |
Test Environment - jolokiaJob Status: 🟢 success
Baseline: median of |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Test Environment - okhttpJob Status: 🟢 success
Baseline: median of |
There was a problem hiding this comment.
More details
The lazy headless lifecycle behaves correctly across empty discovery, policy lookup, skipped tests, and eager child-process initialization. Focused handler tests and the JUnit 5 instrumentation suite produced no duplicate sessions, unexpected spans, or lifecycle failures; production telemetry was unavailable in this public-repository review.
📊 Validated against 5 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit ba6753d · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
Test Environment - spring_bootJob Status: 🟢 success
Baseline: median of |
Test Environment - sonar-javaJob Status: 🟢 success
Baseline: median of |
What Does This Do
Creates test sessions and modules lazily in headless mode. If a test framework discovers no tests and emits no events, no empty session is reported.
Build-system child processes continue to initialize proxy sessions eagerly.
Motivation
When working under headless mode (such as when using
sbt), a project might invoke test discovery for a testing framework that does not actually run any tests. Still, a test session and module would end up being created, and reported as empty with no tests run inside.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]