Migrate Spring Boot RabbitMQ smoke test to JUnit - #12128
Conversation
There was a problem hiding this comment.
The migrated test changes RabbitMQ's known teardown-error allowlist from the actual client text occured to occurred. When either app is stopped, that disconnect log is treated as an unexpected error and the smoke test fails in teardown; restore the original spelling.
🤖 Datadog Autotest · Commit 1201890 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1201890609
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return trace( | ||
| SORT_BY_ANCESTRY, | ||
| sp("spring-rabbit-0", "servlet.request", "GET /roundtrip/{message}").root(), |
There was a problem hiding this comment.
Match received chunks instead of one cross-JVM trace
When a round trip crosses the sender and receiver JVMs, each tracer flushes its own trace chunk to the backend; TestAgentBackend.fetchTraces() only decodes /test/session/traces and does not coalesce chunks sharing a trace ID. Consequently, no received DecodedTrace contains all 12 spans required here, so this assertion times out even when propagation is correct. Match the per-JVM chunks separately and compare their trace/parent IDs, or explicitly merge chunks by trace ID before applying this matcher.
Useful? React with 👍 / 👎.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
9eece4a to
e3bc1dc
Compare
e3bc1dc to
f9175c8
Compare
1201890 to
979b3f4
Compare
This comment has been minimized.
This comment has been minimized.
f9175c8 to
36e7755
Compare
979b3f4 to
353ea51
Compare
What Does This Do
This PR migrates the Spring Boot RabbitMQ smoke tests to the new JUnit smoke test framework.
Motivation
The new tests checks the whole trace structures and span values, in addition to trace payload validity and invariants.
It also check that three round-trips are present (no only one) and the trace is fully-connected.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMLP-1247