Skip to content

Migrate Spring Boot RabbitMQ smoke test to JUnit - #12128

Open
PerfectSlayer wants to merge 1 commit into
bbujon/smoke-tests-opentelemetryfrom
bbujon/smoke-tests-spring-boot-rabbit
Open

Migrate Spring Boot RabbitMQ smoke test to JUnit#12128
PerfectSlayer wants to merge 1 commit into
bbujon/smoke-tests-opentelemetryfrom
bbujon/smoke-tests-spring-boot-rabbit

Conversation

@PerfectSlayer

@PerfectSlayer PerfectSlayer commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

What Does This Do

This PR migrates the Spring Boot RabbitMQ smoke tests to the new JUnit smoke test framework.

Motivation

The new tests checks the whole trace structures and span values, in addition to trace payload validity and invariants.
It also check that three round-trips are present (no only one) and the trace is fully-connected.

Additional Notes

Contributor Checklist

Jira ticket: APMLP-1247

@PerfectSlayer PerfectSlayer added type: feature Enhancements and improvements tag: no release notes Changes to exclude from release notes labels Aug 3, 2026
@PerfectSlayer
PerfectSlayer requested a review from a team as a code owner August 3, 2026 13:52
@PerfectSlayer PerfectSlayer added the inst: rabbitmq RabbitMQ instrumentation label Aug 3, 2026
@PerfectSlayer
PerfectSlayer requested review from vandonr and removed request for a team August 3, 2026 13:52
@PerfectSlayer PerfectSlayer added the inst: spring Spring instrumentation label Aug 3, 2026

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: FAIL

The migrated test changes RabbitMQ's known teardown-error allowlist from the actual client text occured to occurred. When either app is stopped, that disconnect log is treated as an unexpected error and the smoke test fails in teardown; restore the original spelling.

Open Bits AI session

🤖 Datadog Autotest · Commit 1201890 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1201890609

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +138 to +140
return trace(
SORT_BY_ANCESTRY,
sp("spring-rabbit-0", "servlet.request", "GET /roundtrip/{message}").root(),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Match received chunks instead of one cross-JVM trace

When a round trip crosses the sender and receiver JVMs, each tracer flushes its own trace chunk to the backend; TestAgentBackend.fetchTraces() only decodes /test/session/traces and does not coalesce chunks sharing a trace ID. Consequently, no received DecodedTrace contains all 12 spans required here, so this assertion times out even when propagation is correct. Match the per-JVM chunks separately and compare their trace/parent IDs, or explicitly merge chunks by trace ID before applying this matcher.

Useful? React with 👍 / 👎.

@dd-octo-sts

dd-octo-sts Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.75 s 14.67 s [-0.5%; +1.5%] (no difference)
startup:insecure-bank:tracing:Agent 13.61 s 13.70 s [-1.5%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 16.94 s 16.91 s [-0.7%; +1.1%] (no difference)
startup:petclinic:iast:Agent 16.93 s 16.98 s [-1.1%; +0.5%] (no difference)
startup:petclinic:profiling:Agent 16.80 s 16.78 s [-1.0%; +1.3%] (no difference)
startup:petclinic:sca:Agent 16.85 s 16.55 s [+0.8%; +2.8%] (maybe worse)
startup:petclinic:tracing:Agent 15.59 s 16.27 s [-8.1%; -0.3%] (maybe better)

Commit: 353ea514 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-opentelemetry branch from 9eece4a to e3bc1dc Compare August 4, 2026 11:30
@PerfectSlayer
PerfectSlayer requested review from a team as code owners August 4, 2026 11:30
@PerfectSlayer
PerfectSlayer requested review from mcculls and removed request for a team August 4, 2026 11:30
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-opentelemetry branch from e3bc1dc to f9175c8 Compare August 4, 2026 11:32
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-spring-boot-rabbit branch from 1201890 to 979b3f4 Compare August 5, 2026 05:28
@datadog-datadog-us1-prod

This comment has been minimized.

@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-opentelemetry branch from f9175c8 to 36e7755 Compare August 5, 2026 15:48
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-spring-boot-rabbit branch from 979b3f4 to 353ea51 Compare August 5, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: rabbitmq RabbitMQ instrumentation inst: spring Spring instrumentation tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant