Preserve Feature Flagging configuration source semantics#11992
Draft
leoromanovsky wants to merge 6 commits into
Draft
Conversation
Contributor
|
🎯 Code Coverage (details) 🔗 Commit SHA: c5bae85 | Docs | Datadog PR Page | Give us feedback! |
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Complete the Feature Flags configuration migration on top of sealed #11892 without creating phantom billed traffic. New customers default to CDN-backed delivery only after application provider access, while existing users of the legacy experimental enablement variable remain on Remote Configuration during the migration window.
flowchart TD Start["Agent starts"] --> Enabled{"DD_FEATURE_FLAGS_ENABLED"} Enabled -->|"false"| Disabled["Provider disabled<br/>No RC or CDN traffic"] Enabled -->|"true or unset"| Resolve{"Resolve source and legacy state"} Resolve -->|"explicit or grandfathered RC"| RC["Subscribe to FFE_FLAGS"] Resolve -->|"agentless or new default"| Wait["Wait for application provider access"] Resolve -->|"legacy false, invalid, or offline"| Disabled Wait --> Access["Application initializes or accesses provider"] Access --> CDN["Poll CDN-backed API"]Changes
DD_FEATURE_FLAGS_ENABLEDas the canonical provider and delivery kill switch.trueas Remote Configuration and legacyfalseas disabled when no new source is explicit.FFE_FLAGSsubscription is preserved.Decisions
DD_FEATURE_FLAGS_ENABLED=falsewins over every source and prevents both CDN polling and theFFE_FLAGSsubscription.DD_FEATURE_FLAGS_CONFIGURATION_SOURCEwins over the legacy setting.trueselects Remote Configuration, legacyfalsedisables Feature Flags, and an absent legacy variable selects agentless.offlinesources fail closed.Validation
./gradlew spotlessCheck: passed.:dd-java-agent:agent-bootstrap:spotbugsMain: passed.:dd-java-agent:verifyAgentJarContents: passed.system-testsJava source-selection matrix plus generic/ffe/start: 11 passing.DD_FEATURE_FLAGS_ENABLED=falsekept both startup and provider access silent.