Open
Conversation
sarahchen6
commented
Mar 13, 2026
| "scenario | stringId | expectedId ", | ||
| "zero | '0' | 0 ", | ||
| "one | '1' | 1 ", | ||
| "max | '18446744073709551615' | -1 ", |
Contributor
Author
There was a problem hiding this comment.
DDSpanId.MAX is not parse-able by TableTest, but it's defined as -1 in DDSpanId
sarahchen6
commented
Mar 13, 2026
| "zero | '0' | 0 ", | ||
| "one | '1' | 1 ", | ||
| "max | '18446744073709551615' | -1 ", | ||
| "long max | '9223372036854775807' | 9223372036854775807 ", |
Contributor
Author
There was a problem hiding this comment.
Long.MAX_VALUE and similar are not parse-able by TableTest, so the integer is used instead. This hurts readability... but worth?
sarahchen6
added
comp: testing
AlexeyKuznetsov-DD
approved these changes
Mar 13, 2026
Contributor
AlexeyKuznetsov-DD
left a comment
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
LGTM, left minor style comments.
dd-trace-api/build.gradle.kts
Outdated
| api(libs.slf4j) | ||
| testImplementation(libs.guava) | ||
| testImplementation(libs.bundles.mockito) | ||
| testImplementation(libs.tabletest) |
Contributor
There was a problem hiding this comment.
Let's add it to libs.bundle.junit5 ? as @PerfectSlayer suggested, to minimize changes, as we have Spock Data Tables everywhere.
Contributor
Author
There was a problem hiding this comment.
I added it in java_deps.gradle in 2f706c9 which should make TableTest available for all Java tests. WDYT?
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~2f706c9be4, baseline=1.61.0-SNAPSHOT~76fb55f7da
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057261
Total [baseline] (11.043 s) : 0, 11043261
Agent [candidate] (1.059 s) : 0, 1059147
Total [candidate] (11.067 s) : 0, 11067337
section appsec
Agent [baseline] (1.247 s) : 0, 1247335
Total [baseline] (11.16 s) : 0, 11159890
Agent [candidate] (1.25 s) : 0, 1250078
Total [candidate] (11.202 s) : 0, 11201921
section iast
Agent [baseline] (1.224 s) : 0, 1223988
Total [baseline] (11.336 s) : 0, 11336206
Agent [candidate] (1.226 s) : 0, 1225745
Total [candidate] (11.389 s) : 0, 11389045
section profiling
Agent [baseline] (1.18 s) : 0, 1179521
Total [baseline] (10.932 s) : 0, 10931754
Agent [candidate] (1.186 s) : 0, 1186369
Total [candidate] (11.022 s) : 0, 11021506
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~2f706c9be4, baseline=1.61.0-SNAPSHOT~76fb55f7da
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (627.018 ms) : 0, 627018
BytebuddyAgent [candidate] (629.728 ms) : 0, 629728
AgentMeter [baseline] (29.013 ms) : 0, 29013
AgentMeter [candidate] (29.227 ms) : 0, 29227
GlobalTracer [baseline] (256.39 ms) : 0, 256390
GlobalTracer [candidate] (256.931 ms) : 0, 256931
AppSec [baseline] (31.41 ms) : 0, 31410
AppSec [candidate] (31.51 ms) : 0, 31510
Debugger [baseline] (59.063 ms) : 0, 59063
Debugger [candidate] (59.611 ms) : 0, 59611
Remote Config [baseline] (613.425 µs) : 0, 613
Remote Config [candidate] (609.938 µs) : 0, 610
Telemetry [baseline] (8.626 ms) : 0, 8626
Telemetry [candidate] (8.621 ms) : 0, 8621
Flare Poller [baseline] (7.994 ms) : 0, 7994
Flare Poller [candidate] (5.801 ms) : 0, 5801
section appsec
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (657.871 ms) : 0, 657871
BytebuddyAgent [candidate] (660.639 ms) : 0, 660639
AgentMeter [baseline] (12.041 ms) : 0, 12041
AgentMeter [candidate] (12.104 ms) : 0, 12104
GlobalTracer [baseline] (258.843 ms) : 0, 258843
GlobalTracer [candidate] (258.614 ms) : 0, 258614
AppSec [baseline] (177.763 ms) : 0, 177763
AppSec [candidate] (177.731 ms) : 0, 177731
Debugger [baseline] (65.966 ms) : 0, 65966
Debugger [candidate] (66.022 ms) : 0, 66022
Remote Config [baseline] (576.54 µs) : 0, 577
Remote Config [candidate] (573.902 µs) : 0, 574
Telemetry [baseline] (9.089 ms) : 0, 9089
Telemetry [candidate] (9.066 ms) : 0, 9066
Flare Poller [baseline] (3.638 ms) : 0, 3638
Flare Poller [candidate] (3.682 ms) : 0, 3682
IAST [baseline] (24.118 ms) : 0, 24118
IAST [candidate] (24.074 ms) : 0, 24074
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (793.822 ms) : 0, 793822
BytebuddyAgent [candidate] (793.199 ms) : 0, 793199
AgentMeter [baseline] (11.339 ms) : 0, 11339
AgentMeter [candidate] (11.308 ms) : 0, 11308
GlobalTracer [baseline] (246.588 ms) : 0, 246588
GlobalTracer [candidate] (248.143 ms) : 0, 248143
AppSec [baseline] (26.341 ms) : 0, 26341
AppSec [candidate] (26.738 ms) : 0, 26738
Debugger [baseline] (63.39 ms) : 0, 63390
Debugger [candidate] (64.944 ms) : 0, 64944
Remote Config [baseline] (511.999 µs) : 0, 512
Remote Config [candidate] (516.646 µs) : 0, 517
Telemetry [baseline] (14.806 ms) : 0, 14806
Telemetry [candidate] (13.849 ms) : 0, 13849
Flare Poller [baseline] (4.901 ms) : 0, 4901
Flare Poller [candidate] (4.568 ms) : 0, 4568
IAST [baseline] (25.112 ms) : 0, 25112
IAST [candidate] (25.348 ms) : 0, 25348
section profiling
ProfilingAgent [baseline] (93.865 ms) : 0, 93865
ProfilingAgent [candidate] (94.075 ms) : 0, 94075
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.172 ms) : 0, 1172
BytebuddyAgent [baseline] (680.991 ms) : 0, 680991
BytebuddyAgent [candidate] (685.092 ms) : 0, 685092
AgentMeter [baseline] (8.639 ms) : 0, 8639
AgentMeter [candidate] (8.664 ms) : 0, 8664
GlobalTracer [baseline] (215.029 ms) : 0, 215029
GlobalTracer [candidate] (216.303 ms) : 0, 216303
AppSec [baseline] (31.863 ms) : 0, 31863
AppSec [candidate] (32.248 ms) : 0, 32248
Debugger [baseline] (64.376 ms) : 0, 64376
Debugger [candidate] (64.824 ms) : 0, 64824
Remote Config [baseline] (575.66 µs) : 0, 576
Remote Config [candidate] (583.376 µs) : 0, 583
Telemetry [baseline] (8.889 ms) : 0, 8889
Telemetry [candidate] (9.006 ms) : 0, 9006
Flare Poller [baseline] (3.498 ms) : 0, 3498
Flare Poller [candidate] (3.518 ms) : 0, 3518
Profiling [baseline] (94.428 ms) : 0, 94428
Profiling [candidate] (94.639 ms) : 0, 94639
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~2f706c9be4, baseline=1.61.0-SNAPSHOT~76fb55f7da
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061008
Total [baseline] (8.83 s) : 0, 8829649
Agent [candidate] (1.056 s) : 0, 1055668
Total [candidate] (8.796 s) : 0, 8796323
section iast
Agent [baseline] (1.224 s) : 0, 1223832
Total [baseline] (9.517 s) : 0, 9517268
Agent [candidate] (1.224 s) : 0, 1224205
Total [candidate] (9.566 s) : 0, 9565546
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~2f706c9be4, baseline=1.61.0-SNAPSHOT~76fb55f7da
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (629.995 ms) : 0, 629995
BytebuddyAgent [candidate] (626.67 ms) : 0, 626670
AgentMeter [baseline] (29.158 ms) : 0, 29158
AgentMeter [candidate] (29.145 ms) : 0, 29145
GlobalTracer [baseline] (256.953 ms) : 0, 256953
GlobalTracer [candidate] (256.436 ms) : 0, 256436
AppSec [baseline] (31.749 ms) : 0, 31749
AppSec [candidate] (31.403 ms) : 0, 31403
Debugger [baseline] (58.835 ms) : 0, 58835
Debugger [candidate] (58.404 ms) : 0, 58404
Remote Config [baseline] (615.864 µs) : 0, 616
Remote Config [candidate] (610.14 µs) : 0, 610
Telemetry [baseline] (8.621 ms) : 0, 8621
Telemetry [candidate] (8.686 ms) : 0, 8686
Flare Poller [baseline] (7.893 ms) : 0, 7893
Flare Poller [candidate] (7.15 ms) : 0, 7150
section iast
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (794.659 ms) : 0, 794659
BytebuddyAgent [candidate] (794.256 ms) : 0, 794256
AgentMeter [baseline] (11.301 ms) : 0, 11301
AgentMeter [candidate] (11.286 ms) : 0, 11286
GlobalTracer [baseline] (246.516 ms) : 0, 246516
GlobalTracer [candidate] (246.906 ms) : 0, 246906
IAST [baseline] (25.137 ms) : 0, 25137
IAST [candidate] (25.103 ms) : 0, 25103
AppSec [baseline] (26.417 ms) : 0, 26417
AppSec [candidate] (26.292 ms) : 0, 26292
Debugger [baseline] (62.465 ms) : 0, 62465
Debugger [candidate] (62.875 ms) : 0, 62875
Remote Config [baseline] (514.527 µs) : 0, 515
Remote Config [candidate] (521.761 µs) : 0, 522
Telemetry [baseline] (14.728 ms) : 0, 14728
Telemetry [candidate] (14.901 ms) : 0, 14901
Flare Poller [baseline] (4.858 ms) : 0, 4858
Flare Poller [candidate] (4.887 ms) : 0, 4887
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~2f706c9be4, baseline=1.61.0-SNAPSHOT~76fb55f7da
dateFormat X
axisFormat %s
section baseline
no_agent (1.182 ms) : 1170, 1194
. : milestone, 1182,
iast (3.195 ms) : 3150, 3240
. : milestone, 3195,
iast_FULL (5.963 ms) : 5903, 6024
. : milestone, 5963,
iast_GLOBAL (3.395 ms) : 3347, 3442
. : milestone, 3395,
profiling (2.046 ms) : 2027, 2064
. : milestone, 2046,
tracing (1.838 ms) : 1823, 1854
. : milestone, 1838,
section candidate
no_agent (1.172 ms) : 1160, 1183
. : milestone, 1172,
iast (3.172 ms) : 3128, 3215
. : milestone, 3172,
iast_FULL (5.695 ms) : 5639, 5751
. : milestone, 5695,
iast_GLOBAL (3.565 ms) : 3509, 3621
. : milestone, 3565,
profiling (1.993 ms) : 1976, 2011
. : milestone, 1993,
tracing (1.762 ms) : 1748, 1777
. : milestone, 1762,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~2f706c9be4, baseline=1.61.0-SNAPSHOT~76fb55f7da
dateFormat X
axisFormat %s
section baseline
no_agent (19.152 ms) : 18957, 19346
. : milestone, 19152,
appsec (18.743 ms) : 18549, 18937
. : milestone, 18743,
code_origins (17.578 ms) : 17405, 17751
. : milestone, 17578,
iast (18.181 ms) : 18000, 18362
. : milestone, 18181,
profiling (19.651 ms) : 19453, 19848
. : milestone, 19651,
tracing (17.607 ms) : 17435, 17780
. : milestone, 17607,
section candidate
no_agent (19.273 ms) : 19077, 19469
. : milestone, 19273,
appsec (19.166 ms) : 18970, 19362
. : milestone, 19166,
code_origins (18.499 ms) : 18311, 18686
. : milestone, 18499,
iast (17.618 ms) : 17442, 17794
. : milestone, 17618,
profiling (18.544 ms) : 18359, 18730
. : milestone, 18544,
tracing (17.672 ms) : 17492, 17853
. : milestone, 17672,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~2f706c9be4, baseline=1.61.0-SNAPSHOT~76fb55f7da
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1483
. : milestone, 1472,
appsec (3.709 ms) : 3493, 3925
. : milestone, 3709,
iast (2.249 ms) : 2180, 2318
. : milestone, 2249,
iast_GLOBAL (2.297 ms) : 2228, 2366
. : milestone, 2297,
profiling (2.096 ms) : 2039, 2152
. : milestone, 2096,
tracing (2.057 ms) : 2004, 2111
. : milestone, 2057,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.789 ms) : 3568, 4011
. : milestone, 3789,
iast (2.259 ms) : 2190, 2327
. : milestone, 2259,
iast_GLOBAL (2.299 ms) : 2229, 2368
. : milestone, 2299,
profiling (2.078 ms) : 2023, 2133
. : milestone, 2078,
tracing (2.071 ms) : 2017, 2124
. : milestone, 2071,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~2f706c9be4, baseline=1.61.0-SNAPSHOT~76fb55f7da
dateFormat X
axisFormat %s
section baseline
no_agent (14.981 s) : 14981000, 14981000
. : milestone, 14981000,
appsec (15.033 s) : 15033000, 15033000
. : milestone, 15033000,
iast (17.88 s) : 17880000, 17880000
. : milestone, 17880000,
iast_GLOBAL (17.653 s) : 17653000, 17653000
. : milestone, 17653000,
profiling (15.535 s) : 15535000, 15535000
. : milestone, 15535000,
tracing (15.393 s) : 15393000, 15393000
. : milestone, 15393000,
section candidate
no_agent (14.977 s) : 14977000, 14977000
. : milestone, 14977000,
appsec (15.148 s) : 15148000, 15148000
. : milestone, 15148000,
iast (18.239 s) : 18239000, 18239000
. : milestone, 18239000,
iast_GLOBAL (17.635 s) : 17635000, 17635000
. : milestone, 17635000,
profiling (14.906 s) : 14906000, 14906000
. : milestone, 14906000,
tracing (15.403 s) : 15403000, 15403000
. : milestone, 15403000,
|
| dependencies { | ||
| testImplementation libs.bundles.spock | ||
| testImplementation libs.bundles.groovy | ||
| testImplementation libs.tabletest |
Contributor
There was a problem hiding this comment.
Nice, think we can remove it from components/json since we have it in java_deps.gradle now.
Comment on lines
14
to
+16
| Dependency: | ||
| - If missing, add: | ||
| - Groovy: testImplementation libs.tabletest | ||
| - Kotlin: testImplementation(libs.tabletest) | ||
| - @TableTest should be in `gradle/java_deps.gradle` as `testImplementation libs.tabletest` where Java modules inherit it via `gradle/java.gradle`. | ||
| - As a fallback, add module-specific `testImplementation(libs.tabletest)` or `testImplementation libs.tabletest`. |
Contributor
There was a problem hiding this comment.
I think we can delete whole Dependency block (here and in migrate-spock skill too), as it will be available by default, no need to specify at all.
Contributor
|
I noticed that some tables here and there missing couple of spaces, just review one more time and align as needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Reconfigure
dd-trace-apiJava tests to use TableTest dependencyMotivation
TableTest improves test readability significantly
Additional Notes
The migration was done using Codex and the
migrate-junit-source-to-tabletestskill. I reviewed the PR after. We can see the tests run here in the TestOpt dashboard.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.