Add Java 26 support to CI Visibility#10839
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~adb3df5bd2, baseline=1.61.0-SNAPSHOT~7cff99444b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062507
Total [baseline] (11.005 s) : 0, 11005123
Agent [candidate] (1.069 s) : 0, 1068662
Total [candidate] (11.089 s) : 0, 11089402
section appsec
Agent [baseline] (1.244 s) : 0, 1243739
Total [baseline] (11.192 s) : 0, 11191538
Agent [candidate] (1.256 s) : 0, 1255730
Total [candidate] (11.177 s) : 0, 11177402
section iast
Agent [baseline] (1.226 s) : 0, 1225858
Total [baseline] (11.279 s) : 0, 11279471
Agent [candidate] (1.234 s) : 0, 1234066
Total [candidate] (11.318 s) : 0, 11317594
section profiling
Agent [baseline] (1.19 s) : 0, 1189579
Total [baseline] (11.065 s) : 0, 11064600
Agent [candidate] (1.178 s) : 0, 1177602
Total [candidate] (10.991 s) : 0, 10991205
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~adb3df5bd2, baseline=1.61.0-SNAPSHOT~7cff99444b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (628.963 ms) : 0, 628963
BytebuddyAgent [candidate] (633.689 ms) : 0, 633689
AgentMeter [baseline] (29.158 ms) : 0, 29158
AgentMeter [candidate] (29.298 ms) : 0, 29298
GlobalTracer [baseline] (257.429 ms) : 0, 257429
GlobalTracer [candidate] (258.751 ms) : 0, 258751
AppSec [baseline] (31.552 ms) : 0, 31552
AppSec [candidate] (31.659 ms) : 0, 31659
Debugger [baseline] (59.375 ms) : 0, 59375
Debugger [candidate] (59.87 ms) : 0, 59870
Remote Config [baseline] (614.961 µs) : 0, 615
Remote Config [candidate] (610.424 µs) : 0, 610
Telemetry [baseline] (8.715 ms) : 0, 8715
Telemetry [candidate] (8.708 ms) : 0, 8708
Flare Poller [baseline] (9.426 ms) : 0, 9426
Flare Poller [candidate] (8.763 ms) : 0, 8763
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (656.84 ms) : 0, 656840
BytebuddyAgent [candidate] (663.848 ms) : 0, 663848
AgentMeter [baseline] (12.043 ms) : 0, 12043
AgentMeter [candidate] (12.153 ms) : 0, 12153
GlobalTracer [baseline] (257.274 ms) : 0, 257274
GlobalTracer [candidate] (260.341 ms) : 0, 260341
IAST [baseline] (23.885 ms) : 0, 23885
IAST [candidate] (24.214 ms) : 0, 24214
AppSec [baseline] (177.345 ms) : 0, 177345
AppSec [candidate] (178.272 ms) : 0, 178272
Debugger [baseline] (65.683 ms) : 0, 65683
Debugger [candidate] (65.96 ms) : 0, 65960
Remote Config [baseline] (579.309 µs) : 0, 579
Remote Config [candidate] (573.178 µs) : 0, 573
Telemetry [baseline] (9.035 ms) : 0, 9035
Telemetry [candidate] (9.064 ms) : 0, 9064
Flare Poller [baseline] (3.675 ms) : 0, 3675
Flare Poller [candidate] (3.644 ms) : 0, 3644
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (795.202 ms) : 0, 795202
BytebuddyAgent [candidate] (801.229 ms) : 0, 801229
AgentMeter [baseline] (11.354 ms) : 0, 11354
AgentMeter [candidate] (11.556 ms) : 0, 11556
GlobalTracer [baseline] (247.365 ms) : 0, 247365
GlobalTracer [candidate] (247.983 ms) : 0, 247983
IAST [baseline] (25.081 ms) : 0, 25081
IAST [candidate] (25.21 ms) : 0, 25210
AppSec [baseline] (26.448 ms) : 0, 26448
AppSec [candidate] (26.579 ms) : 0, 26579
Debugger [baseline] (64.412 ms) : 0, 64412
Debugger [candidate] (66.567 ms) : 0, 66567
Remote Config [baseline] (529.621 µs) : 0, 530
Remote Config [candidate] (537.133 µs) : 0, 537
Telemetry [baseline] (13.722 ms) : 0, 13722
Telemetry [candidate] (12.843 ms) : 0, 12843
Flare Poller [baseline] (4.563 ms) : 0, 4563
Flare Poller [candidate] (4.336 ms) : 0, 4336
section profiling
crashtracking [baseline] (1.174 ms) : 0, 1174
crashtracking [candidate] (1.171 ms) : 0, 1171
BytebuddyAgent [baseline] (686.689 ms) : 0, 686689
BytebuddyAgent [candidate] (680.22 ms) : 0, 680220
AgentMeter [baseline] (8.652 ms) : 0, 8652
AgentMeter [candidate] (8.608 ms) : 0, 8608
GlobalTracer [baseline] (217.087 ms) : 0, 217087
GlobalTracer [candidate] (214.96 ms) : 0, 214960
AppSec [baseline] (32.062 ms) : 0, 32062
AppSec [candidate] (31.732 ms) : 0, 31732
Debugger [baseline] (61.878 ms) : 0, 61878
Debugger [candidate] (61.752 ms) : 0, 61752
Remote Config [baseline] (576.535 µs) : 0, 577
Remote Config [candidate] (596.757 µs) : 0, 597
Telemetry [baseline] (11.418 ms) : 0, 11418
Telemetry [candidate] (10.435 ms) : 0, 10435
Flare Poller [baseline] (4.422 ms) : 0, 4422
Flare Poller [candidate] (4.231 ms) : 0, 4231
ProfilingAgent [baseline] (94.627 ms) : 0, 94627
ProfilingAgent [candidate] (93.385 ms) : 0, 93385
Profiling [baseline] (95.191 ms) : 0, 95191
Profiling [candidate] (93.94 ms) : 0, 93940
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~adb3df5bd2, baseline=1.61.0-SNAPSHOT~7cff99444b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058725
Total [baseline] (8.812 s) : 0, 8812379
Agent [candidate] (1.065 s) : 0, 1065046
Total [candidate] (8.853 s) : 0, 8853075
section iast
Agent [baseline] (1.228 s) : 0, 1227991
Total [baseline] (9.54 s) : 0, 9539690
Agent [candidate] (1.228 s) : 0, 1228130
Total [candidate] (9.56 s) : 0, 9560200
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~adb3df5bd2, baseline=1.61.0-SNAPSHOT~7cff99444b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (628.416 ms) : 0, 628416
BytebuddyAgent [candidate] (632.688 ms) : 0, 632688
AgentMeter [baseline] (29.121 ms) : 0, 29121
AgentMeter [candidate] (29.277 ms) : 0, 29277
GlobalTracer [baseline] (257.0 ms) : 0, 257000
GlobalTracer [candidate] (259.118 ms) : 0, 259118
AppSec [baseline] (31.573 ms) : 0, 31573
AppSec [candidate] (31.749 ms) : 0, 31749
Debugger [baseline] (58.697 ms) : 0, 58697
Debugger [candidate] (59.03 ms) : 0, 59030
Remote Config [baseline] (617.577 µs) : 0, 618
Remote Config [candidate] (618.909 µs) : 0, 619
Telemetry [baseline] (8.74 ms) : 0, 8740
Telemetry [candidate] (8.712 ms) : 0, 8712
Flare Poller [baseline] (7.273 ms) : 0, 7273
Flare Poller [candidate] (6.455 ms) : 0, 6455
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (797.108 ms) : 0, 797108
BytebuddyAgent [candidate] (797.084 ms) : 0, 797084
AgentMeter [baseline] (11.337 ms) : 0, 11337
AgentMeter [candidate] (11.31 ms) : 0, 11310
GlobalTracer [baseline] (247.424 ms) : 0, 247424
GlobalTracer [candidate] (248.029 ms) : 0, 248029
IAST [baseline] (25.181 ms) : 0, 25181
IAST [candidate] (25.181 ms) : 0, 25181
AppSec [baseline] (26.355 ms) : 0, 26355
AppSec [candidate] (26.443 ms) : 0, 26443
Debugger [baseline] (63.008 ms) : 0, 63008
Debugger [candidate] (62.648 ms) : 0, 62648
Remote Config [baseline] (523.826 µs) : 0, 524
Remote Config [candidate] (514.941 µs) : 0, 515
Telemetry [baseline] (14.837 ms) : 0, 14837
Telemetry [candidate] (14.84 ms) : 0, 14840
Flare Poller [baseline] (4.877 ms) : 0, 4877
Flare Poller [candidate] (4.86 ms) : 0, 4860
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~adb3df5bd2, baseline=1.61.0-SNAPSHOT~7cff99444b
dateFormat X
axisFormat %s
section baseline
no_agent (1.193 ms) : 1180, 1205
. : milestone, 1193,
iast (3.225 ms) : 3181, 3268
. : milestone, 3225,
iast_FULL (6.007 ms) : 5946, 6067
. : milestone, 6007,
iast_GLOBAL (3.538 ms) : 3480, 3596
. : milestone, 3538,
profiling (2.12 ms) : 2100, 2141
. : milestone, 2120,
tracing (1.759 ms) : 1745, 1774
. : milestone, 1759,
section candidate
no_agent (1.183 ms) : 1171, 1194
. : milestone, 1183,
iast (3.086 ms) : 3044, 3127
. : milestone, 3086,
iast_FULL (5.82 ms) : 5763, 5878
. : milestone, 5820,
iast_GLOBAL (3.516 ms) : 3470, 3562
. : milestone, 3516,
profiling (2.083 ms) : 2063, 2102
. : milestone, 2083,
tracing (1.768 ms) : 1754, 1783
. : milestone, 1768,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~adb3df5bd2, baseline=1.61.0-SNAPSHOT~7cff99444b
dateFormat X
axisFormat %s
section baseline
no_agent (17.434 ms) : 17257, 17610
. : milestone, 17434,
appsec (18.63 ms) : 18445, 18814
. : milestone, 18630,
code_origins (18.607 ms) : 18417, 18796
. : milestone, 18607,
iast (17.84 ms) : 17662, 18018
. : milestone, 17840,
profiling (18.886 ms) : 18701, 19071
. : milestone, 18886,
tracing (18.555 ms) : 18368, 18742
. : milestone, 18555,
section candidate
no_agent (17.861 ms) : 17680, 18041
. : milestone, 17861,
appsec (18.627 ms) : 18437, 18816
. : milestone, 18627,
code_origins (17.877 ms) : 17698, 18055
. : milestone, 17877,
iast (18.819 ms) : 18629, 19009
. : milestone, 18819,
profiling (18.774 ms) : 18581, 18967
. : milestone, 18774,
tracing (17.744 ms) : 17569, 17920
. : milestone, 17744,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~adb3df5bd2, baseline=1.61.0-SNAPSHOT~7cff99444b
dateFormat X
axisFormat %s
section baseline
no_agent (14.975 s) : 14975000, 14975000
. : milestone, 14975000,
appsec (15.23 s) : 15230000, 15230000
. : milestone, 15230000,
iast (17.975 s) : 17975000, 17975000
. : milestone, 17975000,
iast_GLOBAL (17.808 s) : 17808000, 17808000
. : milestone, 17808000,
profiling (15.585 s) : 15585000, 15585000
. : milestone, 15585000,
tracing (15.042 s) : 15042000, 15042000
. : milestone, 15042000,
section candidate
no_agent (14.953 s) : 14953000, 14953000
. : milestone, 14953000,
appsec (15.205 s) : 15205000, 15205000
. : milestone, 15205000,
iast (18.448 s) : 18448000, 18448000
. : milestone, 18448000,
iast_GLOBAL (17.688 s) : 17688000, 17688000
. : milestone, 17688000,
profiling (14.838 s) : 14838000, 14838000
. : milestone, 14838000,
tracing (15.171 s) : 15171000, 15171000
. : milestone, 15171000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~adb3df5bd2, baseline=1.61.0-SNAPSHOT~7cff99444b
dateFormat X
axisFormat %s
section baseline
no_agent (1.466 ms) : 1454, 1477
. : milestone, 1466,
appsec (3.712 ms) : 3499, 3926
. : milestone, 3712,
iast (2.246 ms) : 2177, 2315
. : milestone, 2246,
iast_GLOBAL (2.281 ms) : 2212, 2350
. : milestone, 2281,
profiling (2.066 ms) : 2012, 2120
. : milestone, 2066,
tracing (2.047 ms) : 1994, 2100
. : milestone, 2047,
section candidate
no_agent (1.469 ms) : 1457, 1481
. : milestone, 1469,
appsec (3.787 ms) : 3569, 4006
. : milestone, 3787,
iast (2.241 ms) : 2172, 2310
. : milestone, 2241,
iast_GLOBAL (2.287 ms) : 2218, 2357
. : milestone, 2287,
profiling (2.48 ms) : 2318, 2642
. : milestone, 2480,
tracing (2.044 ms) : 1991, 2097
. : milestone, 2044,
|
Test Environment - pass4sJob Status: success
|
Test Environment - sbt-scalatestJob Status: success
|
Test Environment - netflix-zuulJob Status: success
|
Test Environment - reactive-streams-jvmJob Status: success
|
Test Environment - sonar-kotlinJob Status: success
|
Test Environment - nebula-release-pluginJob Status: success
|
Test Environment - jolokiaJob Status: success
|
Test Environment - okhttpJob Status: success
|
| if (loader != null | ||
| && className != null | ||
| && className.startsWith(COMPILER_PLUGIN_CLASS_PREFIX) | ||
| && exportedClassLoaders.add(loader)) { |
There was a problem hiding this comment.
We could probably use something like exportedClassLoaders.computeIfAbsent(loader, this::exportJdkCompilerModule) to make sure this is truly thread safe (otherwise a thread that lost the race on add just exits, without waiting for the module to be exported in the other thread
There was a problem hiding this comment.
Makes sense! Updated the approach in adb3df5
| extraExports.put(packageName, target); | ||
| } | ||
|
|
||
| inst.redefineModule(module, emptySet(), (Map) extraExports, emptyMap(), emptySet(), emptyMap()); |
There was a problem hiding this comment.
Why the (Map) cast?
There was a problem hiding this comment.
Good catch, missed it during cleanup, addressed in adb3df5
| if (!optModule.isPresent()) { | ||
| return; | ||
| } | ||
| java.lang.Module module = optModule.get(); |
There was a problem hiding this comment.
Can java.lang.Module be imported so that we don't have to specify its full name every time?
There was a problem hiding this comment.
I followed the approach that was already in use in the file out of caution, although adding the imports doesn't seem to cause any failures/side effects. @mcculls might have better context here as he did the original implementation for the class
Test Environment - spring_bootJob Status: success
|
Test Environment - sonar-javaJob Status: success
|
What Does This Do
jdk.compilermodule to unnamed modules (where the code of the plugin lives). The method used,StaticComponentContainer.Modules.exportToAllUnnamed, now fails in Java 26, causing compilation failures or wrong source information on span comparison because the compiler plugin is auto-injected when CI Visibility is enabled.Additional Notes
false.RepoIndexapproach.IllegalAccessError.Smoke tests now running in the
tipjob:test-environment-trigger: skip
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.