Skip to content

Refactor PortUtils.isPortOpen() to have predictable timeout. #10832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexeyKuznetsov-DD wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor PortUtils.isPortOpen() to have predictable timeout. #10832

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f06379
Make `isPortOpen()` to have predictable timeout.
AlexeyKuznetsov-DD Mar 6, 2026
45edb56
Merge branch 'master' into alexeyk/fix-port-utils
AlexeyKuznetsov-DD Mar 12, 2026
4890097
Merge branch 'master' into alexeyk/fix-port-utils
AlexeyKuznetsov-DD Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion dd-java-agent/testing/src/main/groovy/datadog/trace/agent/test/utils/PortUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package datadog.trace.agent.test.utils;

import java.io.IOException;
import java.net.InetAddress;
import java.net.InetSocketAddress;
import java.net.ServerSocket;
import java.net.Socket;
import java.util.concurrent.TimeUnit;
Expand All @@ -9,6 +11,7 @@
public class PortUtils {

public static int UNUSABLE_PORT = 61;
private static final int PORT_CONNECT_TIMEOUT_MS = 1000;

private static final int FREE_PORT_RANGE_START = 20000;
private static final int FREE_PORT_RANGE_END = 40000;
Expand Down Expand Up @@ -96,7 +99,12 @@ private static boolean isPortOpen(final int port) {
}

private static boolean isPortOpen(String host, int port) {
try (final Socket socket = new Socket(host, port)) {
try (final Socket socket = new Socket()) {
InetSocketAddress address =
host == null
? new InetSocketAddress(InetAddress.getLoopbackAddress(), port)
: new InetSocketAddress(host, port);
socket.connect(address, PORT_CONNECT_TIMEOUT_MS);
return true;
} catch (final IOException e) {
return false;
Expand Down
Loading