Skip to content

Using forEach to avoid Iterator allocation #10830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dougqh wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −3
Open

Using forEach to avoid Iterator allocation #10830

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df58a70
Using forEach to avoid Iterator allocation
dougqh Mar 12, 2026
5a3f018
spotless
dougqh Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1230,9 +1230,10 @@ void write(final List<DDSpan> trace) {

// run early tag postprocessors before publishing to the metrics writer since peer / base
// service are needed
for (DDSpan span : writtenTrace) {
span.processServiceTags();
}

// DQH - Using forEach avoids ArrayList$Iter allocation
writtenTrace.forEach(DDSpan::processServiceTags);

boolean forceKeep = metricsAggregator.publish(writtenTrace);

TraceCollector traceCollector = writtenTrace.get(0).context().getTraceCollector();
Expand Down
Loading