In telemetry, replace Objects.hash with HashingUtils.hash#10813
Open
In telemetry, replace Objects.hash with HashingUtils.hash#10813
Conversation
Co-authored-by: dougqh <dougqh@gmail.com>
Contributor
|
I can only run on private repositories. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~817c05c18f, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065230
Total [baseline] (8.866 s) : 0, 8866167
Agent [candidate] (1.072 s) : 0, 1071515
Total [candidate] (8.853 s) : 0, 8853352
section iast
Agent [baseline] (1.237 s) : 0, 1237137
Total [baseline] (9.569 s) : 0, 9568834
Agent [candidate] (1.234 s) : 0, 1233547
Total [candidate] (9.555 s) : 0, 9555266
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~817c05c18f, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (633.768 ms) : 0, 633768
BytebuddyAgent [candidate] (635.998 ms) : 0, 635998
AgentMeter [baseline] (29.322 ms) : 0, 29322
AgentMeter [candidate] (29.373 ms) : 0, 29373
GlobalTracer [baseline] (258.539 ms) : 0, 258539
GlobalTracer [candidate] (259.365 ms) : 0, 259365
AppSec [baseline] (31.803 ms) : 0, 31803
AppSec [candidate] (31.931 ms) : 0, 31931
Debugger [baseline] (59.12 ms) : 0, 59120
Debugger [candidate] (59.186 ms) : 0, 59186
Remote Config [baseline] (632.464 µs) : 0, 632
Remote Config [candidate] (629.997 µs) : 0, 630
Telemetry [baseline] (8.746 ms) : 0, 8746
Telemetry [candidate] (8.763 ms) : 0, 8763
Flare Poller [baseline] (5.756 ms) : 0, 5756
Flare Poller [candidate] (8.734 ms) : 0, 8734
section iast
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (803.391 ms) : 0, 803391
BytebuddyAgent [candidate] (801.865 ms) : 0, 801865
AgentMeter [baseline] (11.56 ms) : 0, 11560
AgentMeter [candidate] (11.558 ms) : 0, 11558
GlobalTracer [baseline] (249.156 ms) : 0, 249156
GlobalTracer [candidate] (248.231 ms) : 0, 248231
AppSec [baseline] (26.676 ms) : 0, 26676
AppSec [candidate] (26.499 ms) : 0, 26499
Debugger [baseline] (62.882 ms) : 0, 62882
Debugger [candidate] (62.481 ms) : 0, 62481
Remote Config [baseline] (524.302 µs) : 0, 524
Remote Config [candidate] (508.727 µs) : 0, 509
Telemetry [baseline] (15.113 ms) : 0, 15113
Telemetry [candidate] (14.745 ms) : 0, 14745
Flare Poller [baseline] (4.896 ms) : 0, 4896
Flare Poller [candidate] (4.889 ms) : 0, 4889
IAST [baseline] (25.42 ms) : 0, 25420
IAST [candidate] (25.29 ms) : 0, 25290
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~817c05c18f, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057966
Total [baseline] (11.076 s) : 0, 11076054
Agent [candidate] (1.065 s) : 0, 1065235
Total [candidate] (11.315 s) : 0, 11314713
section appsec
Agent [baseline] (1.246 s) : 0, 1246190
Total [baseline] (11.221 s) : 0, 11220730
Agent [candidate] (1.254 s) : 0, 1254201
Total [candidate] (11.13 s) : 0, 11129641
section iast
Agent [baseline] (1.241 s) : 0, 1240509
Total [baseline] (11.389 s) : 0, 11389163
Agent [candidate] (1.237 s) : 0, 1237015
Total [candidate] (11.422 s) : 0, 11422402
section profiling
Agent [baseline] (1.184 s) : 0, 1183743
Total [baseline] (11.064 s) : 0, 11063809
Agent [candidate] (1.182 s) : 0, 1182005
Total [candidate] (10.966 s) : 0, 10966483
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~817c05c18f, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (628.101 ms) : 0, 628101
BytebuddyAgent [candidate] (631.037 ms) : 0, 631037
AgentMeter [baseline] (29.063 ms) : 0, 29063
AgentMeter [candidate] (29.366 ms) : 0, 29366
GlobalTracer [baseline] (256.415 ms) : 0, 256415
GlobalTracer [candidate] (259.502 ms) : 0, 259502
AppSec [baseline] (31.393 ms) : 0, 31393
AppSec [candidate] (31.942 ms) : 0, 31942
Debugger [baseline] (59.281 ms) : 0, 59281
Debugger [candidate] (60.083 ms) : 0, 60083
Remote Config [baseline] (621.011 µs) : 0, 621
Remote Config [candidate] (631.729 µs) : 0, 632
Telemetry [baseline] (8.6 ms) : 0, 8600
Telemetry [candidate] (8.842 ms) : 0, 8842
Flare Poller [baseline] (7.205 ms) : 0, 7205
Flare Poller [candidate] (6.489 ms) : 0, 6489
section appsec
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (657.81 ms) : 0, 657810
BytebuddyAgent [candidate] (663.558 ms) : 0, 663558
AgentMeter [baseline] (12.028 ms) : 0, 12028
AgentMeter [candidate] (12.116 ms) : 0, 12116
GlobalTracer [baseline] (257.981 ms) : 0, 257981
GlobalTracer [candidate] (259.459 ms) : 0, 259459
IAST [baseline] (23.978 ms) : 0, 23978
IAST [candidate] (24.184 ms) : 0, 24184
AppSec [baseline] (177.559 ms) : 0, 177559
AppSec [candidate] (177.804 ms) : 0, 177804
Debugger [baseline] (66.038 ms) : 0, 66038
Debugger [candidate] (66.135 ms) : 0, 66135
Remote Config [baseline] (574.736 µs) : 0, 575
Remote Config [candidate] (577.235 µs) : 0, 577
Telemetry [baseline] (8.99 ms) : 0, 8990
Telemetry [candidate] (9.031 ms) : 0, 9031
Flare Poller [baseline] (3.721 ms) : 0, 3721
Flare Poller [candidate] (3.639 ms) : 0, 3639
section iast
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (805.479 ms) : 0, 805479
BytebuddyAgent [candidate] (803.022 ms) : 0, 803022
AgentMeter [baseline] (11.669 ms) : 0, 11669
AgentMeter [candidate] (11.631 ms) : 0, 11631
GlobalTracer [baseline] (249.433 ms) : 0, 249433
GlobalTracer [candidate] (248.665 ms) : 0, 248665
IAST [baseline] (25.413 ms) : 0, 25413
IAST [candidate] (25.351 ms) : 0, 25351
AppSec [baseline] (26.773 ms) : 0, 26773
AppSec [candidate] (26.709 ms) : 0, 26709
Debugger [baseline] (63.828 ms) : 0, 63828
Debugger [candidate] (63.97 ms) : 0, 63970
Remote Config [baseline] (521.161 µs) : 0, 521
Remote Config [candidate] (522.409 µs) : 0, 522
Telemetry [baseline] (15.022 ms) : 0, 15022
Telemetry [candidate] (14.826 ms) : 0, 14826
Flare Poller [baseline] (4.896 ms) : 0, 4896
Flare Poller [candidate] (4.912 ms) : 0, 4912
section profiling
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (683.45 ms) : 0, 683450
BytebuddyAgent [candidate] (682.999 ms) : 0, 682999
AgentMeter [baseline] (8.62 ms) : 0, 8620
AgentMeter [candidate] (8.658 ms) : 0, 8658
GlobalTracer [baseline] (215.272 ms) : 0, 215272
GlobalTracer [candidate] (215.221 ms) : 0, 215221
AppSec [baseline] (31.917 ms) : 0, 31917
AppSec [candidate] (31.889 ms) : 0, 31889
Debugger [baseline] (64.488 ms) : 0, 64488
Debugger [candidate] (63.464 ms) : 0, 63464
Remote Config [baseline] (590.449 µs) : 0, 590
Remote Config [candidate] (598.332 µs) : 0, 598
Telemetry [baseline] (8.978 ms) : 0, 8978
Telemetry [candidate] (9.84 ms) : 0, 9840
Flare Poller [baseline] (3.556 ms) : 0, 3556
Flare Poller [candidate] (3.455 ms) : 0, 3455
ProfilingAgent [baseline] (94.41 ms) : 0, 94410
ProfilingAgent [candidate] (93.739 ms) : 0, 93739
Profiling [baseline] (94.981 ms) : 0, 94981
Profiling [candidate] (94.302 ms) : 0, 94302
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~817c05c18f, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section baseline
no_agent (19.137 ms) : 18935, 19340
. : milestone, 19137,
appsec (19.139 ms) : 18946, 19332
. : milestone, 19139,
code_origins (17.809 ms) : 17632, 17986
. : milestone, 17809,
iast (17.78 ms) : 17603, 17957
. : milestone, 17780,
profiling (18.33 ms) : 18148, 18511
. : milestone, 18330,
tracing (17.548 ms) : 17373, 17723
. : milestone, 17548,
section candidate
no_agent (17.763 ms) : 17584, 17941
. : milestone, 17763,
appsec (18.633 ms) : 18444, 18822
. : milestone, 18633,
code_origins (18.735 ms) : 18545, 18924
. : milestone, 18735,
iast (17.997 ms) : 17816, 18177
. : milestone, 17997,
profiling (18.588 ms) : 18397, 18778
. : milestone, 18588,
tracing (17.576 ms) : 17402, 17750
. : milestone, 17576,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~817c05c18f, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section baseline
no_agent (1.18 ms) : 1169, 1191
. : milestone, 1180,
iast (3.263 ms) : 3212, 3313
. : milestone, 3263,
iast_FULL (5.943 ms) : 5883, 6003
. : milestone, 5943,
iast_GLOBAL (3.427 ms) : 3381, 3474
. : milestone, 3427,
profiling (2.198 ms) : 2177, 2220
. : milestone, 2198,
tracing (1.807 ms) : 1792, 1821
. : milestone, 1807,
section candidate
no_agent (1.198 ms) : 1187, 1210
. : milestone, 1198,
iast (3.135 ms) : 3093, 3176
. : milestone, 3135,
iast_FULL (5.94 ms) : 5881, 6000
. : milestone, 5940,
iast_GLOBAL (3.559 ms) : 3508, 3611
. : milestone, 3559,
profiling (2.104 ms) : 2085, 2123
. : milestone, 2104,
tracing (1.811 ms) : 1796, 1825
. : milestone, 1811,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~817c05c18f, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (3.797 ms) : 3577, 4017
. : milestone, 3797,
iast (2.244 ms) : 2175, 2313
. : milestone, 2244,
iast_GLOBAL (2.297 ms) : 2227, 2367
. : milestone, 2297,
profiling (2.079 ms) : 2024, 2133
. : milestone, 2079,
tracing (2.051 ms) : 1997, 2104
. : milestone, 2051,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.702 ms) : 3488, 3916
. : milestone, 3702,
iast (2.244 ms) : 2175, 2313
. : milestone, 2244,
iast_GLOBAL (2.283 ms) : 2213, 2352
. : milestone, 2283,
profiling (2.071 ms) : 2016, 2125
. : milestone, 2071,
tracing (2.063 ms) : 2009, 2117
. : milestone, 2063,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~817c05c18f, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section baseline
no_agent (14.767 s) : 14767000, 14767000
. : milestone, 14767000,
appsec (14.951 s) : 14951000, 14951000
. : milestone, 14951000,
iast (18.028 s) : 18028000, 18028000
. : milestone, 18028000,
iast_GLOBAL (17.708 s) : 17708000, 17708000
. : milestone, 17708000,
profiling (15.313 s) : 15313000, 15313000
. : milestone, 15313000,
tracing (15.323 s) : 15323000, 15323000
. : milestone, 15323000,
section candidate
no_agent (15.357 s) : 15357000, 15357000
. : milestone, 15357000,
appsec (15.051 s) : 15051000, 15051000
. : milestone, 15051000,
iast (17.865 s) : 17865000, 17865000
. : milestone, 17865000,
iast_GLOBAL (17.877 s) : 17877000, 17877000
. : milestone, 17877000,
profiling (15.102 s) : 15102000, 15102000
. : milestone, 15102000,
tracing (15.263 s) : 15263000, 15263000
. : milestone, 15263000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Replaces calls to
Objects.hash()withHashingUtils.hash()in theMetricCollectorto avoidObject[]allocation from var-args call.Motivation
Reduces
Object[]allocation which reduces GC activityAdditional Notes
Updated two
hashCode()method implementations in theMetricCollectorinner classes to useHashingUtils.hash()instead ofObjects.hash().Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issuePR by Bits
View session in Datadog
Comment @DataDog to request changes