-
Notifications
You must be signed in to change notification settings - Fork 324
Have Vertx 4.0 prioritize path and fallback to name
#10382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mhlidd
wants to merge
2
commits into
master
Choose a base branch
from
mhlidd/update_quarkus_path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~0134ed4dcf, baseline=1.59.0-SNAPSHOT~2a6801efde
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1090933
Total [baseline] (10.96 s) : 0, 10959561
Agent [candidate] (1.09 s) : 0, 1090358
Total [candidate] (10.858 s) : 0, 10857891
section appsec
Agent [baseline] (1.274 s) : 0, 1274386
Total [baseline] (11.034 s) : 0, 11034368
Agent [candidate] (1.283 s) : 0, 1283141
Total [candidate] (11.135 s) : 0, 11134997
section iast
Agent [baseline] (1.227 s) : 0, 1226737
Total [baseline] (11.232 s) : 0, 11231647
Agent [candidate] (1.245 s) : 0, 1245098
Total [candidate] (11.26 s) : 0, 11259545
section profiling
Agent [baseline] (1.205 s) : 0, 1204778
Total [baseline] (10.912 s) : 0, 10911781
Agent [candidate] (1.205 s) : 0, 1205273
Total [candidate] (10.842 s) : 0, 10841955
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~0134ed4dcf, baseline=1.59.0-SNAPSHOT~2a6801efde
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (656.804 ms) : 0, 656804
BytebuddyAgent [candidate] (654.793 ms) : 0, 654793
GlobalTracer [baseline] (283.159 ms) : 0, 283159
GlobalTracer [candidate] (284.019 ms) : 0, 284019
AppSec [baseline] (32.658 ms) : 0, 32658
AppSec [candidate] (32.948 ms) : 0, 32948
Debugger [baseline] (67.809 ms) : 0, 67809
Debugger [candidate] (68.202 ms) : 0, 68202
Remote Config [baseline] (641.727 µs) : 0, 642
Remote Config [candidate] (653.473 µs) : 0, 653
Telemetry [baseline] (9.027 ms) : 0, 9027
Telemetry [candidate] (8.99 ms) : 0, 8990
Flare Poller [baseline] (3.825 ms) : 0, 3825
Flare Poller [candidate] (3.859 ms) : 0, 3859
section appsec
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (697.237 ms) : 0, 697237
BytebuddyAgent [candidate] (701.95 ms) : 0, 701950
GlobalTracer [baseline] (260.197 ms) : 0, 260197
GlobalTracer [candidate] (262.737 ms) : 0, 262737
IAST [baseline] (24.64 ms) : 0, 24640
IAST [candidate] (25.218 ms) : 0, 25218
AppSec [baseline] (174.088 ms) : 0, 174088
AppSec [candidate] (174.056 ms) : 0, 174056
Debugger [baseline] (67.474 ms) : 0, 67474
Debugger [candidate] (68.158 ms) : 0, 68158
Remote Config [baseline] (770.007 µs) : 0, 770
Remote Config [candidate] (780.076 µs) : 0, 780
Telemetry [baseline] (9.374 ms) : 0, 9374
Telemetry [candidate] (9.417 ms) : 0, 9417
Flare Poller [baseline] (3.8 ms) : 0, 3800
Flare Poller [candidate] (3.769 ms) : 0, 3769
section iast
crashtracking [baseline] (1.173 ms) : 0, 1173
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (791.517 ms) : 0, 791517
BytebuddyAgent [candidate] (805.758 ms) : 0, 805758
GlobalTracer [baseline] (258.063 ms) : 0, 258063
GlobalTracer [candidate] (260.541 ms) : 0, 260541
IAST [baseline] (27.148 ms) : 0, 27148
IAST [candidate] (27.461 ms) : 0, 27461
AppSec [baseline] (33.684 ms) : 0, 33684
AppSec [candidate] (35.675 ms) : 0, 35675
Debugger [baseline] (66.97 ms) : 0, 66970
Debugger [candidate] (65.764 ms) : 0, 65764
Remote Config [baseline] (595.229 µs) : 0, 595
Remote Config [candidate] (573.556 µs) : 0, 574
Telemetry [baseline] (8.53 ms) : 0, 8530
Telemetry [candidate] (8.598 ms) : 0, 8598
Flare Poller [baseline] (3.556 ms) : 0, 3556
Flare Poller [candidate] (3.611 ms) : 0, 3611
section profiling
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (701.266 ms) : 0, 701266
BytebuddyAgent [candidate] (702.427 ms) : 0, 702427
GlobalTracer [baseline] (221.346 ms) : 0, 221346
GlobalTracer [candidate] (221.225 ms) : 0, 221225
AppSec [baseline] (32.106 ms) : 0, 32106
AppSec [candidate] (32.033 ms) : 0, 32033
Debugger [baseline] (68.45 ms) : 0, 68450
Debugger [candidate] (67.927 ms) : 0, 67927
Remote Config [baseline] (628.949 µs) : 0, 629
Remote Config [candidate] (625.652 µs) : 0, 626
Telemetry [baseline] (9.094 ms) : 0, 9094
Telemetry [candidate] (8.943 ms) : 0, 8943
Flare Poller [baseline] (3.775 ms) : 0, 3775
Flare Poller [candidate] (3.755 ms) : 0, 3755
ProfilingAgent [baseline] (96.319 ms) : 0, 96319
ProfilingAgent [candidate] (97.152 ms) : 0, 97152
Profiling [baseline] (97.51 ms) : 0, 97510
Profiling [candidate] (97.722 ms) : 0, 97722
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~0134ed4dcf, baseline=1.59.0-SNAPSHOT~2a6801efde
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1086786
Total [baseline] (8.786 s) : 0, 8785692
Agent [candidate] (1.088 s) : 0, 1088107
Total [candidate] (8.778 s) : 0, 8777781
section iast
Agent [baseline] (1.234 s) : 0, 1233764
Total [baseline] (9.34 s) : 0, 9339626
Agent [candidate] (1.222 s) : 0, 1222001
Total [candidate] (9.346 s) : 0, 9346324
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~0134ed4dcf, baseline=1.59.0-SNAPSHOT~2a6801efde
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (654.467 ms) : 0, 654467
BytebuddyAgent [candidate] (653.087 ms) : 0, 653087
GlobalTracer [baseline] (282.659 ms) : 0, 282659
GlobalTracer [candidate] (284.561 ms) : 0, 284561
AppSec [baseline] (32.382 ms) : 0, 32382
AppSec [candidate] (32.866 ms) : 0, 32866
Debugger [baseline] (66.933 ms) : 0, 66933
Debugger [candidate] (67.307 ms) : 0, 67307
Remote Config [baseline] (654.183 µs) : 0, 654
Remote Config [candidate] (620.397 µs) : 0, 620
Telemetry [baseline] (8.949 ms) : 0, 8949
Telemetry [candidate] (9.049 ms) : 0, 9049
Flare Poller [baseline] (3.767 ms) : 0, 3767
Flare Poller [candidate] (3.812 ms) : 0, 3812
section iast
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (798.528 ms) : 0, 798528
BytebuddyAgent [candidate] (789.648 ms) : 0, 789648
GlobalTracer [baseline] (258.474 ms) : 0, 258474
GlobalTracer [candidate] (256.708 ms) : 0, 256708
IAST [baseline] (27.263 ms) : 0, 27263
IAST [candidate] (26.993 ms) : 0, 26993
AppSec [baseline] (34.968 ms) : 0, 34968
AppSec [candidate] (32.038 ms) : 0, 32038
Debugger [baseline] (64.906 ms) : 0, 64906
Debugger [candidate] (67.241 ms) : 0, 67241
Remote Config [baseline] (599.328 µs) : 0, 599
Remote Config [candidate] (584.558 µs) : 0, 585
Telemetry [baseline] (8.514 ms) : 0, 8514
Telemetry [candidate] (8.55 ms) : 0, 8550
Flare Poller [baseline] (3.589 ms) : 0, 3589
Flare Poller [candidate] (3.585 ms) : 0, 3585
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~0134ed4dcf, baseline=1.59.0-SNAPSHOT~2a6801efde
dateFormat X
axisFormat %s
section baseline
no_agent (17.498 ms) : 17322, 17673
. : milestone, 17498,
appsec (18.51 ms) : 18324, 18696
. : milestone, 18510,
code_origins (18.059 ms) : 17876, 18243
. : milestone, 18059,
iast (17.951 ms) : 17771, 18131
. : milestone, 17951,
profiling (19.591 ms) : 19390, 19792
. : milestone, 19591,
tracing (17.598 ms) : 17426, 17771
. : milestone, 17598,
section candidate
no_agent (19.624 ms) : 19420, 19828
. : milestone, 19624,
appsec (18.648 ms) : 18458, 18839
. : milestone, 18648,
code_origins (17.882 ms) : 17703, 18061
. : milestone, 17882,
iast (17.624 ms) : 17450, 17799
. : milestone, 17624,
profiling (19.81 ms) : 19609, 20012
. : milestone, 19810,
tracing (17.598 ms) : 17425, 17770
. : milestone, 17598,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~0134ed4dcf, baseline=1.59.0-SNAPSHOT~2a6801efde
dateFormat X
axisFormat %s
section baseline
no_agent (1.187 ms) : 1175, 1198
. : milestone, 1187,
iast (3.307 ms) : 3261, 3352
. : milestone, 3307,
iast_FULL (6.06 ms) : 5998, 6122
. : milestone, 6060,
iast_GLOBAL (3.486 ms) : 3443, 3530
. : milestone, 3486,
profiling (2.198 ms) : 2175, 2220
. : milestone, 2198,
tracing (1.801 ms) : 1785, 1816
. : milestone, 1801,
section candidate
no_agent (1.184 ms) : 1172, 1195
. : milestone, 1184,
iast (3.245 ms) : 3201, 3288
. : milestone, 3245,
iast_FULL (5.793 ms) : 5735, 5852
. : milestone, 5793,
iast_GLOBAL (3.494 ms) : 3439, 3549
. : milestone, 3494,
profiling (1.998 ms) : 1981, 2015
. : milestone, 1998,
tracing (1.78 ms) : 1765, 1795
. : milestone, 1780,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~0134ed4dcf, baseline=1.59.0-SNAPSHOT~2a6801efde
dateFormat X
axisFormat %s
section baseline
no_agent (14.976 s) : 14976000, 14976000
. : milestone, 14976000,
appsec (14.411 s) : 14411000, 14411000
. : milestone, 14411000,
iast (18.476 s) : 18476000, 18476000
. : milestone, 18476000,
iast_GLOBAL (17.786 s) : 17786000, 17786000
. : milestone, 17786000,
profiling (14.857 s) : 14857000, 14857000
. : milestone, 14857000,
tracing (14.763 s) : 14763000, 14763000
. : milestone, 14763000,
section candidate
no_agent (14.968 s) : 14968000, 14968000
. : milestone, 14968000,
appsec (15.127 s) : 15127000, 15127000
. : milestone, 15127000,
iast (18.106 s) : 18106000, 18106000
. : milestone, 18106000,
iast_GLOBAL (18.113 s) : 18113000, 18113000
. : milestone, 18113000,
profiling (14.788 s) : 14788000, 14788000
. : milestone, 14788000,
tracing (14.569 s) : 14569000, 14569000
. : milestone, 14569000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~0134ed4dcf, baseline=1.59.0-SNAPSHOT~2a6801efde
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.72 ms) : 3500, 3940
. : milestone, 3720,
iast (2.222 ms) : 2156, 2287
. : milestone, 2222,
iast_GLOBAL (2.263 ms) : 2197, 2329
. : milestone, 2263,
profiling (2.085 ms) : 2032, 2138
. : milestone, 2085,
tracing (2.055 ms) : 2003, 2106
. : milestone, 2055,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.736 ms) : 3516, 3956
. : milestone, 3736,
iast (2.23 ms) : 2165, 2296
. : milestone, 2230,
iast_GLOBAL (2.28 ms) : 2214, 2346
. : milestone, 2280,
profiling (2.505 ms) : 2344, 2666
. : milestone, 2505,
tracing (2.067 ms) : 2015, 2118
. : milestone, 2067,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Quarkus 3.18.0 introduced a change which manually set the
namefield ofRouteto include the full path. Contrary to before, thenamefield was not manually set, and would use the relative path set by thepathfield of theRoute. #5203 made a change which usesnameinstead ofpathwhen building a resource name due topathsometimes showing up as null. This PR now prioritizespathovername, and falls back tonamewhenpathis null.Motivation
A customer escalation was seeing their resource names set to
/q/q/*instead of/q*. Resource names for this were derived from concatenatingRoutingContext.mountPoint()withRoutingContext.currentRoute().getName(), which was causing this instance of duplicates of/q.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]