-
Notifications
You must be signed in to change notification settings - Fork 324
InstrumenterModule refactoring for java.concurrent module #10334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
amarziali
wants to merge
6
commits into
master
Choose a base branch
from
andrea.marziali/ref4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 6 performance improvements and 3 performance regressions! Performance is the same for 46 metrics, 10 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~65d89d0ed6, baseline=1.59.0-SNAPSHOT~6a2616f9fd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1087350
Total [baseline] (10.923 s) : 0, 10923060
Agent [candidate] (1.063 s) : 0, 1062897
Total [candidate] (10.798 s) : 0, 10797955
section appsec
Agent [baseline] (1.264 s) : 0, 1264018
Total [baseline] (10.821 s) : 0, 10820702
Agent [candidate] (1.255 s) : 0, 1254733
Total [candidate] (10.848 s) : 0, 10847832
section iast
Agent [baseline] (1.231 s) : 0, 1231405
Total [baseline] (11.1 s) : 0, 11100190
Agent [candidate] (1.215 s) : 0, 1215286
Total [candidate] (10.986 s) : 0, 10985666
section profiling
Agent [baseline] (1.21 s) : 0, 1209558
Total [baseline] (10.912 s) : 0, 10911559
Agent [candidate] (1.188 s) : 0, 1187524
Total [candidate] (10.934 s) : 0, 10933684
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~65d89d0ed6, baseline=1.59.0-SNAPSHOT~6a2616f9fd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (651.519 ms) : 0, 651519
BytebuddyAgent [candidate] (649.555 ms) : 0, 649555
GlobalTracer [baseline] (283.847 ms) : 0, 283847
GlobalTracer [candidate] (262.5 ms) : 0, 262500
AppSec [baseline] (33.059 ms) : 0, 33059
AppSec [candidate] (32.66 ms) : 0, 32660
Debugger [baseline] (68.766 ms) : 0, 68766
Debugger [candidate] (67.601 ms) : 0, 67601
Remote Config [baseline] (617.827 µs) : 0, 618
Remote Config [candidate] (596.881 µs) : 0, 597
Telemetry [baseline] (8.95 ms) : 0, 8950
Telemetry [candidate] (9.686 ms) : 0, 9686
Flare Poller [baseline] (3.867 ms) : 0, 3867
Flare Poller [candidate] (3.656 ms) : 0, 3656
section appsec
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (690.112 ms) : 0, 690112
BytebuddyAgent [candidate] (694.407 ms) : 0, 694407
GlobalTracer [baseline] (257.888 ms) : 0, 257888
GlobalTracer [candidate] (240.198 ms) : 0, 240198
AppSec [baseline] (173.814 ms) : 0, 173814
AppSec [candidate] (168.679 ms) : 0, 168679
Debugger [baseline] (67.048 ms) : 0, 67048
Debugger [candidate] (75.56 ms) : 0, 75560
Remote Config [baseline] (731.021 µs) : 0, 731
Remote Config [candidate] (650.483 µs) : 0, 650
Telemetry [baseline] (9.446 ms) : 0, 9446
Telemetry [candidate] (9.505 ms) : 0, 9505
Flare Poller [baseline] (3.774 ms) : 0, 3774
Flare Poller [candidate] (3.997 ms) : 0, 3997
IAST [baseline] (24.695 ms) : 0, 24695
IAST [candidate] (25.033 ms) : 0, 25033
section iast
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (797.38 ms) : 0, 797380
BytebuddyAgent [candidate] (799.106 ms) : 0, 799106
GlobalTracer [baseline] (256.874 ms) : 0, 256874
GlobalTracer [candidate] (238.083 ms) : 0, 238083
AppSec [baseline] (34.427 ms) : 0, 34427
AppSec [candidate] (30.302 ms) : 0, 30302
Debugger [baseline] (66.05 ms) : 0, 66050
Debugger [candidate] (70.931 ms) : 0, 70931
Remote Config [baseline] (598.59 µs) : 0, 599
Remote Config [candidate] (615.979 µs) : 0, 616
Telemetry [baseline] (8.584 ms) : 0, 8584
Telemetry [candidate] (8.486 ms) : 0, 8486
Flare Poller [baseline] (3.535 ms) : 0, 3535
Flare Poller [candidate] (3.557 ms) : 0, 3557
IAST [baseline] (27.388 ms) : 0, 27388
IAST [candidate] (27.396 ms) : 0, 27396
section profiling
ProfilingAgent [baseline] (97.78 ms) : 0, 97780
ProfilingAgent [candidate] (98.562 ms) : 0, 98562
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.241 ms) : 0, 1241
BytebuddyAgent [baseline] (705.064 ms) : 0, 705064
BytebuddyAgent [candidate] (682.264 ms) : 0, 682264
GlobalTracer [baseline] (221.796 ms) : 0, 221796
GlobalTracer [candidate] (220.592 ms) : 0, 220592
AppSec [baseline] (32.736 ms) : 0, 32736
AppSec [candidate] (33.296 ms) : 0, 33296
Debugger [baseline] (68.038 ms) : 0, 68038
Debugger [candidate] (68.239 ms) : 0, 68239
Remote Config [baseline] (651.861 µs) : 0, 652
Remote Config [candidate] (614.513 µs) : 0, 615
Telemetry [baseline] (8.857 ms) : 0, 8857
Telemetry [candidate] (8.784 ms) : 0, 8784
Flare Poller [baseline] (3.663 ms) : 0, 3663
Flare Poller [candidate] (3.892 ms) : 0, 3892
Profiling [baseline] (98.377 ms) : 0, 98377
Profiling [candidate] (99.153 ms) : 0, 99153
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~65d89d0ed6, baseline=1.59.0-SNAPSHOT~6a2616f9fd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1081721
Total [baseline] (8.749 s) : 0, 8748604
Agent [candidate] (1.063 s) : 0, 1062659
Total [candidate] (8.692 s) : 0, 8691888
section iast
Agent [baseline] (1.228 s) : 0, 1228367
Total [baseline] (9.32 s) : 0, 9320303
Agent [candidate] (1.219 s) : 0, 1218731
Total [candidate] (9.32 s) : 0, 9320482
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~65d89d0ed6, baseline=1.59.0-SNAPSHOT~6a2616f9fd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (649.191 ms) : 0, 649191
BytebuddyAgent [candidate] (649.68 ms) : 0, 649680
GlobalTracer [baseline] (282.472 ms) : 0, 282472
GlobalTracer [candidate] (262.592 ms) : 0, 262592
AppSec [baseline] (32.691 ms) : 0, 32691
AppSec [candidate] (32.585 ms) : 0, 32585
Debugger [baseline] (67.269 ms) : 0, 67269
Debugger [candidate] (66.912 ms) : 0, 66912
Remote Config [baseline] (623.89 µs) : 0, 624
Remote Config [candidate] (604.334 µs) : 0, 604
Telemetry [baseline] (9.065 ms) : 0, 9065
Telemetry [candidate] (8.987 ms) : 0, 8987
Flare Poller [baseline] (3.818 ms) : 0, 3818
Flare Poller [candidate] (4.497 ms) : 0, 4497
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (795.451 ms) : 0, 795451
BytebuddyAgent [candidate] (801.816 ms) : 0, 801816
GlobalTracer [baseline] (256.79 ms) : 0, 256790
GlobalTracer [candidate] (239.4 ms) : 0, 239400
AppSec [baseline] (34.47 ms) : 0, 34470
AppSec [candidate] (30.603 ms) : 0, 30603
Debugger [baseline] (65.03 ms) : 0, 65030
Debugger [candidate] (70.043 ms) : 0, 70043
Remote Config [baseline] (618.026 µs) : 0, 618
Remote Config [candidate] (591.071 µs) : 0, 591
Telemetry [baseline] (8.53 ms) : 0, 8530
Telemetry [candidate] (8.453 ms) : 0, 8453
Flare Poller [baseline] (3.534 ms) : 0, 3534
Flare Poller [candidate] (3.473 ms) : 0, 3473
IAST [baseline] (27.267 ms) : 0, 27267
IAST [candidate] (27.509 ms) : 0, 27509
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~65d89d0ed6, baseline=1.59.0-SNAPSHOT~6a2616f9fd
dateFormat X
axisFormat %s
section baseline
no_agent (17.035 ms) : 16867, 17203
. : milestone, 17035,
appsec (18.715 ms) : 18528, 18903
. : milestone, 18715,
code_origins (17.844 ms) : 17668, 18020
. : milestone, 17844,
iast (17.666 ms) : 17492, 17841
. : milestone, 17666,
profiling (18.633 ms) : 18449, 18816
. : milestone, 18633,
tracing (17.843 ms) : 17664, 18021
. : milestone, 17843,
section candidate
no_agent (19.14 ms) : 18944, 19336
. : milestone, 19140,
appsec (18.648 ms) : 18459, 18837
. : milestone, 18648,
code_origins (17.901 ms) : 17722, 18081
. : milestone, 17901,
iast (17.632 ms) : 17457, 17808
. : milestone, 17632,
profiling (18.674 ms) : 18486, 18862
. : milestone, 18674,
tracing (17.695 ms) : 17519, 17870
. : milestone, 17695,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~65d89d0ed6, baseline=1.59.0-SNAPSHOT~6a2616f9fd
dateFormat X
axisFormat %s
section baseline
no_agent (1.205 ms) : 1193, 1217
. : milestone, 1205,
iast (3.147 ms) : 3108, 3187
. : milestone, 3147,
iast_FULL (5.555 ms) : 5501, 5609
. : milestone, 5555,
iast_GLOBAL (3.663 ms) : 3597, 3729
. : milestone, 3663,
profiling (2.127 ms) : 2108, 2147
. : milestone, 2127,
tracing (1.778 ms) : 1763, 1794
. : milestone, 1778,
section candidate
no_agent (1.184 ms) : 1173, 1196
. : milestone, 1184,
iast (3.182 ms) : 3142, 3223
. : milestone, 3182,
iast_FULL (5.782 ms) : 5724, 5840
. : milestone, 5782,
iast_GLOBAL (3.607 ms) : 3554, 3659
. : milestone, 3607,
profiling (1.924 ms) : 1907, 1940
. : milestone, 1924,
tracing (1.784 ms) : 1770, 1798
. : milestone, 1784,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~65d89d0ed6, baseline=1.59.0-SNAPSHOT~6a2616f9fd
dateFormat X
axisFormat %s
section baseline
no_agent (14.758 s) : 14758000, 14758000
. : milestone, 14758000,
appsec (14.716 s) : 14716000, 14716000
. : milestone, 14716000,
iast (18.173 s) : 18173000, 18173000
. : milestone, 18173000,
iast_GLOBAL (17.807 s) : 17807000, 17807000
. : milestone, 17807000,
profiling (14.801 s) : 14801000, 14801000
. : milestone, 14801000,
tracing (14.9 s) : 14900000, 14900000
. : milestone, 14900000,
section candidate
no_agent (15.568 s) : 15568000, 15568000
. : milestone, 15568000,
appsec (14.994 s) : 14994000, 14994000
. : milestone, 14994000,
iast (18.29 s) : 18290000, 18290000
. : milestone, 18290000,
iast_GLOBAL (17.947 s) : 17947000, 17947000
. : milestone, 17947000,
profiling (14.588 s) : 14588000, 14588000
. : milestone, 14588000,
tracing (14.617 s) : 14617000, 14617000
. : milestone, 14617000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~65d89d0ed6, baseline=1.59.0-SNAPSHOT~6a2616f9fd
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.65 ms) : 3435, 3866
. : milestone, 3650,
iast (2.226 ms) : 2161, 2291
. : milestone, 2226,
iast_GLOBAL (2.263 ms) : 2197, 2328
. : milestone, 2263,
profiling (2.086 ms) : 2032, 2141
. : milestone, 2086,
tracing (2.053 ms) : 2001, 2105
. : milestone, 2053,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.716 ms) : 3497, 3935
. : milestone, 3716,
iast (2.216 ms) : 2151, 2282
. : milestone, 2216,
iast_GLOBAL (2.252 ms) : 2187, 2317
. : milestone, 2252,
profiling (2.087 ms) : 2033, 2142
. : milestone, 2087,
tracing (2.05 ms) : 1998, 2101
. : milestone, 2050,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: others
All other instrumentations
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Tries to logically group insturmenters beloging to java-concurrent.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]