Skip to content

Bump version to 2.1.0, and fix ksr formatting#314

Merged
xlamorlette-datadog merged 2 commits intomainfrom
xlamorlette/version-2-1-0
May 5, 2026
Merged

Bump version to 2.1.0, and fix ksr formatting#314
xlamorlette-datadog merged 2 commits intomainfrom
xlamorlette/version-2-1-0

Conversation

@xlamorlette-datadog
Copy link
Copy Markdown
Collaborator

@xlamorlette-datadog xlamorlette-datadog commented May 5, 2026

In order to prepare a delivery, bump version to 2.1.0, because there are functional changes since the latest release, https://github.com/DataDog/dd-trace-cpp/releases/tag/v2.0.0 (from October 14th, 2025).

By the way, I had to fix the formatting of the Knuth sampling rate (_dd.p.ksr) to fixed, with maximum 6 decimal digits and no trailing decimal zeros.
This was recently (on March 12th) modified by #288.
But we just got new failures from system tests. See this failed CI job:

Expected _dd.p.ksr='0.000001', got: 1e-06
Expected _dd.p.ksr='0', got: 1e-07
Expected _dd.p.ksr='0.000001', got: 5.1e-07

@xlamorlette-datadog xlamorlette-datadog requested review from a team as code owners May 5, 2026 12:27
@xlamorlette-datadog xlamorlette-datadog requested review from dubloom and removed request for a team May 5, 2026 12:27
Copy link
Copy Markdown
Contributor

@dubloom dubloom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 5, 2026

Benchmarks

Benchmark execution time: 2026-05-05 14:27:13

Comparing candidate commit 6cf62cd in PR branch xlamorlette/version-2-1-0 with baseline commit 422dc91 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:BM_TraceTinyCCSource

  • 🟥 execution_time [+3.063ms; +3.216ms] or [+4.014%; +4.214%]

@datadog-prod-us1-5
Copy link
Copy Markdown

datadog-prod-us1-5 Bot commented May 5, 2026

🎯 Code Coverage (details)
Patch Coverage: 84.21%
Overall Coverage: 90.86%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6cf62cd | Docs | Datadog PR Page | Give us feedback!

Comment thread src/datadog/trace_segment.cpp
Copy link
Copy Markdown
Contributor

@zacharycmontoya zacharycmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@xlamorlette-datadog xlamorlette-datadog changed the title Bump version to 2.1.0 Bump version to 2.1.0, and fix ksr formatting May 5, 2026
Copy link
Copy Markdown
Contributor

@bm1549 bm1549 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving knuth sampling changes

@xlamorlette-datadog xlamorlette-datadog merged commit 4412e16 into main May 5, 2026
40 checks passed
@xlamorlette-datadog xlamorlette-datadog deleted the xlamorlette/version-2-1-0 branch May 5, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants