Skip to content

RUM-8112: Fix gradients not showing in compose#3471

Draft
jonathanmos wants to merge 1 commit into
developfrom
jmoskovich/rum-8112/container-colors
Draft

RUM-8112: Fix gradients not showing in compose#3471
jonathanmos wants to merge 1 commit into
developfrom
jmoskovich/rum-8112/container-colors

Conversation

@jonathanmos
Copy link
Copy Markdown
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@datadog-prod-us1-6
Copy link
Copy Markdown

datadog-prod-us1-6 Bot commented May 26, 2026

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

DataDog/dd-sdk-android | analysis:detekt-custom   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). UnsafeThirdPartyFunctionCall: Calling androidx.compose.ui.graphics.Color.constructor(kotlin.ULong) could throw exceptions at /go/src/github.com/DataDog/dd-sdk-android/features/dd-sdk-android-session-replay-compose/src/main/kotlin/com/datadog/android/sessionreplay/compose/internal/utils/SemanticsUtils.kt:167:29

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b0467d1 | Docs | Datadog PR Page | Give us feedback!

@jonathanmos jonathanmos force-pushed the jmoskovich/rum-8112/container-colors branch 2 times, most recently from 19b4611 to 6d3dd9a Compare May 26, 2026 12:27
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 26, 2026

Codecov Report

❌ Patch coverage is 56.41026% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.35%. Comparing base (46d5a1a) to head (7a91816).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...onreplay/compose/internal/utils/ReflectionUtils.kt 27.27% 4 Missing and 4 partials ⚠️
...y/compose/internal/reflection/ComposeReflection.kt 42.86% 0 Missing and 4 partials ⚠️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 80.00% 1 Missing and 3 partials ⚠️
...l/mappers/semantics/AbstractSemanticsNodeMapper.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3471      +/-   ##
===========================================
+ Coverage    72.25%   72.35%   +0.11%     
===========================================
  Files          964      964              
  Lines        35554    35590      +36     
  Branches      5922     5937      +15     
===========================================
+ Hits         25687    25751      +64     
+ Misses        8263     8170      -93     
- Partials      1604     1669      +65     
Files with missing lines Coverage Δ
...l/mappers/semantics/AbstractSemanticsNodeMapper.kt 77.36% <0.00%> (ø)
...y/compose/internal/reflection/ComposeReflection.kt 37.16% <42.86%> (+37.16%) ⬆️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 70.61% <80.00%> (+0.88%) ⬆️
...onreplay/compose/internal/utils/ReflectionUtils.kt 4.44% <27.27%> (+3.18%) ⬆️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonathanmos jonathanmos force-pushed the jmoskovich/rum-8112/container-colors branch from 6d3dd9a to 7a91816 Compare May 26, 2026 14:10
@jonathanmos
Copy link
Copy Markdown
Member Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a91816d84

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jonathanmos jonathanmos force-pushed the jmoskovich/rum-8112/container-colors branch from 7a91816 to 34fc2f8 Compare May 27, 2026 11:25
@jonathanmos jonathanmos force-pushed the jmoskovich/rum-8112/container-colors branch from 34fc2f8 to b0467d1 Compare May 27, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants