`timeseries` [2/6] RUM-13949: Implement timeseries pipeline infrastructure by satween · Pull Request #3432 · DataDog/dd-sdk-android

satween · 2026-05-12T01:09:12Z

What does this PR do?

Adds the foundational building blocks shared by all timeseries metric types: the Timeseries lifecycle interface, immutable DataPoint, the Buffer/DeltaCompression/Pipeline data-processing chain, the EventWriter flush boundary, JsonSerializer interface, DataPointsReader/VitalReaderWrapper for OS-metric abstraction, and RumSessionScopeTimeseries — the generic per-session scheduler that drives sampling, batching, and writing for any metric type.

Motivation

Establishes the shared infrastructure that CPU and memory collectors will extend, keeping primitive types and pipeline logic isolated so they can be reviewed without metric-specific details.

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Make sure you discussed the feature or bugfix with the maintaining team in an Issue
Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

satween · 2026-05-12T01:09:28Z

timeseries [6/6] RUM-13949 Add end-to-end timeseries verification tests with CSV fixtures #3436
timeseries [5/6] RUM-13949 Wire timeseries collection into RUM session lifecycle #3435
timeseries [4/6] RUM-13949 Add memory timeseries serializer and session factory #3434
timeseries [3/6] RUM-13949: Add CPU timeseries data-point reader and serializer #3433
timeseries [2/6] RUM-13949: Implement timeseries pipeline infrastructure #3432 👈 (View in Graphite)
timeseries RUM-13949: Add timeseries JSON schemas and regenerate API surface #3431
feature/timeseries

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov-commenter · 2026-05-13T14:16:01Z

Codecov Report

❌ Patch coverage is 92.90780% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.27%. Comparing base (8782c2c) to head (76026c3).

Files with missing lines	Patch %	Lines
...ndroid/rum/internal/timeseries/DeltaCompression.kt	0.00%	7 Missing ⚠️
...m/internal/timeseries/RumSessionScopeTimeseries.kt	95.74%	1 Missing and 1 partial ⚠️
...atadog/android/rum/internal/timeseries/Pipeline.kt	93.75%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                  Coverage Diff                   @@
##           feature/timeseries    #3432      +/-   ##
======================================================
- Coverage               72.27%   72.27%   -0.00%     
======================================================
  Files                     964      972       +8     
  Lines                   35554    35670     +116     
  Branches                 5922     5944      +22     
======================================================
+ Hits                    25694    25777      +83     
- Misses                   8249     8281      +32     
- Partials                 1611     1612       +1

Files with missing lines	Coverage Δ
.../datadog/android/rum/internal/RumSessionTypeExt.kt	`100.00% <100.00%> (ø)`
...droid/rum/internal/domain/scope/RumSessionScope.kt	`91.81% <100.00%> (+0.73%)`	⬆️
.../datadog/android/rum/internal/timeseries/Buffer.kt	`100.00% <100.00%> (ø)`
...tadog/android/rum/internal/timeseries/DataPoint.kt	`100.00% <100.00%> (ø)`
...nal/timeseries/RumSessionScopeTimeseriesFactory.kt	`100.00% <100.00%> (ø)`
...m/internal/timeseries/provider/DataPointsReader.kt	`100.00% <100.00%> (ø)`
...internal/timeseries/provider/VitalReaderWrapper.kt	`100.00% <100.00%> (ø)`
...atadog/android/rum/internal/timeseries/Pipeline.kt	`93.75% <93.75%> (ø)`
...m/internal/timeseries/RumSessionScopeTimeseries.kt	`95.74% <95.74%> (ø)`
...ndroid/rum/internal/timeseries/DeltaCompression.kt	`0.00% <0.00%> (ø)`

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7bb00bc938

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

kikoveiga

Nice! Just left some small comments, worth to check what Codex said about some concurrency issues.

satween · 2026-05-22T15:20:15Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5968d81b3b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-22T15:22:16Z

+        ) {
+            if (!isActive(generation)) return@scheduleSafe
+            try {
+                synchronized(pipeline, pipeline::execute)


Re-check stop state after taking the pipeline lock

If a scheduled tick passes the isActive(generation) check and then onSessionStop() runs before this lock is acquired, the stop path sets the state to STOPPED and flushes the same pipeline first; after that, this tick still executes pipeline.execute(), can append a new sample, and will not reschedule or flush it because the final isActive check is false. In that stop/race window the last sample is silently left in the buffer, so the runnable should re-check activity after acquiring the lock or the stop path should otherwise prevent post-flush execution.

Useful? React with 👍 / 👎.

0xnm · 2026-05-26T10:54:06Z

      - "java.util.concurrent.atomic.AtomicBoolean.constructor(kotlin.Boolean)"
      - "java.util.concurrent.atomic.AtomicBoolean.get()"
      - "java.util.concurrent.atomic.AtomicBoolean.getAndSet(kotlin.Boolean)"
+      - "java.util.concurrent.atomic.AtomicReference.getAndSet(com.datadog.android.rum.internal.timeseries.RumSessionScopeTimeseries.State?)"


nit: this should go below

0xnm · 2026-05-26T10:55:16Z

      - "kotlin.collections.MutableList.add(kotlin.Int, com.datadog.android.sessionreplay.internal.recorder.mapper.MapperTypeWrapper)"
      - "kotlin.collections.MutableList.add(kotlin.Int, com.datadog.android.sessionreplay.model.MobileSegment.Wireframe)"
      - "kotlin.collections.MutableList.add(kotlin.Int, com.datadog.android.sessionreplay.model.MobileSegment.Wireframe.ShapeWireframe)"
+      - "kotlin.collections.MutableList.add(com.datadog.android.rum.internal.timeseries.DataPoint)"


this should go above

0xnm · 2026-05-26T11:07:50Z


    @Test
-    fun `M keep session context W handleEvent(action) {before expiration}`(
-        forge: Forge


Is it the change by some custom formatter? ktlint 1.5.0 + config in develop branch doesn't do this. It seems that there are many formatting changes in this PR not related to the feature scope actually.

It makes diff to review bigger.

0xnm · 2026-05-26T11:11:05Z

+        whenever(mockRumFeatureScope.withWriteContext(any(), any())) doAnswer { inv ->
+            inv.getArgument<(DatadogContext, EventWriteScope) -> Unit>(inv.arguments.lastIndex)


by some reason Github code highlighter thinks that inv is a language keyword and highlights it respectively, although it is not in the list https://kotlinlang.org/docs/keyword-reference.html

0xnm · 2026-05-26T11:12:34Z

+        testedPipeline.flush()
+
+        // Then
+        verify(mockDataWriter, never()).write(any(), any(), any())


Suggested change

verify(mockDataWriter, never()).write(any(), any(), any())

verifyNoInteractions(mockDataWriter)

same maybe can be applied in the tests above

0xnm · 2026-05-26T11:13:24Z

+        val pipelineB = mockPipeline()
+        val provider: (String, String, RumSessionType) -> List<Pipeline<*>> =
+            mock<(String, String, RumSessionType) -> List<Pipeline<*>>>().apply {
+                org.mockito.kotlin.whenever(this(fakeSessionId, fakeApplicationId, fakeSessionType))


Suggested change

org.mockito.kotlin.whenever(this(fakeSessionId, fakeApplicationId, fakeSessionType))

whenever(this(fakeSessionId, fakeApplicationId, fakeSessionType))

Introduces the core primitives for the timeseries data pipeline: `Timeseries` interface (with `@NoOpImplementation`), `DataPoint`, `Buffer`, `DeltaCompression`, `Pipeline`, `EventWriter`, `JsonSerializer` interface, `DataPointsReader` interface, `VitalReaderWrapper`, and the generic `RumSessionScopeTimeseries` per-session collector. Also adds detekt safe-call allowlist entries for the new APIs. ### What does this PR do? Adds the foundational building blocks shared by all timeseries metric types: the `Timeseries` lifecycle interface, immutable `DataPoint`, the `Buffer`/`DeltaCompression`/`Pipeline` data-processing chain, the `EventWriter` flush boundary, `JsonSerializer` interface, `DataPointsReader`/`VitalReaderWrapper` for OS-metric abstraction, and `RumSessionScopeTimeseries` — the generic per-session scheduler that drives sampling, batching, and writing for any metric type. ### Motivation Establishes the shared infrastructure that CPU and memory collectors will extend, keeping primitive types and pipeline logic isolated so they can be reviewed without metric-specific details. ### Additional Notes Unit tests cover all primitives. `DataPointForgeryFactory` and the `Configurator` registration are included so subsequent commits can write tests against generated `DataPoint` values. `RumSessionTypeExt` session-type mappings are added here (used by both CPU and memory serializers in later commits).

- Switch `RumSessionScopeTimeseries` from owning a per-session executor to accepting a shared `ScheduledExecutorService` (no creation, no shutdown). - Add `RumSessionScopeTimeseriesFactory` so reviewers can see how `RumSessionScopeTimeseries` is instantiated. - Wire timeseries `start`/`stop` lifecycle into `RumSessionScope` (`startTimeseries`/`stopTimeseries` called from `renewSession`/`stopSession`). - Remove 3 unused entries added to `detekt_custom_safe_calls.yml` in this branch.

satween changed the title ~~RUM-13949 Implement timeseries pipeline infrastructure~~ timeseries RUM-13949: Implement timeseries pipeline infrastructure May 12, 2026

satween force-pushed the tvaleev/feature/RUM-13949/timeseries-pipeline-infrastructure branch from cacd357 to 1a6f200 Compare May 13, 2026 13:43

satween force-pushed the tvaleev/feature/RUM-13949/timeseries-pipeline-infrastructure branch from 1a6f200 to 7bb00bc Compare May 13, 2026 14:44

satween marked this pull request as ready for review May 14, 2026 09:20

satween requested review from a team as code owners May 14, 2026 09:20

chatgpt-codex-connector Bot reviewed May 14, 2026

View reviewed changes

Comment thread ...rum/src/main/kotlin/com/datadog/android/rum/internal/timeseries/RumSessionScopeTimeseries.kt Outdated

Base automatically changed from tvaleev/feature/RUM-13949/timeseries-json-schemas-api-surface to feature/timeseries May 14, 2026 11:02

satween force-pushed the tvaleev/feature/RUM-13949/timeseries-pipeline-infrastructure branch from 7bb00bc to f1063fa Compare May 14, 2026 19:40

kikoveiga reviewed May 15, 2026

View reviewed changes

0xnm reviewed May 18, 2026

View reviewed changes

aleksandr-gringauz reviewed May 18, 2026

View reviewed changes

Comment thread ...rum/src/main/kotlin/com/datadog/android/rum/internal/timeseries/RumSessionScopeTimeseries.kt Outdated

Comment thread ...d-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/timeseries/EventWriter.kt Outdated

This comment has been minimized.

Sign in to view

0xnm reviewed May 21, 2026

View reviewed changes

satween force-pushed the tvaleev/feature/RUM-13949/timeseries-pipeline-infrastructure branch from fa10624 to 5968d81 Compare May 22, 2026 13:01

satween requested review from 0xnm, aleksandr-gringauz and kikoveiga May 22, 2026 15:18

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

satween changed the title ~~timeseries RUM-13949: Implement timeseries pipeline infrastructure~~ timeseries [2/5] RUM-13949: Implement timeseries pipeline infrastructure May 25, 2026

satween changed the title ~~timeseries [2/5] RUM-13949: Implement timeseries pipeline infrastructure~~ timeseries [2/6] RUM-13949: Implement timeseries pipeline infrastructure May 25, 2026

ambushwork previously approved these changes May 26, 2026

View reviewed changes

aleksandr-gringauz previously approved these changes May 26, 2026

View reviewed changes

0xnm previously approved these changes May 26, 2026

View reviewed changes

satween dismissed stale reviews from 0xnm, aleksandr-gringauz, and ambushwork via 49598a9 May 27, 2026 09:59

satween force-pushed the tvaleev/feature/RUM-13949/timeseries-pipeline-infrastructure branch from 5968d81 to 49598a9 Compare May 27, 2026 09:59

satween force-pushed the tvaleev/feature/RUM-13949/timeseries-pipeline-infrastructure branch from 49598a9 to 76026c3 Compare May 27, 2026 10:03

aleksandr-gringauz approved these changes May 27, 2026

View reviewed changes

		whenever(mockRumFeatureScope.withWriteContext(any(), any())) doAnswer { inv ->
		inv.getArgument<(DatadogContext, EventWriteScope) -> Unit>(inv.arguments.lastIndex)

	verify(mockDataWriter, never()).write(any(), any(), any())
	verifyNoInteractions(mockDataWriter)

	org.mockito.kotlin.whenever(this(fakeSessionId, fakeApplicationId, fakeSessionType))
	whenever(this(fakeSessionId, fakeApplicationId, fakeSessionType))

Conversation

satween commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

Uh oh!

satween commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

kikoveiga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

satween commented May 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 22, 2026

Choose a reason for hiding this comment

Uh oh!

0xnm May 26, 2026

Choose a reason for hiding this comment

Uh oh!

0xnm May 26, 2026

Choose a reason for hiding this comment

Uh oh!

0xnm May 26, 2026

Choose a reason for hiding this comment

Uh oh!

0xnm May 26, 2026

Choose a reason for hiding this comment

Uh oh!

0xnm May 26, 2026

Choose a reason for hiding this comment

Uh oh!

0xnm May 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

satween commented May 12, 2026 •

edited

Loading

satween commented May 12, 2026 •

edited

Loading

codecov-commenter commented May 13, 2026 •

edited

Loading