Make flaky CME test more deterministic#3120
Closed
jonathanmos wants to merge 1 commit intodevelopfrom
Closed
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: f8dcf57 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3120 +/- ##
===========================================
+ Coverage 70.75% 70.81% +0.07%
===========================================
Files 893 893
Lines 32983 33000 +17
Branches 5547 5549 +2
===========================================
+ Hits 23334 23368 +34
- Misses 8089 8091 +2
+ Partials 1560 1541 -19 🚀 New features to boost your workflow:
|
ambushwork
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a flaky test that verifies that
flattenNodecreates a snapshot of the wireframes list before processing, preventingConcurrentModificationExceptionif the source list is modified during iteration. The test is now deterministic - removingtoListfromNodeFlattenerwill always cause the test to fail, while maintaining it will mean the test always passes.Motivation
Reduce flakiness.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)