refactor(go-forwarder): add HTTP middleware and consolidate forwarding#1135
Merged
ndakkoune merged 6 commits intoMay 28, 2026
Merged
Conversation
ViBiOh
reviewed
May 26, 2026
|
|
||
| if err != nil { | ||
| slog.LogAttrs(req.Context(), slog.LevelWarn, "request failed", append(attrs, slog.String("error", err.Error()))...) | ||
| continue |
Contributor
There was a problem hiding this comment.
In case of error here, we continue (retry) without waiting some time. Is it what we want?
Contributor
Author
There was a problem hiding this comment.
This error check is for requests that failed to be created (or something went wrong in the middleware stack). We don't want to retry those since they haven't reach the intake endpoint, hence we instantly retry them without waiting.
Contributor
Author
There was a problem hiding this comment.
(e.g. DNS lookup fail should just retry after some time bc it could be transient)
This comment has been minimized.
This comment has been minimized.
ndakkoune
force-pushed
the
nabil.dakkoune/go-forwarder-middleware
branch
from
8b93f8d to
f846620
Compare
ndakkoune
commented
May 27, 2026
ndakkoune
commented
May 27, 2026
| func WithCompression(next http.RoundTripper) RoundTripperFunc { | ||
| return func(req *http.Request) (*http.Response, error) { | ||
| var buf bytes.Buffer | ||
| gz := gzip.NewWriter(&buf) |
ndakkoune
commented
May 27, 2026
ndakkoune
commented
May 27, 2026
ndakkoune
commented
May 27, 2026
ndakkoune
commented
May 27, 2026
| return func(req *http.Request) (*http.Response, error) { | ||
| buf := getBuffer() | ||
| gz := getGzipWriter() | ||
| defer bufPool.Put(buf) |
Contributor
Author
There was a problem hiding this comment.
@ViBiOh If a middleware layer call WithCompression, it may access the buffer/body of another goroutine. Should I make something about that or I can assume that I will always have the WithCompression as the first layer ?
ViBiOh
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors the forwarding package to use HTTP middleware and enhance errors/logging/retry on intake failures
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply