Undefined CLC Replica Count Remains Undefined

[gabedos]

What does this PR do?

When the replica count for the CLC deployment is undefined, no longer use the default value of 1, instead leave it undefined. The API server will implicitly set this value to 1. This allows for smoother controls with external autoscalers which recommend the replica count being undefined and letting it control the count completely.

Describe your test plan

You should see 1 CLC runner

  apiVersion: datadoghq.com/v2alpha1
  kind: DatadogAgent                                                                                                                                  
  metadata:
    name: datadog                                                                                                                                     
    namespace: system                                                                                                                               
  spec:                                                                                                       
    features:
      clusterChecks:                                                                                                                                  
        enabled: true                                                                                                                               
        useClusterChecksRunners: true

Checklist

• PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
• PR has a milestone or the qa/skip-qa label
• All commits are signed (see: signing commits)

[datadog-prod-us1-4]

 

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

pull request linter | Check Milestone     

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration.

Missing milestone or `qa/skip-qa` label

pull request linter | build     

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration.

Missing required labels for pull request: valid labels required are ['bug', 'enhancement', 'refactoring', 'documentation', 'tooling', 'dependencies'].

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 42.58% (+0.00%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0cdbc4b | Docs | Datadog PR Page | Give us feedback!}

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.24%. Comparing base (03e4b46) to head (0cdbc4b).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3036   +/-   ##
=======================================
  Coverage   42.24%   42.24%           
=======================================
  Files         337      337           
  Lines       28952    28951    -1     
=======================================
  Hits        12230    12230           
+ Misses      15917    15916    -1     
  Partials      805      805           

Flag	Coverage Δ
unittests	42.24% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...adogagent/component/clusterchecksrunner/default.go	10.75% <ø> (+0.05%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03e4b46...0cdbc4b. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.