Restore system-probe DSD socket volumeMount#3001
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7cba80522
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| common.GetVolumeMountForProc(), | ||
| common.GetVolumeMountForRunPath(), | ||
| common.GetVolumeMountForTmp(), | ||
| common.GetVolumeMountForDogstatsdSocket(false), |
There was a problem hiding this comment.
When the Autopilot annotation is enabled and system-probe is present (for example with the current default image where service discovery auto-enables it), this new default mount leaves the DaemonSet invalid: applyExperimentalAutopilotOverrides removes the dsdsocket volume from the pod and only strips that mount from core/trace/process containers, not system-probe. The resulting system-probe container references a volume that no longer exists, so Kubernetes rejects the pod template with a missing volumeMount volume.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
It's fine, autopilot is being reworked in #2983 so related code will be updated accordingly
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3001 +/- ##
==========================================
- Coverage 40.76% 40.76% -0.01%
==========================================
Files 332 332
Lines 28197 28198 +1
==========================================
Hits 11494 11494
- Misses 15928 15929 +1
Partials 775 775
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
4 participants
What does this PR do?
See title
Motivation
system-probe needs DSD socket to write metrics to it (was removed in #2985) when direct mode is enabled (no security-agent)
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Staging
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel