Skip to content

[OTAGENT-920] Set DD_OTELCOLLECTOR_INSTALLATION_METHOD on otel-agent container#2846

Merged
tbavelier merged 4 commits intomainfrom
stanley.liu/OTAGENT-920
Apr 9, 2026
Merged

[OTAGENT-920] Set DD_OTELCOLLECTOR_INSTALLATION_METHOD on otel-agent container#2846
tbavelier merged 4 commits intomainfrom
stanley.liu/OTAGENT-920

Conversation

@liustanley
Copy link
Copy Markdown
Contributor

What does this PR do?

Injects DD_OTELCOLLECTOR_INSTALLATION_METHOD=kubernetes into the otel-agent container when the Operator reconciles the node agent pod spec. This env var maps to the otelcollector.installation_method core config key, which the converter reads and injects into the extensions.datadog config so the Datadog extension can report the installation method in collector metadata payloads.

Motivation

Part of OTAGENT-920. Intended for the 7.78.0 agent release.

@liustanley liustanley changed the title Set DD_OTELCOLLECTOR_INSTALLATION_METHOD on otel-agent container [OTAGENT-920] Set DD_OTELCOLLECTOR_INSTALLATION_METHOD on otel-agent container Apr 8, 2026
@liustanley liustanley added the enhancement New feature or request label Apr 8, 2026
@liustanley liustanley added this to the v1.26.0 milestone Apr 8, 2026
@liustanley liustanley marked this pull request as ready for review April 8, 2026 20:05
@liustanley liustanley requested a review from a team April 8, 2026 20:05
@liustanley liustanley requested a review from a team as a code owner April 8, 2026 20:05
@liustanley liustanley requested a review from alyshawang April 8, 2026 20:05
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 10ea3160a0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread internal/controller/datadogagent/feature/otelcollector/feature.go
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.06%. Comparing base (395974a) to head (347f4a0).

Files with missing lines Patch % Lines
...controller/datadogagent/global/otelagentgateway.go 0.00% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2846   +/-   ##
=======================================
  Coverage   40.05%   40.06%           
=======================================
  Files         319      319           
  Lines       28031    28039    +8     
=======================================
+ Hits        11229    11233    +4     
- Misses      15979    15983    +4     
  Partials      823      823           
Flag Coverage Δ
unittests 40.06% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ller/datadogagent/feature/otelcollector/feature.go 77.13% <100.00%> (+0.41%) ⬆️
...controller/datadogagent/global/otelagentgateway.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 395974a...347f4a0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tbavelier tbavelier merged commit 189f12c into main Apr 9, 2026
37 checks passed
@tbavelier tbavelier deleted the stanley.liu/OTAGENT-920 branch April 9, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants