Skip to content

[OTAGENT-512] Add more configs and examples to otel agent gateway#2490

Merged
songy23 merged 7 commits intomainfrom
yang.song/OTAGENT-512-1
Jan 22, 2026
Merged

[OTAGENT-512] Add more configs and examples to otel agent gateway#2490
songy23 merged 7 commits intomainfrom
yang.song/OTAGENT-512-1

Conversation

@songy23
Copy link
Copy Markdown
Member

@songy23 songy23 commented Jan 13, 2026

What does this PR do?

Add config FeatureGates to otel agent gateway matching the implementation in helm charts: http://github.com/DataDog/helm-charts/blob/main/charts/datadog/templates/otel-agent-gateway-deployment.yaml.

The following configs are already supported with override, so no need to add them again to otel agent gateway feature:

  1. Replicas
  2. NodeSelector
  3. Affinity
  4. Tolerations
  5. PriorityClassName
  6. Env
  7. EnvFrom
  8. Image

examples/datadogagent/datadog-agent-with-otelagentgateway.yaml shows an example of setting all the fields above (and many others) for otel agent gateway.

Motivation

Implement otel agent gateway in operator.

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: v7.74.0

Describe your test plan

For QA, use examples/datadogagent/datadog-agent-with-otelagentgateway.yaml. You can uncomment / tweak the parameters based on your needs. Verify the node selector, affinity, labels, replicas etc. in the otel agent gateway deployment and pods are expected.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@songy23 songy23 added this to the v1.23.0 milestone Jan 13, 2026
@songy23 songy23 added the enhancement New feature or request label Jan 13, 2026
@songy23 songy23 changed the title [[OTAGENT-512]] Add more configs to otel agent gateway [OTAGENT-512] Add more configs to otel agent gateway Jan 13, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.88%. Comparing base (dfeb5ee) to head (9779963).

Files with missing lines Patch % Lines
pkg/testutils/builder.go 0.00% 6 Missing ⚠️
...datadogagent/component/otelagentgateway/default.go 0.00% 5 Missing ⚠️

❌ Your patch status has failed because the patch coverage (42.10%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2490      +/-   ##
==========================================
+ Coverage   37.86%   37.88%   +0.02%     
==========================================
  Files         303      303              
  Lines       25995    26002       +7     
==========================================
+ Hits         9843     9851       +8     
+ Misses      15409    15408       -1     
  Partials      743      743              
Flag Coverage Δ
unittests 37.88% <42.10%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...r/datadogagent/feature/otelagentgateway/feature.go 90.97% <100.00%> (+0.57%) ⬆️
...datadogagent/component/otelagentgateway/default.go 0.00% <0.00%> (ø)
pkg/testutils/builder.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfeb5ee...9779963. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@songy23 songy23 force-pushed the yang.song/OTAGENT-512-1 branch from 5b56f18 to 81e0cda Compare January 15, 2026 13:17
@songy23 songy23 marked this pull request as ready for review January 15, 2026 13:36
@songy23 songy23 requested review from a team as code owners January 15, 2026 13:36
@songy23 songy23 marked this pull request as draft January 15, 2026 13:46
@songy23

This comment was marked as resolved.

@songy23 songy23 force-pushed the yang.song/OTAGENT-512-1 branch 2 times, most recently from 54d666b to 02121d5 Compare January 15, 2026 16:14
@songy23 songy23 force-pushed the yang.song/OTAGENT-512-1 branch from 02121d5 to b4a0cc1 Compare January 15, 2026 17:27
@songy23 songy23 changed the title [OTAGENT-512] Add more configs to otel agent gateway [OTAGENT-512] Add more configs and examples to otel agent gateway Jan 15, 2026
@songy23 songy23 marked this pull request as ready for review January 15, 2026 19:03
Copy link
Copy Markdown
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the description to "feature gates" would be more readable, but feel free to ignore if there are technical reasons to keep FeatureGates. Thanks!

Comment thread docs/configuration.v2alpha1.md Outdated
Comment thread docs/configuration_public.md Outdated
Comment thread internal/controller/datadogagent/feature/otelagentgateway/feature.go Outdated
Comment thread internal/controller/datadogagent/feature/otelagentgateway/feature_test.go Outdated
@songy23 songy23 dismissed tbavelier’s stale review January 22, 2026 16:49

Approved by #agent-onboarding while Timothée is OOO

@songy23
Copy link
Copy Markdown
Member Author

songy23 commented Jan 22, 2026

Test failure seems to be from mainline http://gitlab.ddbuild.io/DataDog/datadog-operator/-/jobs/1366828575

@songy23 songy23 merged commit c96db5a into main Jan 22, 2026
32 checks passed
@songy23 songy23 deleted the yang.song/OTAGENT-512-1 branch January 22, 2026 19:19
dd-octo-sts Bot pushed a commit that referenced this pull request Jan 22, 2026
)

* Add more configs in otel agent gateway

* Update feature gates docs

* review comments

---------

Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>
(cherry picked from commit c96db5a)
levan-m added a commit that referenced this pull request Jan 22, 2026
) (#2514)

* Add more configs in otel agent gateway

* Update feature gates docs

* review comments

---------


(cherry picked from commit c96db5a)

Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/v1.23 enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants