Fix E2E test trigger#1214
Merged
shreyamalpani merged 12 commits intomainfrom May 5, 2026
Merged
Conversation
purple4reina
reviewed
May 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes how E2E runs are launched from the GitLab pipeline by replacing the direct API-triggering flow with a GitLab downstream pipeline trigger plus a separate polling job. In this repo, that mainly affects the generated CI pipeline and the helper script that monitors the triggered E2E run.
Changes:
- Restricts generated E2E jobs to
arm64layer-publishing flavors. - Replaces the old curl-based downstream pipeline trigger with a
trigger:bridge job toDataDog/serverless-e2e-tests. - Reworks
poll_e2e.shto inspect the current pipeline’s bridge jobs instead of polling the downstream pipeline directly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.gitlab/templates/pipeline.yaml.tpl |
Updates generated E2E jobs to use a bridge trigger and adds a separate polling/status job. |
.gitlab/scripts/poll_e2e.sh |
Rewrites the polling logic to query GitLab bridge job state from the current pipeline. |
Comment on lines
+290
to
301
| e2e-test-status ({{ $f.name }}): | ||
| stage: e2e | ||
| image: registry.ddbuild.io/images/docker:20.10-py3 | ||
| tags: ["arch:amd64"] | ||
| timeout: 3h | ||
| variables: | ||
| E2E_JOB_NAME: "e2e-test ({{ $f.name }})" | ||
| needs: | ||
| - job: "publish layer e2e sandbox ({{ $f.name }})" | ||
| artifacts: false | ||
| script: | ||
| - .gitlab/scripts/poll_e2e.sh |
Comment on lines
+275
to
+277
| trigger: | ||
| project: DataDog/serverless-e2e-tests | ||
| strategy: depend |
Comment on lines
+32
to
+49
| E2E_JOB_STATUS=$(echo "$RESPONSE" | jq -r --arg name "$E2E_JOB_NAME" '.[] | select(.name==$name) | .downstream_pipeline.status') | ||
| echo -n "E2E job status: $E2E_JOB_STATUS, " | ||
| if [ "$E2E_JOB_STATUS" == "success" ]; then | ||
| echo "E2E tests completed successfully" | ||
| exit 0 | ||
| elif [ "$E2E_JOB_STATUS" == "failed" ]; then | ||
| echo "E2E tests failed" | ||
| exit 1 | ||
| elif [ "$E2E_JOB_STATUS" == "running" ]; then | ||
| echo "E2E tests are still running, retrying in 2 minutes..." | ||
| elif [ "$E2E_JOB_STATUS" == "canceled" ]; then | ||
| echo "E2E tests were canceled" | ||
| exit 1 | ||
| elif [ "$E2E_JOB_STATUS" == "skipped" ]; then | ||
| echo "E2E tests were skipped" | ||
| exit 0 | ||
| else | ||
| echo "Unknown E2E test status: $E2E_JOB_STATUS, retrying in 2 minutes..." |
purple4reina
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Change how the E2E tests are triggered. Launches pipelines for
amd64andamd64, fipsflavors, will add tests forarm64andarm64, fipsas well if these work as expected.Testing
E2E tests pass on this PR