Skip to content

Fix consistency issues in security monitoring signal triage routes #3810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
api-clients-generation-pipeline merged 1 commit into from
Mar 30, 2026
Merged

Fix consistency issues in security monitoring signal triage routes #3810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 25 additions & 45 deletions .generator/schemas/v2/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57944,6 +57944,7 @@ components:
- none
- false_positive
- testing_or_maintenance
- remediated
- investigated_case_opened
- true_positive_benign
- true_positive_malicious
Expand All @@ -57953,6 +57954,7 @@ components:
- NONE
- FALSE_POSITIVE
- TESTING_OR_MAINTENANCE
- REMEDIATED
- INVESTIGATED_CASE_OPENED
- TRUE_POSITIVE_BENIGN
- TRUE_POSITIVE_MALICIOUS
Expand Down Expand Up @@ -103305,6 +103307,8 @@ paths:
schema:
$ref: "#/components/schemas/SecurityMonitoringSignalResponse"
description: OK
"403":
$ref: "#/components/responses/NotAuthorizedResponse"
"404":
$ref: "#/components/responses/NotFoundResponse"
"429":
Expand Down Expand Up @@ -103342,25 +103346,17 @@ paths:
$ref: "#/components/schemas/SecurityMonitoringSignalTriageUpdateResponse"
description: OK
"400":
content:
application/json:
schema:
$ref: "#/components/schemas/APIErrorResponse"
description: Bad Request
$ref: "#/components/responses/BadRequestResponse"
"403":
content:
application/json:
schema:
$ref: "#/components/schemas/APIErrorResponse"
description: Forbidden
$ref: "#/components/responses/NotAuthorizedResponse"
"404":
content:
application/json:
schema:
$ref: "#/components/schemas/APIErrorResponse"
description: Not Found
$ref: "#/components/responses/NotFoundResponse"
"429":
$ref: "#/components/responses/TooManyRequestsResponse"
security:
- apiKeyAuth: []
appKeyAuth: []
- AuthZ: []
summary: Modify the triage assignee of a security signal
tags: ["Security Monitoring"]
x-codegen-request-body-name: body
Expand Down Expand Up @@ -103390,25 +103386,17 @@ paths:
$ref: "#/components/schemas/SecurityMonitoringSignalTriageUpdateResponse"
description: OK
"400":
content:
application/json:
schema:
$ref: "#/components/schemas/APIErrorResponse"
description: Bad Request
$ref: "#/components/responses/BadRequestResponse"
"403":
content:
application/json:
schema:
$ref: "#/components/schemas/APIErrorResponse"
description: Forbidden
$ref: "#/components/responses/NotAuthorizedResponse"
"404":
content:
application/json:
schema:
$ref: "#/components/schemas/APIErrorResponse"
description: Not Found
$ref: "#/components/responses/NotFoundResponse"
"429":
$ref: "#/components/responses/TooManyRequestsResponse"
security:
- apiKeyAuth: []
appKeyAuth: []
- AuthZ: []
summary: Change the related incidents of a security signal
tags: ["Security Monitoring"]
x-codegen-request-body-name: body
Expand Down Expand Up @@ -103438,25 +103426,17 @@ paths:
$ref: "#/components/schemas/SecurityMonitoringSignalTriageUpdateResponse"
description: OK
"400":
content:
application/json:
schema:
$ref: "#/components/schemas/APIErrorResponse"
description: Bad Request
$ref: "#/components/responses/BadRequestResponse"
"403":
content:
application/json:
schema:
$ref: "#/components/schemas/APIErrorResponse"
description: Forbidden
$ref: "#/components/responses/NotAuthorizedResponse"
"404":
content:
application/json:
schema:
$ref: "#/components/schemas/APIErrorResponse"
description: Not Found
$ref: "#/components/responses/NotFoundResponse"
"429":
$ref: "#/components/responses/TooManyRequestsResponse"
security:
- apiKeyAuth: []
appKeyAuth: []
- AuthZ: []
summary: Change the triage state of a security signal
tags: ["Security Monitoring"]
x-codegen-request-body-name: body
Expand Down
9 changes: 8 additions & 1 deletion packages/datadog-api-client-v2/apis/SecurityMonitoringApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1303,6 +1303,7 @@ export class SecurityMonitoringApiRequestFactory extends BaseAPIRequestFactory {
applySecurityAuthentication(_config, requestContext, [
"apiKeyAuth",
"appKeyAuth",
"AuthZ",
]);

return requestContext;
Expand Down Expand Up @@ -1363,6 +1364,7 @@ export class SecurityMonitoringApiRequestFactory extends BaseAPIRequestFactory {
applySecurityAuthentication(_config, requestContext, [
"apiKeyAuth",
"appKeyAuth",
"AuthZ",
]);

return requestContext;
Expand Down Expand Up @@ -1418,6 +1420,7 @@ export class SecurityMonitoringApiRequestFactory extends BaseAPIRequestFactory {
applySecurityAuthentication(_config, requestContext, [
"apiKeyAuth",
"appKeyAuth",
"AuthZ",
]);

return requestContext;
Expand Down Expand Up @@ -7369,7 +7372,11 @@ export class SecurityMonitoringApiResponseProcessor {
) as SecurityMonitoringSignalResponse;
return body;
}
if (response.httpStatusCode === 404 || response.httpStatusCode === 429) {
if (
response.httpStatusCode === 403 ||
response.httpStatusCode === 404 ||
response.httpStatusCode === 429
) {
const bodyText = ObjectSerializer.parse(
await response.body.text(),
contentType
Expand Down
1 change: 1 addition & 0 deletions packages/datadog-api-client-v2/models/ObjectSerializer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5209,6 +5209,7 @@ const enumsMap: { [key: string]: any[] } = {
"none",
"false_positive",
"testing_or_maintenance",
"remediated",
"investigated_case_opened",
"true_positive_benign",
"true_positive_malicious",
Expand Down
2 changes: 2 additions & 0 deletions packages/datadog-api-client-v2/models/SecurityMonitoringSignalArchiveReason.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export type SecurityMonitoringSignalArchiveReason =
| typeof NONE
| typeof FALSE_POSITIVE
| typeof TESTING_OR_MAINTENANCE
| typeof REMEDIATED
| typeof INVESTIGATED_CASE_OPENED
| typeof TRUE_POSITIVE_BENIGN
| typeof TRUE_POSITIVE_MALICIOUS
Expand All @@ -22,6 +23,7 @@ export type SecurityMonitoringSignalArchiveReason =
export const NONE = "none";
export const FALSE_POSITIVE = "false_positive";
export const TESTING_OR_MAINTENANCE = "testing_or_maintenance";
export const REMEDIATED = "remediated";
export const INVESTIGATED_CASE_OPENED = "investigated_case_opened";
export const TRUE_POSITIVE_BENIGN = "true_positive_benign";
export const TRUE_POSITIVE_MALICIOUS = "true_positive_malicious";
Expand Down
Loading