Skip to content

🔧 Dissociate pinned e2e setup#4811

Open
bdibon wants to merge 1 commit into
mainfrom
boris.dibon/clarify-e2e-setup
Open

🔧 Dissociate pinned e2e setup#4811
bdibon wants to merge 1 commit into
mainfrom
boris.dibon/clarify-e2e-setup

Conversation

@bdibon

@bdibon bdibon commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Motivation

The default test:e2e:setup script mixed two concerns: building the repo and installing Playwright browsers, and additionally forcing a pinned Playwright version via yarn dlx for Chromium, Firefox, and WebKit. That made the common setup path heavier and less obvious when a pinned install is actually needed.

Changes

  • test:e2e:setup now runs yarn build, yarn build:apps, and yarn playwright install --with-deps only (aligned with the workspace Playwright dependency).
  • test:e2e:setup:pinned is a separate script that preserves the previous pinned Playwright install (playwright@1.40.1 via volta run --node 20) for workflows that still require that exact pin.

Test instructions

  • Run yarn test:e2e:setup and confirm it completes without invoking the pinned dlx Playwright install.
  • If you rely on the old pinned browsers install, run yarn test:e2e:setup:pinned after the main setup (or as needed) and confirm browsers install as before.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

Made with Cursor

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jun 19, 2026

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 172.46 KiB 172.46 KiB 0 B 0.00%
Rum Profiler 8.22 KiB 8.22 KiB 0 B 0.00%
Rum Recorder 21.09 KiB 21.09 KiB 0 B 0.00%
Logs 54.47 KiB 54.47 KiB 0 B 0.00%
Rum Slim 129.97 KiB 129.97 KiB 0 B 0.00%
Worker 22.96 KiB 22.96 KiB 0 B 0.00%

@bdibon bdibon force-pushed the boris.dibon/clarify-e2e-setup branch from b9a543b to 15d3506 Compare June 19, 2026 13:09
@bdibon bdibon marked this pull request as ready for review June 19, 2026 13:09
@bdibon bdibon requested a review from a team as a code owner June 19, 2026 13:09
@datadog-datadog-prod-us1

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 76.87% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 15d3506 | Docs | Datadog PR Page | Give us feedback!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15d3506dec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
"test:unit:bs": "node --env-file-if-exists=.env ./scripts/test/bs-wrapper.ts karma start test/unit/karma.bs.conf.js",
"test:e2e:setup": "yarn build && yarn build:apps && yarn playwright install --with-deps && yarn dlx -p playwright@1.40.1 playwright install chromium firefox webkit",
"test:e2e:setup": "yarn build && yarn build:apps && yarn playwright install --with-deps",
"test:e2e:setup:pinned": "volta run --node 20 yarn dlx -p playwright@1.40.1 playwright install chromium firefox webkit",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid requiring Volta for the pinned setup

issue: In a checkout where Yarn is available but volta is not on PATH, this newly documented setup path exits before installing the pinned browsers (yarn test:e2e:setup:pinned currently fails with command not found: volta). Since the repo setup instructions only require Yarn and this script is now the way to prepare the firefox-pinned/webkit-pinned projects locally, contributors who do not use Volta cannot run those projects; wrap the Node 20 workaround in a repo-managed script or document/enforce Volta before relying on this command.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They will figure it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants