Change formatters doc example from "text_table" option#367
Open
RacingTadpole wants to merge 1 commit intoDataBrewery:masterfrom
Open
Change formatters doc example from "text_table" option#367RacingTadpole wants to merge 1 commit intoDataBrewery:masterfrom
RacingTadpole wants to merge 1 commit intoDataBrewery:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks like a great framework, thanks! I am spending some time getting my head around how it works, and thought I'd start by submitting a PR for a documentation change :-)
I noticed the example at http://cubes.readthedocs.io/en/v1.1/formatters.html doesn't work, because it references the "text_table" formatter, which is no longer available by default.
This PR needs a tiny change to merge - the old line
needs to be replaced, but I'm not sure what with yet.
Btw, I notice the slicer server accepts a
format=json|csvparameter; I was looking at https://github.com/DataBrewery/cubes/blob/release-1.1/cubes/ext.py#L50-L52 because I guessed the allowed formats would match those (but they don't)...