Skip to content

Conversation

@Data-Wise
Copy link
Owner

Summary

  • Help compliance system — 9-rule validator for all 12 dispatcher help functions, with automated checker (flow doctor --help-check) and 342-test dogfooding suite
  • Dispatcher help standardization — All 12 dispatchers now pass compliance (box headers, MOST COMMON/QUICK EXAMPLES/TIP sections, color codes, See Also cross-references)
  • Infrastructure fixestags_file MkDocs deprecation resolved, package.json synced to v6.2.0, color fallback pattern documented in CONVENTIONS.md

Changes

New Files

  • lib/help-compliance.zsh — 9-rule compliance checker engine
  • tests/test-help-compliance.zsh — 14 core compliance tests
  • tests/test-help-compliance-dogfood.zsh — 342-test dogfooding suite (incl. negative tests)
  • docs/specs/SPEC-help-compliance-2026-02-02.md — Feature spec

Modified (12 dispatchers + infra)

  • commands/doctor.zsh--help-check flag, header migrated to _C_* colors
  • lib/dispatchers/{cc,dot,obs,prompt,r,teach,tm,v}-dispatcher.zsh — Help functions standardized
  • docs/CONVENTIONS.md — Color fallback pattern documented
  • mkdocs.yml — Removed deprecated tags_file
  • package.json — Version bumped to 6.2.0

Stats

18 files changed, +1,653 / -422 lines

Test plan

  • tests/test-help-compliance.zsh — 14/14 passing
  • tests/test-help-compliance-dogfood.zsh — 342/342 passing
  • flow doctor --help-check — 12/12 dispatchers compliant
  • mkdocs build — Builds without tags deprecation warning
  • Negative compliance test validates non-compliant help is caught

🤖 Generated with Claude Code

* docs: add help compliance spec and brainstorm

Spec for fixing all 12 dispatcher help functions to match
CONVENTIONS.md standards, plus automated compliance checker
(shared library + test suite + flow doctor integration).

Audit found 6/12 non-compliant dispatchers (2 grade F, 1 grade C,
3 grade B). Checker will enforce 9 rules via CI and on-demand CLI.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat: fix help compliance for all 12 dispatchers + add automated checker

Fix 6 non-compliant help functions against CONVENTIONS.md:173-199:
- obs: full rewrite, rename obs_help→_obs_help, add colors/sections (F→A)
- prompt: rewrite cat<<EOF to echo -e with _C_* colors (F→A)
- dot: replace FLOW_COLORS[] with _C_*, restructure sections (C→A)
- cc: change ╔═╗ to ╭─╮ box, add standard sections (B-→A)
- tm: change ╔═╗ to ╭─╮ box, add emoji markers (B-→A)
- teach: cat<<EOF to echo -e, FLOW_COLORS→_C_*, condense sections (B+→A)
- v: add missing 📚 See Also section

Add automated compliance infrastructure:
- lib/help-compliance.zsh: 9-rule shared validation library
- tests/test-help-compliance.zsh: 14-test suite (12 dispatchers + 2 meta)
- flow doctor --help-check: CLI integration for on-demand validation
- Integrated into tests/run-all.sh

All 12 dispatchers now pass all 9 compliance rules.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* test: add 336-test dogfooding suite + fix 3 dispatcher edge cases

- Add tests/test-help-compliance-dogfood.zsh (336 tests across 10 sections)
- Fix r dispatcher missing --help/-h routing
- Fix obs dispatcher --help eaten by global flag pre-parser
- Fix v dispatcher missing color fallbacks for standalone use
- Add dogfooding test to run-all.sh

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: address code review findings for help compliance PR

- Standardize v dispatcher color fallbacks to global if-block pattern
  (was local-scoped, inconsistent with other 6 fixed dispatchers)
- Expand teach help with full 26-alias shortcuts table and 3 workflow
  examples (discoverability regression from condensing 149→81 lines)
- Migrate doctor --help-check header from FLOW_COLORS[] to _C_* colors
- Tighten Rule 6 regex from '💡.*TIP' to '💡 TIP' (avoids Rule 4 overlap)
- Add negative compliance test with mock non-compliant dispatcher
- Document canonical color fallback pattern in CONVENTIONS.md

All tests pass: 14/14 core + 342/342 dogfood (was 336)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* chore: bump package.json to v6.2.0 and fix tags_file deprecation

- package.json: 6.1.0 → 6.2.0 (sync with release)
- mkdocs.yml: remove deprecated tags_file option (Material 9.6+)
  docs/tags.md already has inline <!-- material/tags --> marker

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Test User <test@example.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
@Data-Wise Data-Wise merged commit c38fdd4 into main Feb 3, 2026
2 checks passed
@Data-Wise Data-Wise mentioned this pull request Feb 4, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants