Minor workflow simplifications#144
Merged
DarkMatterCore merged 2 commits intoDarkMatterCore:rewritefrom Oct 31, 2023
Merged
Conversation
Owner
|
Thanks! I'll take a better look at this after I get back home. |
Owner
|
Looks good to me. Thanks again. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up from DarkMatterCore/libusbhsfs#29 and simplifies the existing workflow a tiny bit.
I told you about some improvements quite a while ago and never got around to PR them. It seems someone else also found improvements, so the changes I made aren't as significant.
Some notes about the changes I made:
See: Skipping workflow runs
dkp-toolchain-varspackage as well.If that PR gets accepted the last dkp-pacman line can also be removed which I'll do in a new PR.
A few other improvements that could be made, but I didn't want to include here:
Workflow run using my libusbhsfs changes: https://github.com/TSRBerry/nxdumptool/actions/runs/6709816685/job/18233685461
Although it fails in the end this seems to be unrelated to my changes.