Only blend with transpose mask in Levenshtein functions if cheaper#19
Open
kristoisberg wants to merge 1 commit intoDaniel-Liu-c0deb0t:masterfrom
Open
Only blend with transpose mask in Levenshtein functions if cheaper#19kristoisberg wants to merge 1 commit intoDaniel-Liu-c0deb0t:masterfrom
kristoisberg wants to merge 1 commit intoDaniel-Liu-c0deb0t:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17, where Restricted Damerau-Levenshtein distances were calculated incorrectly: transposition masks were used even when other operations were cheaper, resulting in higher-than-correct distances. The fix is applied to both distance calculation (including traces) and search functions.
I have to make a disclaimer that while I tested this fix in multiple ways:
...the fix itself is mostly AI-generated, as SIMD Rust is quite far out of my comfort zone, so approach with caution. 😄